[jira] [Commented] (IGNITE-7765) walSegmentSize can be negative in config

[Andrey Gura (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397042#comment-16397042
 ] 

Andrey Gura commented on IGNITE-7765:
-

[~ivandasch] LGTM. Merged to master branch. Thanks for your contribution!

> walSegmentSize can be negative in config
> 
>
> Key: IGNITE-7765
> URL: https://issues.apache.org/jira/browse/IGNITE-7765
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 2.2
>Reporter: Alexander Belyak
>Assignee: Ivan Daschinskiy
>Priority: Trivial
> Fix For: 2.5
>
>
> Grid use default (64Mb) DataStorageConfiguration.walSegmentSize without 
> warnings if negative value specified, for example if in xml specified 
> something like
>  (overflow)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7765) walSegmentSize can be negative in config

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395571#comment-16395571
 ] 

ASF GitHub Bot commented on IGNITE-7765:


GitHub user ivandasch opened a pull request:

https://github.com/apache/ignite/pull/3623

IGNITE-7765 ensure that walSegmentSize doesn't overflow



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ivandasch/ignite ignite-7765

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3623.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3623


commit 6e2adf9335885d3132be7712bb48e9c408b111b2
Author: Ivan Daschinskiy 
Date:   2018-03-12T16:08:48Z

IGNITE-7765 ensure that walSegmentSize doesn't overflow




> walSegmentSize can be negative in config
> 
>
> Key: IGNITE-7765
> URL: https://issues.apache.org/jira/browse/IGNITE-7765
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 2.2
>Reporter: Alexander Belyak
>Assignee: Ivan Daschinskiy
>Priority: Trivial
> Fix For: 2.5
>
>
> Grid use default (64Mb) DataStorageConfiguration.walSegmentSize without 
> warnings if negative value specified, for example if in xml specified 
> something like
>  (overflow)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-7765) walSegmentSize can be negative in config

[Alexander Belyak (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-7765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369971#comment-16369971
 ] 

Alexander Belyak commented on IGNITE-7765:
--

can be tested in FileWriteAheadLogmanager.checkWalConfiguration() method.

> walSegmentSize can be negative in config
> 
>
> Key: IGNITE-7765
> URL: https://issues.apache.org/jira/browse/IGNITE-7765
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 2.2
>Reporter: Alexander Belyak
>Priority: Trivial
>
> Grid use default (64Mb) DataStorageConfiguration.walSegmentSize without 
> warnings if negative value specified, for example if in xml specified 
> something like
>  (overflow)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)