[jira] [Commented] (IGNITE-7877) Improve code style in GA part
[ https://issues.apache.org/jira/browse/IGNITE-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429901#comment-16429901 ] ASF GitHub Bot commented on IGNITE-7877: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3695 > Improve code style in GA part > - > > Key: IGNITE-7877 > URL: https://issues.apache.org/jira/browse/IGNITE-7877 > Project: Ignite > Issue Type: Improvement > Components: ml >Reporter: Yury Babak >Assignee: Turik Campbell >Priority: Minor > Fix For: 2.5 > > > Not all code in which located in genetic package follows your code style. > That should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7877) Improve code style in GA part
[ https://issues.apache.org/jira/browse/IGNITE-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429548#comment-16429548 ] Turik Campbell commented on IGNITE-7877: [~chief], - Updated. Please review. > Improve code style in GA part > - > > Key: IGNITE-7877 > URL: https://issues.apache.org/jira/browse/IGNITE-7877 > Project: Ignite > Issue Type: Improvement > Components: ml >Reporter: Yury Babak >Assignee: Turik Campbell >Priority: Minor > Fix For: 2.5 > > > Not all code in which located in genetic package follows your code style. > That should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7877) Improve code style in GA part
[ https://issues.apache.org/jira/browse/IGNITE-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425260#comment-16425260 ] Yury Babak commented on IGNITE-7877: [~netmille], PR was reviewed, we still have couple issues here. > Improve code style in GA part > - > > Key: IGNITE-7877 > URL: https://issues.apache.org/jira/browse/IGNITE-7877 > Project: Ignite > Issue Type: Improvement > Components: ml >Reporter: Yury Babak >Assignee: Turik Campbell >Priority: Minor > Fix For: 2.5 > > > Not all code in which located in genetic package follows your code style. > That should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7877) Improve code style in GA part
[ https://issues.apache.org/jira/browse/IGNITE-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425237#comment-16425237 ] Yury Babak commented on IGNITE-7877: [~netmille] as for tool please check this mail thread about Intellij Idea plugin: http://apache-ignite-developers.2346864.n4.nabble.com/abbrevation-rules-plugin-td19356.html > Improve code style in GA part > - > > Key: IGNITE-7877 > URL: https://issues.apache.org/jira/browse/IGNITE-7877 > Project: Ignite > Issue Type: Improvement > Components: ml >Reporter: Yury Babak >Assignee: Turik Campbell >Priority: Minor > Fix For: 2.5 > > > Not all code in which located in genetic package follows your code style. > That should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7877) Improve code style in GA part
[ https://issues.apache.org/jira/browse/IGNITE-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412728#comment-16412728 ] ASF GitHub Bot commented on IGNITE-7877: GitHub user techbysample opened a pull request: https://github.com/apache/ignite/pull/3695 IGNITE-7877: Improve code style in GA part You can merge this pull request into a Git repository by running: $ git pull https://github.com/techbysample/ignite ignite-7877 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3695.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3695 commit f40f3a6bafde0e16cbbe062368ca279501500569 Author: Turik Campbell Date: 2018-03-18T12:07:23Z IGNITE-7877: Applied code style to classes: Chromosome, GAGrid, GAConfiguration commit b581e185a19d18b2d63bf1ae219d440ac10fbab3 Author: Turik Campbell Date: 2018-03-18T12:10:47Z IGNITE-7877: Merge branch 'master' into ignite-7877 commit d8d6c14203f5287b9483c0b3ff5ee0de8f969dde Author: Turik Campbell Date: 2018-03-24T01:55:23Z IGNITE-7877: Applied Code Style to GA Grid commit 34e7c1b45fe648eb0e7b011c2c228e641366622e Author: Turik Campbell Date: 2018-03-24T02:04:50Z IGNITE-7877: Merge branch 'master' into ignite-7877 commit 9f9d579831218ea8b4769e372efe2691a574f1e1 Author: Turik Campbell Date: 2018-03-24T18:31:39Z IGNITE-7877: Applied Code Style to GA Grid (Examples) > Improve code style in GA part > - > > Key: IGNITE-7877 > URL: https://issues.apache.org/jira/browse/IGNITE-7877 > Project: Ignite > Issue Type: Improvement > Components: ml >Reporter: Yury Babak >Assignee: Turik Campbell >Priority: Minor > > Not all code in which located in genetic package follows your code style. > That should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7877) Improve code style in GA part
[ https://issues.apache.org/jira/browse/IGNITE-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408740#comment-16408740 ] Turik Campbell commented on IGNITE-7877: [~chief], Ok, I will review and update accordingly.. > Improve code style in GA part > - > > Key: IGNITE-7877 > URL: https://issues.apache.org/jira/browse/IGNITE-7877 > Project: Ignite > Issue Type: Improvement > Components: ml >Reporter: Yury Babak >Assignee: Turik Campbell >Priority: Minor > > Not all code in which located in genetic package follows your code style. > That should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7877) Improve code style in GA part
[ https://issues.apache.org/jira/browse/IGNITE-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404980#comment-16404980 ] Yury Babak commented on IGNITE-7877: [~netmille], Mostly for all classes please check: * Illegally empty line before first class element * Comment is absent (all fields and method should have a comment) * Braces style (https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-BracesandIdentation) > Improve code style in GA part > - > > Key: IGNITE-7877 > URL: https://issues.apache.org/jira/browse/IGNITE-7877 > Project: Ignite > Issue Type: Improvement > Components: ml >Reporter: Yury Babak >Assignee: Turik Campbell >Priority: Minor > > Not all code in which located in genetic package follows your code style. > That should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-7877) Improve code style in GA part
[ https://issues.apache.org/jira/browse/IGNITE-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403999#comment-16403999 ] Turik Campbell commented on IGNITE-7877: [~chief], I have reviewed code and applied code style to following GA Grid classes: Chromosome, GAGrid, GAConconfiguration. Were these the classes you were referring to? Please advise. > Improve code style in GA part > - > > Key: IGNITE-7877 > URL: https://issues.apache.org/jira/browse/IGNITE-7877 > Project: Ignite > Issue Type: Improvement > Components: ml >Reporter: Yury Babak >Assignee: Turik Campbell >Priority: Minor > > Not all code in which located in genetic package follows your code style. > That should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
