[jira] [Commented] (IGNITE-8012) CPP: BinaryWriter::WriteElement should accept const reference instead of value.

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448155#comment-16448155 ] ASF GitHub Bot commented on IGNITE-8012: Github user asfgit closed the pull request at:

[jira] [Commented] (IGNITE-8012) CPP: BinaryWriter::WriteElement should accept const reference instead of value.

2018-04-23 Thread Dmitriy Pavlov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448137#comment-16448137 ] Dmitriy Pavlov commented on IGNITE-8012: [~isapego] , it seems ticket was reviewed, could you

[jira] [Commented] (IGNITE-8012) CPP: BinaryWriter::WriteElement should accept const reference instead of value.

2018-04-13 Thread Sergey Kalashnikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437385#comment-16437385 ] Sergey Kalashnikov commented on IGNITE-8012: [~isapego], Looks good to me. > CPP:

[jira] [Commented] (IGNITE-8012) CPP: BinaryWriter::WriteElement should accept const reference instead of value.

2018-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420576#comment-16420576 ] ASF GitHub Bot commented on IGNITE-8012: GitHub user isapego opened a pull request: