[jira] [Commented] (IGNITE-8110) GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from milliseconds to nanoseconds.
[ https://issues.apache.org/jira/browse/IGNITE-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436058#comment-16436058 ] Dmitriy Pavlov commented on IGNITE-8110: Cherry-picked fix to AI v2.5 > GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from > milliseconds to nanoseconds. > > > Key: IGNITE-8110 > URL: https://issues.apache.org/jira/browse/IGNITE-8110 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.4 >Reporter: Vyacheslav Koptilin >Assignee: Anton Kurbanov >Priority: Minor > Fix For: 2.5, 2.6 > > > The initial value of a cache flushing frequency is defined as follows: > {code} > /** Cache flushing frequence in nanos. */ > protected long cacheFlushFreqNanos = cacheFlushFreq * 1000; > {code} > where is {{cacheFlushFreq}} is equal to > {code} > /** Default flush frequency for write-behind cache store in milliseconds. > */ > public static final long DFLT_WRITE_BEHIND_FLUSH_FREQUENCY = 5000; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8110) GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from milliseconds to nanoseconds.
[ https://issues.apache.org/jira/browse/IGNITE-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436015#comment-16436015 ] ASF GitHub Bot commented on IGNITE-8110: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3742 > GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from > milliseconds to nanoseconds. > > > Key: IGNITE-8110 > URL: https://issues.apache.org/jira/browse/IGNITE-8110 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.4 >Reporter: Vyacheslav Koptilin >Assignee: Anton Kurbanov >Priority: Minor > Fix For: 2.6 > > > The initial value of a cache flushing frequency is defined as follows: > {code} > /** Cache flushing frequence in nanos. */ > protected long cacheFlushFreqNanos = cacheFlushFreq * 1000; > {code} > where is {{cacheFlushFreq}} is equal to > {code} > /** Default flush frequency for write-behind cache store in milliseconds. > */ > public static final long DFLT_WRITE_BEHIND_FLUSH_FREQUENCY = 5000; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8110) GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from milliseconds to nanoseconds.
[ https://issues.apache.org/jira/browse/IGNITE-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433999#comment-16433999 ] Anton Kurbanov commented on IGNITE-8110: [~dpavlov], looks like this test is unrelated. Only affected functionality is write-behind cache, also found several failures in test's history. On my local machine this test in suite runs fine. Failed tests are also different on separate runs for my branch: RunAll execution, these test succeeded: [https://ci.ignite.apache.org/viewLog.html?buildId=1176364=buildResultsDiv=IgniteTests24Java8_Cache2] Separate Cache tests execution where they failed: [https://ci.ignite.apache.org/viewLog.html?buildId=1177272=buildResultsDiv=IgniteTests24Java8_Cache2] > GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from > milliseconds to nanoseconds. > > > Key: IGNITE-8110 > URL: https://issues.apache.org/jira/browse/IGNITE-8110 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.4 >Reporter: Vyacheslav Koptilin >Assignee: Anton Kurbanov >Priority: Minor > Fix For: 2.6 > > > The initial value of a cache flushing frequency is defined as follows: > {code} > /** Cache flushing frequence in nanos. */ > protected long cacheFlushFreqNanos = cacheFlushFreq * 1000; > {code} > where is {{cacheFlushFreq}} is equal to > {code} > /** Default flush frequency for write-behind cache store in milliseconds. > */ > public static final long DFLT_WRITE_BEHIND_FLUSH_FREQUENCY = 5000; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8110) GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from milliseconds to nanoseconds.
[ https://issues.apache.org/jira/browse/IGNITE-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430987#comment-16430987 ] Dmitriy Pavlov commented on IGNITE-8110: Fix itself is looking good, I left several proposals in PR. > GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from > milliseconds to nanoseconds. > > > Key: IGNITE-8110 > URL: https://issues.apache.org/jira/browse/IGNITE-8110 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.4 >Reporter: Vyacheslav Koptilin >Assignee: Anton Kurbanov >Priority: Minor > Fix For: 2.6 > > > The initial value of a cache flushing frequency is defined as follows: > {code} > /** Cache flushing frequence in nanos. */ > protected long cacheFlushFreqNanos = cacheFlushFreq * 1000; > {code} > where is {{cacheFlushFreq}} is equal to > {code} > /** Default flush frequency for write-behind cache store in milliseconds. > */ > public static final long DFLT_WRITE_BEHIND_FLUSH_FREQUENCY = 5000; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8110) GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from milliseconds to nanoseconds.
[ https://issues.apache.org/jira/browse/IGNITE-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430983#comment-16430983 ] Dmitriy Pavlov commented on IGNITE-8110: Not sure it is related to this fix, but anyway, there is strange failure in {noformat} IgniteCacheTestSuite2: GridCachePartitionedTxSingleThreadedSelfTest.testOptimisticRepeatableReadRollback (master fail rate 0,0%) java.lang.AssertionError: Invalid cached value [key=1, v1=null, v2=1, grid=2] java.lang.AssertionError: Invalid cached value [key=1, v1=null, v2=1, grid=2] and IgniteCacheTestSuite2: GridCachePartitionedTxSingleThreadedSelfTest.testPessimisticReadCommittedCommit (master fail rate 0,0%) {noformat} could you please check if it is related > GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from > milliseconds to nanoseconds. > > > Key: IGNITE-8110 > URL: https://issues.apache.org/jira/browse/IGNITE-8110 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.4 >Reporter: Vyacheslav Koptilin >Assignee: Anton Kurbanov >Priority: Minor > > The initial value of a cache flushing frequency is defined as follows: > {code} > /** Cache flushing frequence in nanos. */ > protected long cacheFlushFreqNanos = cacheFlushFreq * 1000; > {code} > where is {{cacheFlushFreq}} is equal to > {code} > /** Default flush frequency for write-behind cache store in milliseconds. > */ > public static final long DFLT_WRITE_BEHIND_FLUSH_FREQUENCY = 5000; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8110) GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from milliseconds to nanoseconds.
[ https://issues.apache.org/jira/browse/IGNITE-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426877#comment-16426877 ] Dmitriy Pavlov commented on IGNITE-8110: Status: In progress. could you set it to PA? > GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from > milliseconds to nanoseconds. > > > Key: IGNITE-8110 > URL: https://issues.apache.org/jira/browse/IGNITE-8110 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.4 >Reporter: Vyacheslav Koptilin >Assignee: Anton Kurbanov >Priority: Minor > > The initial value of a cache flushing frequency is defined as follows: > {code} > /** Cache flushing frequence in nanos. */ > protected long cacheFlushFreqNanos = cacheFlushFreq * 1000; > {code} > where is {{cacheFlushFreq}} is equal to > {code} > /** Default flush frequency for write-behind cache store in milliseconds. > */ > public static final long DFLT_WRITE_BEHIND_FLUSH_FREQUENCY = 5000; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8110) GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from milliseconds to nanoseconds.
[ https://issues.apache.org/jira/browse/IGNITE-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426829#comment-16426829 ] Vyacheslav Koptilin commented on IGNITE-8110: - Looks good to me. [~dpavlov] could you please take a look at this pull-request? > GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from > milliseconds to nanoseconds. > > > Key: IGNITE-8110 > URL: https://issues.apache.org/jira/browse/IGNITE-8110 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.4 >Reporter: Vyacheslav Koptilin >Assignee: Anton Kurbanov >Priority: Minor > > The initial value of a cache flushing frequency is defined as follows: > {code} > /** Cache flushing frequence in nanos. */ > protected long cacheFlushFreqNanos = cacheFlushFreq * 1000; > {code} > where is {{cacheFlushFreq}} is equal to > {code} > /** Default flush frequency for write-behind cache store in milliseconds. > */ > public static final long DFLT_WRITE_BEHIND_FLUSH_FREQUENCY = 5000; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8110) GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from milliseconds to nanoseconds.
[ https://issues.apache.org/jira/browse/IGNITE-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426825#comment-16426825 ] Vyacheslav Koptilin commented on IGNITE-8110: - TeamCity: https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8_IgniteTests24Java8=pull%2F3742%2Fhead > GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from > milliseconds to nanoseconds. > > > Key: IGNITE-8110 > URL: https://issues.apache.org/jira/browse/IGNITE-8110 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.4 >Reporter: Vyacheslav Koptilin >Assignee: Anton Kurbanov >Priority: Minor > > The initial value of a cache flushing frequency is defined as follows: > {code} > /** Cache flushing frequence in nanos. */ > protected long cacheFlushFreqNanos = cacheFlushFreq * 1000; > {code} > where is {{cacheFlushFreq}} is equal to > {code} > /** Default flush frequency for write-behind cache store in milliseconds. > */ > public static final long DFLT_WRITE_BEHIND_FLUSH_FREQUENCY = 5000; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8110) GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from milliseconds to nanoseconds.
[ https://issues.apache.org/jira/browse/IGNITE-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424345#comment-16424345 ] ASF GitHub Bot commented on IGNITE-8110: GitHub user antkr opened a pull request: https://github.com/apache/ignite/pull/3742 IGNITE-8110 Fixed ms to nanos transformation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8110 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3742.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3742 commit f901b799710fda853b9298ff4911b018400a8ceb Author: Anton KurbanovDate: 2018-04-03T14:32:57Z IGNITE-8110 fixed transformation of cache flush frequency from ms into nanos commit 85db60395ac1fbada93ae0fc6e3030dc2d3227eb Author: Anton Kurbanov Date: 2018-04-03T16:58:55Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/ignite into ignite-8110 > GridCacheWriteBehindStore.Flusher thread uses the wrong transformation from > milliseconds to nanoseconds. > > > Key: IGNITE-8110 > URL: https://issues.apache.org/jira/browse/IGNITE-8110 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.4 >Reporter: Vyacheslav Koptilin >Assignee: Anton Kurbanov >Priority: Minor > > The initial value of a cache flushing frequency is defined as follows: > {code} > /** Cache flushing frequence in nanos. */ > protected long cacheFlushFreqNanos = cacheFlushFreq * 1000; > {code} > where is {{cacheFlushFreq}} is equal to > {code} > /** Default flush frequency for write-behind cache store in milliseconds. > */ > public static final long DFLT_WRITE_BEHIND_FLUSH_FREQUENCY = 5000; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)