[jira] [Commented] (IGNITE-8154) Add an ability to provide ExceptionListener to JmsStreamer
[ https://issues.apache.org/jira/browse/IGNITE-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446928#comment-16446928 ] ASF GitHub Bot commented on IGNITE-8154: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3828 > Add an ability to provide ExceptionListener to JmsStreamer > -- > > Key: IGNITE-8154 > URL: https://issues.apache.org/jira/browse/IGNITE-8154 > Project: Ignite > Issue Type: Improvement > Components: streaming >Affects Versions: 2.4 >Reporter: Valentin Kulichenko >Assignee: Anton Kurbanov >Priority: Major > Fix For: 2.6 > > > JMS API allows to provide custom {{ExceptionListener}} that is invoked when > an exception occurs within JMS queue/topic. Currently, {{JmsStreamer}} > doesn't use this in any way which creates two issues: > * If there is an exception, it's lost and not even logged. > * User can't provide their own listener. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8154) Add an ability to provide ExceptionListener to JmsStreamer
[ https://issues.apache.org/jira/browse/IGNITE-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446927#comment-16446927 ] Valentin Kulichenko commented on IGNITE-8154: - [~antkr], merged to master. Thanks for the contribution! > Add an ability to provide ExceptionListener to JmsStreamer > -- > > Key: IGNITE-8154 > URL: https://issues.apache.org/jira/browse/IGNITE-8154 > Project: Ignite > Issue Type: Improvement > Components: streaming >Affects Versions: 2.4 >Reporter: Valentin Kulichenko >Assignee: Anton Kurbanov >Priority: Major > Fix For: 2.6 > > > JMS API allows to provide custom {{ExceptionListener}} that is invoked when > an exception occurs within JMS queue/topic. Currently, {{JmsStreamer}} > doesn't use this in any way which creates two issues: > * If there is an exception, it's lost and not even logged. > * User can't provide their own listener. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8154) Add an ability to provide ExceptionListener to JmsStreamer
[ https://issues.apache.org/jira/browse/IGNITE-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446193#comment-16446193 ] Anton Kurbanov commented on IGNITE-8154: Done. > Add an ability to provide ExceptionListener to JmsStreamer > -- > > Key: IGNITE-8154 > URL: https://issues.apache.org/jira/browse/IGNITE-8154 > Project: Ignite > Issue Type: Improvement > Components: streaming >Affects Versions: 2.4 >Reporter: Valentin Kulichenko >Assignee: Anton Kurbanov >Priority: Major > Fix For: 2.6 > > > JMS API allows to provide custom {{ExceptionListener}} that is invoked when > an exception occurs within JMS queue/topic. Currently, {{JmsStreamer}} > doesn't use this in any way which creates two issues: > * If there is an exception, it's lost and not even logged. > * User can't provide their own listener. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8154) Add an ability to provide ExceptionListener to JmsStreamer
[ https://issues.apache.org/jira/browse/IGNITE-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444698#comment-16444698 ] Valentin Kulichenko commented on IGNITE-8154: - [~antkr], just changing to {{U.error}} is not enough, you need to pass the exception as a parameter. Currently you concatenate it with the message, therefore losing the stack trace. BTW, you should see that in the logs when running the test. Please fix this and I will merge. > Add an ability to provide ExceptionListener to JmsStreamer > -- > > Key: IGNITE-8154 > URL: https://issues.apache.org/jira/browse/IGNITE-8154 > Project: Ignite > Issue Type: Improvement > Components: streaming >Affects Versions: 2.4 >Reporter: Valentin Kulichenko >Assignee: Anton Kurbanov >Priority: Major > Fix For: 2.6 > > > JMS API allows to provide custom {{ExceptionListener}} that is invoked when > an exception occurs within JMS queue/topic. Currently, {{JmsStreamer}} > doesn't use this in any way which creates two issues: > * If there is an exception, it's lost and not even logged. > * User can't provide their own listener. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8154) Add an ability to provide ExceptionListener to JmsStreamer
[ https://issues.apache.org/jira/browse/IGNITE-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444392#comment-16444392 ] Anton Kurbanov commented on IGNITE-8154: [~vkulichenko], thank you for review! Made some changes as per your suggestions, PR refreshed: [PR|https://github.com/apache/ignite/pull/3828] > Add an ability to provide ExceptionListener to JmsStreamer > -- > > Key: IGNITE-8154 > URL: https://issues.apache.org/jira/browse/IGNITE-8154 > Project: Ignite > Issue Type: Improvement > Components: streaming >Affects Versions: 2.4 >Reporter: Valentin Kulichenko >Assignee: Anton Kurbanov >Priority: Major > Fix For: 2.6 > > > JMS API allows to provide custom {{ExceptionListener}} that is invoked when > an exception occurs within JMS queue/topic. Currently, {{JmsStreamer}} > doesn't use this in any way which creates two issues: > * If there is an exception, it's lost and not even logged. > * User can't provide their own listener. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8154) Add an ability to provide ExceptionListener to JmsStreamer
[ https://issues.apache.org/jira/browse/IGNITE-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440339#comment-16440339 ] Valentin Kulichenko commented on IGNITE-8154: - [~antkr], please replace `U.warn` with `U.error` so that the whole stack trace is logged in case of exception. In the test, you should avoid loops that can possibly never finish, like these ones: {code} while(lsnrExceptions.isEmpty()) Thread.sleep(200); {code} Instead, you should have a {CountDownLatch} that is counted down from the exception listener. Test itself should then call `await()` with a timeout and assert that it returns `true`. > Add an ability to provide ExceptionListener to JmsStreamer > -- > > Key: IGNITE-8154 > URL: https://issues.apache.org/jira/browse/IGNITE-8154 > Project: Ignite > Issue Type: Improvement > Components: streaming >Affects Versions: 2.4 >Reporter: Valentin Kulichenko >Assignee: Anton Kurbanov >Priority: Major > Fix For: 2.5 > > > JMS API allows to provide custom {{ExceptionListener}} that is invoked when > an exception occurs within JMS queue/topic. Currently, {{JmsStreamer}} > doesn't use this in any way which creates two issues: > * If there is an exception, it's lost and not even logged. > * User can't provide their own listener. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8154) Add an ability to provide ExceptionListener to JmsStreamer
[ https://issues.apache.org/jira/browse/IGNITE-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439494#comment-16439494 ] Anton Kurbanov commented on IGNITE-8154: Artifact links: [PR|https://github.com/apache/ignite/pull/3828] / [TC|https://ci.ignite.apache.org/viewQueued.html?itemId=1212512&tab=queuedBuildOverviewTab] [~slukyanov], [~vkulichenko], could you please review? > Add an ability to provide ExceptionListener to JmsStreamer > -- > > Key: IGNITE-8154 > URL: https://issues.apache.org/jira/browse/IGNITE-8154 > Project: Ignite > Issue Type: Improvement > Components: streaming >Affects Versions: 2.4 >Reporter: Valentin Kulichenko >Assignee: Anton Kurbanov >Priority: Major > Fix For: 2.5 > > > JMS API allows to provide custom {{ExceptionListener}} that is invoked when > an exception occurs within JMS queue/topic. Currently, {{JmsStreamer}} > doesn't use this in any way which creates two issues: > * If there is an exception, it's lost and not even logged. > * User can't provide their own listener. -- This message was sent by Atlassian JIRA (v7.6.3#76005)