[jira] [Commented] (IGNITE-8343) InetSocketAddress.getAddress() returns null, should check it in TcpCommunicationSpi
[
https://issues.apache.org/jira/browse/IGNITE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080482#comment-17080482
]
Ignite TC Bot commented on IGNITE-8343:
---
{panel:title=Branch: [pull/7485/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5206288buildTypeId=IgniteTests24Java8_RunAll]
> InetSocketAddress.getAddress() returns null, should check it in
> TcpCommunicationSpi
> ---
>
> Key: IGNITE-8343
> URL: https://issues.apache.org/jira/browse/IGNITE-8343
> Project: Ignite
> Issue Type: Bug
> Components: general
>Reporter: Ilya Kasnacheev
>Assignee: Sergey Chugunov
>Priority: Critical
> Labels: test
> Fix For: 2.9
>
> Attachments: TcpDiscoveryMultiJvmTest.java
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is especially notorious in the following scenario:
> {code}
> // -Djava.net.preferIPv4Stack=true
> System.err.println(new InetSocketAddress("0:0:0:0:0:0:0:1%lo",
> 12345).getAddress()); // null
> {code}
> Yes we already warn if different nodes have differing preferIPv4Stack, still
> this is warning not a error, and there may be other cases where getAddress()
> returns null. Should make a check.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-8343) InetSocketAddress.getAddress() returns null, should check it in TcpCommunicationSpi
[
https://issues.apache.org/jira/browse/IGNITE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479078#comment-16479078
]
Ilya Kasnacheev commented on IGNITE-8343:
-
It turns out there's some checks which prevents this issue to be much more
visible, in TcpDiscoverySpi.
Still, it's possible to get IPv6 addresses for Communication from other nodes
even if they Discovery by IPv4.
> InetSocketAddress.getAddress() returns null, should check it in
> TcpCommunicationSpi
> ---
>
> Key: IGNITE-8343
> URL: https://issues.apache.org/jira/browse/IGNITE-8343
> Project: Ignite
> Issue Type: Bug
> Components: general
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> This is especially notorious in the following scenario:
> {code}
> // -Djava.net.preferIPv4Stack=true
> System.err.println(new InetSocketAddress("0:0:0:0:0:0:0:1%lo",
> 12345).getAddress()); // null
> {code}
> Yes we already warn if different nodes have differing preferIPv4Stack, still
> this is warning not a error, and there may be other cases where getAddress()
> returns null. Should make a check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8343) InetSocketAddress.getAddress() returns null, should check it in TcpCommunicationSpi
[
https://issues.apache.org/jira/browse/IGNITE-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456356#comment-16456356
]
Ilya Kasnacheev commented on IGNITE-8343:
-
IMO InetSocketAddress.getAddress() should always be null-checked, via
IgniteUtils method for example.
> InetSocketAddress.getAddress() returns null, should check it in
> TcpCommunicationSpi
> ---
>
> Key: IGNITE-8343
> URL: https://issues.apache.org/jira/browse/IGNITE-8343
> Project: Ignite
> Issue Type: Bug
> Components: general
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>
> This is especially notorious in the following scenario:
> {code}
> // -Djava.net.preferIPv4Stack=true
> System.err.println(new InetSocketAddress("0:0:0:0:0:0:0:1%lo",
> 12345).getAddress()); // null
> {code}
> Yes we already warn if different nodes have differing preferIPv4Stack, still
> this is warning not a error, and there may be other cases where getAddress()
> returns null. Should make a check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
