[jira] [Commented] (IGNITE-8491) Add JMX flag: Is the node in baseline or not?

2018-05-22 Thread Ivan Rakov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483730#comment-16483730
 ] 

Ivan Rakov commented on IGNITE-8491:


Fixed.
*For anyone who needs to cherry-pick this ticket:* please note that there are 
*two commits*.
1. f8ae30d5dd426d995d7bae98674712055895bcb5 - original fix
2. e227f22adb99767f8f4e7b2be024cab5c9a82c30 - license header fix

> Add JMX flag: Is the node in baseline or not?
> -
>
> Key: IGNITE-8491
> URL: https://issues.apache.org/jira/browse/IGNITE-8491
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
>Priority: Major
> Fix For: 2.6
>
>
> Need to add a baseline flag on JMX.
> {code}
> public interface IgniteMXBean {
> /**
>  * Gets a flag is node in baseline.
>  *
>  * @return Return a baseline flag.
>  */
> @MXBeanDescription("Baseline node flag.")
> public boolean isNodeInBaseline();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8491) Add JMX flag: Is the node in baseline or not?

2018-05-22 Thread Dmitriy Pavlov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483725#comment-16483725
 ] 

Dmitriy Pavlov commented on IGNITE-8491:


[~ivan.glukos], License & Headers validation failed
https://ci.ignite.apache.org/viewLog.html?buildId=1311610&buildTypeId=IgniteTests24Java8_LicensesHeaders&tab=artifacts#!w3qd1wo,-5anhed3tul3b,1lt68ikb36szd

Unapproved licenses:
 core/src/test/java/org/apache/ignite/util/mbeans/GridMBeanBaselineTest.java

Please address

> Add JMX flag: Is the node in baseline or not?
> -
>
> Key: IGNITE-8491
> URL: https://issues.apache.org/jira/browse/IGNITE-8491
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
>Priority: Major
> Fix For: 2.6
>
>
> Need to add a baseline flag on JMX.
> {code}
> public interface IgniteMXBean {
> /**
>  * Gets a flag is node in baseline.
>  *
>  * @return Return a baseline flag.
>  */
> @MXBeanDescription("Baseline node flag.")
> public boolean isNodeInBaseline();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8491) Add JMX flag: Is the node in baseline or not?

2018-05-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480694#comment-16480694
 ] 

ASF GitHub Bot commented on IGNITE-8491:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4010


> Add JMX flag: Is the node in baseline or not?
> -
>
> Key: IGNITE-8491
> URL: https://issues.apache.org/jira/browse/IGNITE-8491
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
>Priority: Major
> Fix For: 2.6
>
>
> Need to add a baseline flag on JMX.
> {code}
> public interface IgniteMXBean {
> /**
>  * Gets a flag is node in baseline.
>  *
>  * @return Return a baseline flag.
>  */
> @MXBeanDescription("Baseline node flag.")
> public boolean isNodeInBaseline();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8491) Add JMX flag: Is the node in baseline or not?

2018-05-18 Thread Vladislav Pyatkov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480510#comment-16480510
 ] 

Vladislav Pyatkov commented on IGNITE-8491:
---

[~ivan.glukos] please, look at this patch.

> Add JMX flag: Is the node in baseline or not?
> -
>
> Key: IGNITE-8491
> URL: https://issues.apache.org/jira/browse/IGNITE-8491
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
>Priority: Major
>
> Need to add a baseline flag on JMX.
> {code}
> public interface IgniteMXBean {
> /**
>  * Gets a flag is node in baseline.
>  *
>  * @return Return a baseline flag.
>  */
> @MXBeanDescription("Baseline node flag.")
> public boolean isNodeInBaseline();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8491) Add JMX flag: Is the node in baseline or not?

2018-05-17 Thread Vladislav Pyatkov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478766#comment-16478766
 ] 

Vladislav Pyatkov commented on IGNITE-8491:
---

[~zstan] Thanks for the review.
I have fixed by your proposals.

> Add JMX flag: Is the node in baseline or not?
> -
>
> Key: IGNITE-8491
> URL: https://issues.apache.org/jira/browse/IGNITE-8491
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
>Priority: Major
>
> Need to add a baseline flag on JMX.
> {code}
> public interface IgniteMXBean {
> /**
>  * Gets a flag is node in baseline.
>  *
>  * @return Return a baseline flag.
>  */
> @MXBeanDescription("Baseline node flag.")
> public boolean isNodeInBaseline();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8491) Add JMX flag: Is the node in baseline or not?

2018-05-17 Thread Stanilovsky Evgeny (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478715#comment-16478715
 ] 

Stanilovsky Evgeny commented on IGNITE-8491:


looks good, two code fix comments in PR link, fix it.

thanks !

> Add JMX flag: Is the node in baseline or not?
> -
>
> Key: IGNITE-8491
> URL: https://issues.apache.org/jira/browse/IGNITE-8491
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
>Priority: Major
>
> Need to add a baseline flag on JMX.
> {code}
> public interface IgniteMXBean {
> /**
>  * Gets a flag is node in baseline.
>  *
>  * @return Return a baseline flag.
>  */
> @MXBeanDescription("Baseline node flag.")
> public boolean isNodeInBaseline();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8491) Add JMX flag: Is the node in baseline or not?

2018-05-17 Thread Vladislav Pyatkov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478676#comment-16478676
 ] 

Vladislav Pyatkov commented on IGNITE-8491:
---

Started TC: 
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll&tab=buildTypeChains&branch_IgniteTests24Java8=pull%2F4010%2Fhead#_expand=block_bt984-1302724

> Add JMX flag: Is the node in baseline or not?
> -
>
> Key: IGNITE-8491
> URL: https://issues.apache.org/jira/browse/IGNITE-8491
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
>Priority: Major
>
> Need to add a baseline flag on JMX.
> {code}
> public interface IgniteMXBean {
> /**
>  * Gets a flag is node in baseline.
>  *
>  * @return Return a baseline flag.
>  */
> @MXBeanDescription("Baseline node flag.")
> public boolean isNodeInBaseline();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-8491) Add JMX flag: Is the node in baseline or not?

2018-05-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478667#comment-16478667
 ] 

ASF GitHub Bot commented on IGNITE-8491:


GitHub user vldpyatkov opened a pull request:

https://github.com/apache/ignite/pull/4010

IGNITE-8491

Add JMX flag: Is the node in baseline or not?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-8491

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4010.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4010


commit 714b0b6243f904ceb74bfe5f8c194f6d31b4bf2d
Author: vd-pyatkov 
Date:   2018-05-17T07:35:15Z

IGNITE-8491
Add JMX flag: Is the node in baseline or not?




> Add JMX flag: Is the node in baseline or not?
> -
>
> Key: IGNITE-8491
> URL: https://issues.apache.org/jira/browse/IGNITE-8491
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
>Priority: Major
>
> Need to add a baseline flag on JMX.
> {code}
> public interface IgniteMXBean {
> /**
>  * Gets a flag is node in baseline.
>  *
>  * @return Return a baseline flag.
>  */
> @MXBeanDescription("Baseline node flag.")
> public boolean isNodeInBaseline();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)