[jira] [Commented] (IGNITE-8684) Partition state exchange during rebalance continues to keep sending state messages (single,full) in loop even if no changes in partition states
[ https://issues.apache.org/jira/browse/IGNITE-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546634#comment-16546634 ] ASF GitHub Bot commented on IGNITE-8684: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4287 > Partition state exchange during rebalance continues to keep sending state > messages (single,full) in loop even if no changes in partition states > --- > > Key: IGNITE-8684 > URL: https://issues.apache.org/jira/browse/IGNITE-8684 > Project: Ignite > Issue Type: Bug >Reporter: Alexei Scherbakov >Assignee: Dmitriy Govorukhin >Priority: Major > Fix For: 2.7 > > > This is due to invalid "changed" state computation in > org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl#update(org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion, > > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionFullMap, > > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.CachePartitionFullCountersMap, > java.util.Set, > org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8684) Partition state exchange during rebalance continues to keep sending state messages (single,full) in loop even if no changes in partition states
[ https://issues.apache.org/jira/browse/IGNITE-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546288#comment-16546288 ] Dmitriy Govorukhin commented on IGNITE-8684: [~agoncharuk] Could you please merge the changes? > Partition state exchange during rebalance continues to keep sending state > messages (single,full) in loop even if no changes in partition states > --- > > Key: IGNITE-8684 > URL: https://issues.apache.org/jira/browse/IGNITE-8684 > Project: Ignite > Issue Type: Bug >Reporter: Alexei Scherbakov >Assignee: Dmitriy Govorukhin >Priority: Major > Fix For: 2.7 > > > This is due to invalid "changed" state computation in > org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl#update(org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion, > > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionFullMap, > > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.CachePartitionFullCountersMap, > java.util.Set, > org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8684) Partition state exchange during rebalance continues to keep sending state messages (single,full) in loop even if no changes in partition states
[ https://issues.apache.org/jira/browse/IGNITE-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546254#comment-16546254 ] Alexey Goncharuk commented on IGNITE-8684: -- Looks good to me now > Partition state exchange during rebalance continues to keep sending state > messages (single,full) in loop even if no changes in partition states > --- > > Key: IGNITE-8684 > URL: https://issues.apache.org/jira/browse/IGNITE-8684 > Project: Ignite > Issue Type: Bug >Reporter: Alexei Scherbakov >Assignee: Dmitriy Govorukhin >Priority: Major > Fix For: 2.7 > > > This is due to invalid "changed" state computation in > org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl#update(org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion, > > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionFullMap, > > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.CachePartitionFullCountersMap, > java.util.Set, > org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8684) Partition state exchange during rebalance continues to keep sending state messages (single,full) in loop even if no changes in partition states
[ https://issues.apache.org/jira/browse/IGNITE-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535188#comment-16535188 ] Alexey Goncharuk commented on IGNITE-8684: -- Agree, makes sense to me. > Partition state exchange during rebalance continues to keep sending state > messages (single,full) in loop even if no changes in partition states > --- > > Key: IGNITE-8684 > URL: https://issues.apache.org/jira/browse/IGNITE-8684 > Project: Ignite > Issue Type: Bug >Reporter: Alexei Scherbakov >Assignee: Dmitriy Govorukhin >Priority: Major > Fix For: 2.7 > > > This is due to invalid "changed" state computation in > org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl#update(org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion, > > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionFullMap, > > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.CachePartitionFullCountersMap, > java.util.Set, > org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8684) Partition state exchange during rebalance continues to keep sending state messages (single,full) in loop even if no changes in partition states
[
https://issues.apache.org/jira/browse/IGNITE-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532796#comment-16532796
]
Dmitriy Govorukhin commented on IGNITE-8684:
[~agoncharuk] Agree, but I have a question. As far as I know, we should change
partition state on local node only on the real exchange, a case when exchangeId
null it is refreshPartitions, so maybe we can move for loop upder if
(exchangeVer!=null)?
{code}
if (exchangeVer != null & != null &&
grp.persistenceEnabled() && readyTopVer.initialized()) {
for (Map.Entry e :
nodeMap.entrySet()) {
int p = e.getKey();
GridDhtPartitionState state = e.getValue();
if (state == OWNING) {
GridDhtLocalPartition locPart = locParts.get(p);
assert locPart != null : grp.cacheOrGroupName();
if (locPart.state() == MOVING) {
boolean success = locPart.own();
assert success : locPart;
changed |= success;
}
}
else if (state == MOVING) {
boolean haveHistory = !partsToReload.contains(p);
rebalancePartition(p, haveHistory);
changed = true;
}
}
}
{code}
> Partition state exchange during rebalance continues to keep sending state
> messages (single,full) in loop even if no changes in partition states
> ---
>
> Key: IGNITE-8684
> URL: https://issues.apache.org/jira/browse/IGNITE-8684
> Project: Ignite
> Issue Type: Bug
>Reporter: Alexei Scherbakov
>Assignee: Dmitriy Govorukhin
>Priority: Major
> Fix For: 2.7
>
>
> This is due to invalid "changed" state computation in
> org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl#update(org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion,
>
> org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionFullMap,
>
> org.apache.ignite.internal.processors.cache.distributed.dht.preloader.CachePartitionFullCountersMap,
> java.util.Set,
> org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8684) Partition state exchange during rebalance continues to keep sending state messages (single,full) in loop even if no changes in partition states
[
https://issues.apache.org/jira/browse/IGNITE-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532682#comment-16532682
]
Alexey Goncharuk commented on IGNITE-8684:
--
[~DmitriyGovorukhin], I do not agree with the fix. Note that
{{rebalancePartition}} still may change the partition state, but the update
message will not be sent.
We should either put {{rebalancePartition()}} under the same {{if}}} or make
{{rebalancePartition()}} return a {{boolean}} and take the result into account.
> Partition state exchange during rebalance continues to keep sending state
> messages (single,full) in loop even if no changes in partition states
> ---
>
> Key: IGNITE-8684
> URL: https://issues.apache.org/jira/browse/IGNITE-8684
> Project: Ignite
> Issue Type: Bug
>Reporter: Alexei Scherbakov
>Assignee: Dmitriy Govorukhin
>Priority: Major
> Fix For: 2.7
>
>
> This is due to invalid "changed" state computation in
> org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl#update(org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion,
>
> org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionFullMap,
>
> org.apache.ignite.internal.processors.cache.distributed.dht.preloader.CachePartitionFullCountersMap,
> java.util.Set,
> org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8684) Partition state exchange during rebalance continues to keep sending state messages (single,full) in loop even if no changes in partition states
[ https://issues.apache.org/jira/browse/IGNITE-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529638#comment-16529638 ] ASF GitHub Bot commented on IGNITE-8684: GitHub user DmitriyGovorukhin opened a pull request: https://github.com/apache/ignite/pull/4287 IGNITE-8684 fix partition state exchange during rebalance Partition state exchange during rebalance continues to keep sending state messages (single, full) in the loop even if no changes in partition states. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8684-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4287.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4287 commit ecca120b70d211ad6586eed11e9309cd18cf9226 Author: Dmitriy Govorukhin Date: 2018-07-02T09:53:59Z IGNITE-8684 fix partition state exchange during rebalance continues to keep sending state messages (single,full) in loop even if no changes in partition states. > Partition state exchange during rebalance continues to keep sending state > messages (single,full) in loop even if no changes in partition states > --- > > Key: IGNITE-8684 > URL: https://issues.apache.org/jira/browse/IGNITE-8684 > Project: Ignite > Issue Type: Bug >Reporter: Alexei Scherbakov >Assignee: Dmitriy Govorukhin >Priority: Major > Fix For: 2.7 > > > This is due to invalid "changed" state computation in > org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl#update(org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion, > > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionFullMap, > > org.apache.ignite.internal.processors.cache.distributed.dht.preloader.CachePartitionFullCountersMap, > java.util.Set, > org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
