[jira] [Updated] (KARAF-5637) karaf-maven-plugin:features-add-to-repository crash on features with circular dependencies
[
https://issues.apache.org/jira/browse/KARAF-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan-Peter Nilsson updated KARAF-5637:
-
Flags: Patch
> karaf-maven-plugin:features-add-to-repository crash on features with circular
> dependencies
> --
>
> Key: KARAF-5637
> URL: https://issues.apache.org/jira/browse/KARAF-5637
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
>Affects Versions: 4.1.4, 4.1.5, 4.1.6
>Reporter: Jan-Peter Nilsson
>Priority: Critical
> Attachments:
> 0001-KARAF-5637-karaf-maven-plugin-features-add-to-reposi.patch
>
>
> The features-add-to-repository goal in the karaf-maven-plugin will go into an
> infinite recursion in addFeaturesDependencies (until it runs out of stack)
> when given a feature descriptor that contains features with circular
> dependencies.
> A wild example of such a feature descriptor is
> mvn:org.ops4j.pax.cdi/pax-cdi-features/1.0.0/xml/features.
>
> A reduced example
> {code:xml}
> xmlns="http://karaf.apache.org/xmlns/features/v1.4.0;>
>
> FeatureB
>
>
> FeatureA
>
>
> {code}
> {code:xml}
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> test
>
> test-features-add-to-repository-circular-dependencies
> 1.0-SNAPSHOT
> pom
>
>
>
> org.apache.karaf.tooling
> karaf-maven-plugin
> @pom.version@
>
>
> build-features-repo
> generate-resources
>
> features-add-to-repository
>
>
>
> features.xml
>
>
> ${project.build.directory}/features
>
>
>
>
>
>
>
> {code}
> This will crash the plugin
> {noformat}
> Exception in thread "main" java.lang.StackOverflowError
> at
> org.apache.karaf.tooling.features.AbstractFeatureMojo.getMatchingFeature(AbstractFeatureMojo.java:198)
> at
> org.apache.karaf.tooling.features.AbstractFeatureMojo.addFeaturesDependencies(AbstractFeatureMojo.java:188)
> at
> org.apache.karaf.tooling.features.AbstractFeatureMojo.addFeaturesDependencies(AbstractFeatureMojo.java:191)
> at
> org.apache.karaf.tooling.features.AbstractFeatureMojo.addFeaturesDependencies(AbstractFeatureMojo.java:191)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (KARAF-5637) karaf-maven-plugin:features-add-to-repository crash on features with circular dependencies
[
https://issues.apache.org/jira/browse/KARAF-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan-Peter Nilsson updated KARAF-5637:
-
Attachment: 0001-KARAF-5637-karaf-maven-plugin-features-add-to-reposi.patch
> karaf-maven-plugin:features-add-to-repository crash on features with circular
> dependencies
> --
>
> Key: KARAF-5637
> URL: https://issues.apache.org/jira/browse/KARAF-5637
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
>Affects Versions: 4.1.4, 4.1.5, 4.1.6
>Reporter: Jan-Peter Nilsson
>Priority: Critical
> Attachments:
> 0001-KARAF-5637-karaf-maven-plugin-features-add-to-reposi.patch
>
>
> The features-add-to-repository goal in the karaf-maven-plugin will go into an
> infinite recursion in addFeaturesDependencies (until it runs out of stack)
> when given a feature descriptor that contains features with circular
> dependencies.
> A wild example of such a feature descriptor is
> mvn:org.ops4j.pax.cdi/pax-cdi-features/1.0.0/xml/features.
>
> A reduced example
> {code:xml}
> xmlns="http://karaf.apache.org/xmlns/features/v1.4.0;>
>
> FeatureB
>
>
> FeatureA
>
>
> {code}
> {code:xml}
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> test
>
> test-features-add-to-repository-circular-dependencies
> 1.0-SNAPSHOT
> pom
>
>
>
> org.apache.karaf.tooling
> karaf-maven-plugin
> @pom.version@
>
>
> build-features-repo
> generate-resources
>
> features-add-to-repository
>
>
>
> features.xml
>
>
> ${project.build.directory}/features
>
>
>
>
>
>
>
> {code}
> This will crash the plugin
> {noformat}
> Exception in thread "main" java.lang.StackOverflowError
> at
> org.apache.karaf.tooling.features.AbstractFeatureMojo.getMatchingFeature(AbstractFeatureMojo.java:198)
> at
> org.apache.karaf.tooling.features.AbstractFeatureMojo.addFeaturesDependencies(AbstractFeatureMojo.java:188)
> at
> org.apache.karaf.tooling.features.AbstractFeatureMojo.addFeaturesDependencies(AbstractFeatureMojo.java:191)
> at
> org.apache.karaf.tooling.features.AbstractFeatureMojo.addFeaturesDependencies(AbstractFeatureMojo.java:191)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
