[jira] [Commented] (KUDU-1872) Expose range partitioning info in API

2018-03-06 Thread Todd Lipcon (JIRA)

[ 
https://issues.apache.org/jira/browse/KUDU-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388615#comment-16388615
 ] 

Todd Lipcon commented on KUDU-1872:
---

Directly exposing the existing PartitionSchema class as a public API doesn't 
really work because it isn't designed to be ABI-stable. We'd need a PIMPLed 
wrapper in the client namespace at least.

I think it's a mistake that KuduTable::partition_schema() exists as a public 
method. It should probably be private since it returns a private type which 
can't be used by client code anyway.

The work to provide a stable-ABI wrapper isn't too hard, just a matter of 
getting it done :)

> Expose range partitioning info in API
> -
>
> Key: KUDU-1872
> URL: https://issues.apache.org/jira/browse/KUDU-1872
> Project: Kudu
>  Issue Type: Wish
>  Components: client, impala
>Reporter: Przemyslaw Maciolek
>Priority: Major
>
> The API allows to create and drop range partitions using: 
> [AlterTableOptions#addRangePartition 
> (Java)|https://kudu.apache.org/apidocs/org/apache/kudu/client/AlterTableOptions.html#addRangePartition-org.apache.kudu.client.PartialRow-org.apache.kudu.client.PartialRow-]
>  or [KuduTableAlterer#AddRangePartition 
> (C++)|http://kudu.apache.org/releases/1.2.0/cpp-client-api/classkudu_1_1client_1_1KuduTableAlterer.html#a521a968f4db133a10629f76c75dde793]
>  - however it is currently not possible to retrieve information about the 
> currently available partitions. In effect, when partitions are to be added 
> dynamically by the client, they either must be optimistically added (i.e. 
> ignoring AlreadyExists error) or tracked separately.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KUDU-1872) Expose range partitioning info in API

2018-03-06 Thread Paul Brannan (JIRA)

[ 
https://issues.apache.org/jira/browse/KUDU-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387974#comment-16387974
 ] 

Paul Brannan commented on KUDU-1872:


Is there any reason to not include common/partition.h as part of the public 
API?  It seems stable; the last commit I see was 2016.

As a user, it feels strange to have a public function 
KuduTable::Partition_schema() that returns an opaque type.

> Expose range partitioning info in API
> -
>
> Key: KUDU-1872
> URL: https://issues.apache.org/jira/browse/KUDU-1872
> Project: Kudu
>  Issue Type: Wish
>  Components: client, impala
>Reporter: Przemyslaw Maciolek
>Priority: Major
>
> The API allows to create and drop range partitions using: 
> [AlterTableOptions#addRangePartition 
> (Java)|https://kudu.apache.org/apidocs/org/apache/kudu/client/AlterTableOptions.html#addRangePartition-org.apache.kudu.client.PartialRow-org.apache.kudu.client.PartialRow-]
>  or [KuduTableAlterer#AddRangePartition 
> (C++)|http://kudu.apache.org/releases/1.2.0/cpp-client-api/classkudu_1_1client_1_1KuduTableAlterer.html#a521a968f4db133a10629f76c75dde793]
>  - however it is currently not possible to retrieve information about the 
> currently available partitions. In effect, when partitions are to be added 
> dynamically by the client, they either must be optimistically added (i.e. 
> ignoring AlreadyExists error) or tracked separately.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KUDU-1872) Expose range partitioning info in API

2017-03-06 Thread Todd Lipcon (JIRA)

[ 
https://issues.apache.org/jira/browse/KUDU-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898004#comment-15898004
 ] 

Todd Lipcon commented on KUDU-1872:
---

In general, exposing partitioning metadata via an API would be useful for 
Impala as well. For example, if two tables are joined on a column which is 
being used for hash partitioning on both sides of the join, and the number of 
hash partitions of one table is a multiple of the other, then a more efficient 
join plan can be used.

> Expose range partitioning info in API
> -
>
> Key: KUDU-1872
> URL: https://issues.apache.org/jira/browse/KUDU-1872
> Project: Kudu
>  Issue Type: Wish
>  Components: client, impala
>Reporter: Przemyslaw Maciolek
>
> The API allows to create and drop range partitions using: 
> [AlterTableOptions#addRangePartition 
> (Java)|https://kudu.apache.org/apidocs/org/apache/kudu/client/AlterTableOptions.html#addRangePartition-org.apache.kudu.client.PartialRow-org.apache.kudu.client.PartialRow-]
>  or [KuduTableAlterer#AddRangePartition 
> (C++)|http://kudu.apache.org/releases/1.2.0/cpp-client-api/classkudu_1_1client_1_1KuduTableAlterer.html#a521a968f4db133a10629f76c75dde793]
>  - however it is currently not possible to retrieve information about the 
> currently available partitions. In effect, when partitions are to be added 
> dynamically by the client, they either must be optimistically added (i.e. 
> ignoring AlreadyExists error) or tracked separately.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)