[jira] [Commented] (KYLIN-2604) Use global dict as the default encoding for precise distinct count in web

2017-12-04 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277914#comment-16277914 ] kangkaisen commented on KYLIN-2604: --- OK, Thanks Zhixiong. I have merged the second patch to master. >

[jira] [Commented] (KYLIN-2604) Use global dict as the default encoding for precise distinct count in web

2017-12-04 Thread Zhixiong Chen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276761#comment-16276761 ] Zhixiong Chen commented on KYLIN-2604: -- Hi,[~kangkaisen] It's fine to me. Thanks! > Use global dict

[jira] [Commented] (KYLIN-2604) Use global dict as the default encoding for precise distinct count in web

2017-12-04 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276755#comment-16276755 ] kangkaisen commented on KYLIN-2604: --- Hi, Zhixiong. If you don't have any other question or advice. I

[jira] [Commented] (KYLIN-2604) Use global dict as the default encoding for precise distinct count in web

2017-09-03 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151765#comment-16151765 ] kangkaisen commented on KYLIN-2604: --- The int value is the input type of RoaringBitmap, So int value

[jira] [Commented] (KYLIN-2604) Use global dict as the default encoding for precise distinct count in web

2017-09-03 Thread Zhixiong Chen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151763#comment-16151763 ] Zhixiong Chen commented on KYLIN-2604: -- Hi, Kaishen . Why do you add a check to distinguish whether

[jira] [Commented] (KYLIN-2604) Use global dict as the default encoding for precise distinct count in web

2017-08-09 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119756#comment-16119756 ] kangkaisen commented on KYLIN-2604: --- Thanks zhixiong. I am sorry to delay KYLIN-2604 to 2.2.0 because

[jira] [Commented] (KYLIN-2604) Use global dict as the default encoding for precise distinct count in web

2017-07-22 Thread Zhixiong Chen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097343#comment-16097343 ] Zhixiong Chen commented on KYLIN-2604: -- OK. I have reviewed this patch . I will merge it into Kylin

[jira] [Commented] (KYLIN-2604) Use global dict as the default encoding for precise distinct count in web

2017-07-22 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097313#comment-16097313 ] Shaofeng SHI commented on KYLIN-2604: - [~Zhixiong Chen] Zhixiong, could you please review and merge

[jira] [Commented] (KYLIN-2604) Use global dict as the default encoding for precise distinct count in web

2017-07-13 Thread Zhixiong Chen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085548#comment-16085548 ] Zhixiong Chen commented on KYLIN-2604: -- OK. Thanks Kaisen. > Use global dict as the default encoding

[jira] [Commented] (KYLIN-2604) Use global dict as the default encoding for precise distinct count in web

2017-07-13 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085546#comment-16085546 ] kangkaisen commented on KYLIN-2604: --- Yes. I have done this work. I will submit a patch within this week.

[jira] [Commented] (KYLIN-2604) Use global dict as the default encoding for precise distinct count in web

2017-07-13 Thread Zhixiong Chen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085543#comment-16085543 ] Zhixiong Chen commented on KYLIN-2604: -- [~kangkaisen],had you completed this feature. > Use global