[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396302#comment-16396302
]
ASF subversion and git services commented on KYLIN-3119:
Commit
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396288#comment-16396288
]
ASF subversion and git services commented on KYLIN-3119:
Commit
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379643#comment-16379643
]
Roger Shi commented on KYLIN-3119:
--
Thank you [~peng.jianhua], I have some comments in the PR. Would you
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377987#comment-16377987
]
peng.jianhua commented on KYLIN-3119:
-
it's ok now,https://github.com/apache/kylin/pull/107
> A few
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377959#comment-16377959
]
Roger Shi commented on KYLIN-3119:
--
[~peng.jianhua], it's a commit, not a PR. On how to create a PR,
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377904#comment-16377904
]
peng.jianhua commented on KYLIN-3119:
-
hi,[~R0ger],please review this,thanks.
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376437#comment-16376437
]
Roger Shi commented on KYLIN-3119:
--
[~peng.jianhua] Sorry for the late response. As gitbox is online now,
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358056#comment-16358056
]
peng.jianhua commented on KYLIN-3119:
-
[~R0ger],the new patch and test cases were updated.
> A few
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357961#comment-16357961
]
peng.jianhua commented on KYLIN-3119:
-
[~R0ger] ok,I know what you mean,I will keep the sql original
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357945#comment-16357945
]
Roger Shi commented on KYLIN-3119:
--
[~peng.jianhua], for this line I also have a question. If a string
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357886#comment-16357886
]
peng.jianhua commented on KYLIN-3119:
-
Hi,[~R0ger]
{code:java}
sql = sql.replaceAll("\\s+", " ");
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357867#comment-16357867
]
Roger Shi commented on KYLIN-3119:
--
Hi [~peng.jianhua], it's a good catch. I have one comment on the
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356764#comment-16356764
]
Billy Liu commented on KYLIN-3119:
--
[~rogershi], could you review this two patch?
> A few bugs in the
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338793#comment-16338793
]
peng.jianhua commented on KYLIN-3119:
-
ok,[~yimingliu]
> A few bugs in the function 'massageSql' of
[
https://issues.apache.org/jira/browse/KYLIN-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337117#comment-16337117
]
Billy Liu commented on KYLIN-3119:
--
Hello [~peng.jianhua] could you add test cases for this JIRA?
> A
15 matches
Mail list logo
