[jira] [Updated] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

2018-03-12 Thread Billy Liu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Billy Liu updated KYLIN-3236:
-
Fix Version/s: (was: v2.4.0)
   v2.3.1

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.1
>
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

2018-02-06 Thread Peng Xing (JIRA) 

 [ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peng Xing updated KYLIN-3236:
-
Attachment: 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

2018-02-05 Thread Peng Xing (JIRA) 

 [ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peng Xing updated KYLIN-3236:
-
Attachment: 2.PNG
1.PNG
3.PNG

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

2018-02-05 Thread Zhixiong Chen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhixiong Chen updated KYLIN-3236:
-
Description: 
# When remove deprecated distinct measures, the code has an error logical 
judgment In function 'reGenerateAdvancedDict()', as follows:

{code:java}
//remove deprecated distinct measures
angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) {
  if (distinctMeasures.indexOf(dict.column) === -1 && 
reuseColumns.indexOf(dict.column) === -1) {
$scope.cubeMetaFrame.dictionaries.splice(index, 1);
  }
});
{code}
This will result in accidental deletion of advanced dictionaries.
 Please review the patch, thanks!

  was:
When remove deprecated distinct measures, the code has an error logical 
judgment In function 'reGenerateAdvancedDict()', as follows:

{code:java}
//remove deprecated distinct measures
angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) {
  if (distinctMeasures.indexOf(dict.column) === -1 && 
reuseColumns.indexOf(dict.column) === -1) {
$scope.cubeMetaFrame.dictionaries.splice(index, 1);
  }
});
{code}

This will result in accidental deletion of advanced dictionaries.
Please review the patch, thanks!



> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

2018-02-04 Thread Peng Xing (JIRA) 

 [ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peng Xing updated KYLIN-3236:
-
Description: 
When remove deprecated distinct measures, the code has an error logical 
judgment In function 'reGenerateAdvancedDict()', as follows:

{code:java}
//remove deprecated distinct measures
angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) {
  if (distinctMeasures.indexOf(dict.column) === -1 && 
reuseColumns.indexOf(dict.column) === -1) {
$scope.cubeMetaFrame.dictionaries.splice(index, 1);
  }
});
{code}

This will result in accidental deletion of advanced dictionaries.
Please review the patch, thanks!


  was:
When remove deprecated distinct measures, the code has an error logical 
judgment In function 'reGenerateAdvancedDict()', as follows:

{code:java}
//remove deprecated distinct measures
angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) {
  if (distinctMeasures.indexOf(dict.column) === -1 && 
reuseColumns.indexOf(dict.column) === -1) {
$scope.cubeMetaFrame.dictionaries.splice(index, 1);
  }
});
{code}

This will result in accidental deletion of advanced dictionaries.



> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch
>
>
> When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
> Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

2018-02-04 Thread Peng Xing (JIRA) 

 [ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peng Xing updated KYLIN-3236:
-
Summary: The function 'reGenerateAdvancedDict()' has an error logical 
judgment, which will cause an exception when you edit the cube.  (was: The 
function 'reGenerateAdvancedDict()' has an error logical judgment, which will 
cause the exception when you edit the cube.)

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch
>
>
> When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause the exception when you edit the cube.

2018-02-04 Thread Peng Xing (JIRA) 

 [ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peng Xing updated KYLIN-3236:
-
Attachment: 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause the exception when you edit the cube.
> -
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch
>
>
> When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)