[jira] [Commented] (LUCENE-9264) Remove SimpleFSDirectory in favor of NIOFsDirectory

2020-03-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052077#comment-17052077 ] Robert Muir commented on LUCENE-9264: - +1 > Remove SimpleFSDirectory in favor of NIOFsDirectory >

[GitHub] [lucene-solr] bruno-roustant opened a new pull request #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes.

2020-03-05 Thread GitBox
bruno-roustant opened a new pull request #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes. URL: https://github.com/apache/lucene-solr/pull/1320 This PR modifies many classes because it removes Reader attributes now unused because FST is always loaded

[jira] [Updated] (LUCENE-8103) QueryValueSource should use TwoPhaseIterator

2020-03-05 Thread Michele Palmia (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michele Palmia updated LUCENE-8103: --- Attachment: LUCENE-8103.patch > QueryValueSource should use TwoPhaseIterator >

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1313: LUCENE-8962: Split test case

2020-03-05 Thread GitBox
msokolov commented on a change in pull request #1313: LUCENE-8962: Split test case URL: https://github.com/apache/lucene-solr/pull/1313#discussion_r388264716 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriterMergePolicy.java ## @@ -298,63 +320,44

[jira] [Commented] (LUCENE-9257) FSTLoadMode should not be BlockTree specific as it is used more generally in index package

2020-03-05 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052040#comment-17052040 ] Bruno Roustant commented on LUCENE-9257: New PR#1320 which removes FSTLoadMode and *also* Reader

[jira] [Created] (LUCENE-9264) Remove SimpleFSDirectory in favor of NIOFsDirectory

2020-03-05 Thread Yannick Welsch (Jira)
Yannick Welsch created LUCENE-9264: -- Summary: Remove SimpleFSDirectory in favor of NIOFsDirectory Key: LUCENE-9264 URL: https://issues.apache.org/jira/browse/LUCENE-9264 Project: Lucene - Core

[jira] [Commented] (SOLR-14147) enable security manager by default

2020-03-05 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052069#comment-17052069 ] Cassandra Targett commented on SOLR-14147: -- I just noticed that this commit removed a section of

[jira] [Resolved] (SOLR-13983) remove or replace process execution in SystemInfoHandler

2020-03-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved SOLR-13983. Fix Version/s: 8.5 Resolution: Fixed > remove or replace process execution in

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes.

2020-03-05 Thread GitBox
juanka588 commented on a change in pull request #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes. URL: https://github.com/apache/lucene-solr/pull/1320#discussion_r388274441 ## File path:

[jira] [Commented] (SOLR-14284) Document that you can add a new stream function via add-expressible

2020-03-05 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052157#comment-17052157 ] Cassandra Targett commented on SOLR-14284: -- I took a pass on review of this today. I can't

[jira] [Commented] (SOLR-14284) Document that you can add a new stream function via add-expressible

2020-03-05 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052162#comment-17052162 ] Eric Pugh commented on SOLR-14284: -- Thanks! I suspect I goofed the commit. “Works on my laptop” said

[GitHub] [lucene-solr] ctargett commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component

2020-03-05 Thread GitBox
ctargett commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292#discussion_r388311699 ## File path: solr/solr-ref-guide/src/stream-api.adoc ## @@

[jira] [Updated] (SOLR-13919) RefGuide: Add example for AuditLogger to use log4j to log into separate files

2020-03-05 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-13919: - Component/s: documentation > RefGuide: Add example for AuditLogger to use log4j to log

[jira] [Updated] (SOLR-12865) Custom JSON parser's nested documents example does not work

2020-03-05 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-12865: - Component/s: documentation > Custom JSON parser's nested documents example does not work

[jira] [Updated] (LUCENE-9258) DocTermsIndexDocValues should not assume it's operating on a SortedDocValues field

2020-03-05 Thread Michele Palmia (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michele Palmia updated LUCENE-9258: --- Affects Version/s: 7.7.2 > DocTermsIndexDocValues should not assume it's operating on a

[jira] [Commented] (SOLR-14306) Refactor coordination code into separate module and evaluate using Curator

2020-03-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051873#comment-17051873 ] Jan Høydahl commented on SOLR-14306: Seems Kafka has had the same discussions (see

[jira] [Comment Edited] (LUCENE-9077) Gradle build

2020-03-05 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051889#comment-17051889 ] Dawid Weiss edited comment on LUCENE-9077 at 3/5/20, 8:27 AM: -- There is no

[jira] [Commented] (LUCENE-9077) Gradle build

2020-03-05 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051889#comment-17051889 ] Dawid Weiss commented on LUCENE-9077: - There is no word-for-word equivalent but the functionality is

[GitHub] [lucene-solr] s1monw commented on issue #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying

2020-03-05 Thread GitBox
s1monw commented on issue #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying URL: https://github.com/apache/lucene-solr/pull/1274#issuecomment-595130965 @mikemccand @dnhatn I explored one more idea that less intrusive and more contained. I like this one

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully

2020-03-05 Thread GitBox
dweiss commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319#discussion_r388181480 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@

[GitHub] [lucene-solr] s1monw opened a new pull request #1319: LUCENE-9164: process all events before closing gracefully

2020-03-05 Thread GitBox
s1monw opened a new pull request #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319 This is yet another / simpler approach to https://github.com/apache/lucene-solr/pull/1274 to ensure that all event are processed if we

[GitHub] [lucene-solr] s1monw commented on issue #1319: LUCENE-9164: process all events before closing gracefully

2020-03-05 Thread GitBox
s1monw commented on issue #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319#issuecomment-595136991 thanks for looking @dweiss This is an automated message

[GitHub] [lucene-solr] ctargett commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component

2020-03-05 Thread GitBox
ctargett commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292#discussion_r388300341 ## File path: solr/solr-ref-guide/src/stream-api.adoc ## @@

[GitHub] [lucene-solr] ctargett commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component

2020-03-05 Thread GitBox
ctargett commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-595237017 The changes here are slightly confusing because the descriptions of the Jira and the PR refer

[GitHub] [lucene-solr] epugh commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component

2020-03-05 Thread GitBox
epugh commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-595290097 I think I have responded and pushed up all changes. Thank you for reviewing, and let me know if

[GitHub] [lucene-solr] epugh commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component

2020-03-05 Thread GitBox
epugh commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component URL: https://github.com/apache/lucene-solr/pull/1292#discussion_r388354635 ## File path: solr/solr-ref-guide/src/stream-api.adoc ## @@

[jira] [Commented] (SOLR-14306) Refactor coordination code into separate module and evaluate using Curator

2020-03-05 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052518#comment-17052518 ] Marcus Eagan commented on SOLR-14306: - I have been thinking about this approach and following the

[jira] [Commented] (SOLR-11359) An autoscaling/suggestions endpoint to recommend operations

2020-03-05 Thread Megan Carey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052544#comment-17052544 ] Megan Carey commented on SOLR-11359: Would it be possible to explicitly return the URL to hit for

[jira] [Commented] (SOLR-14044) Support shard/collection deletion in shared storage

2020-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052545#comment-17052545 ] ASF subversion and git services commented on SOLR-14044: Commit

[GitHub] [lucene-solr] yonik merged pull request #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter

2020-03-05 Thread GitBox
yonik merged pull request #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter URL: https://github.com/apache/lucene-solr/pull/1293 This is an automated message from the

[GitHub] [lucene-solr] andyvuong commented on issue #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter

2020-03-05 Thread GitBox
andyvuong commented on issue #1293: SOLR-14044: Delete collection bug fix by changing sharedShardName to use the same blob delimiter URL: https://github.com/apache/lucene-solr/pull/1293#issuecomment-595431605 cc @yonik can you merge. Thanks

[GitHub] [lucene-solr] msokolov commented on issue #1313: LUCENE-8962: Split test case

2020-03-05 Thread GitBox
msokolov commented on issue #1313: LUCENE-8962: Split test case URL: https://github.com/apache/lucene-solr/pull/1313#issuecomment-595436417 I verified this fixes the `TestIndexWriterExceptions2.testBasics` reported by @jpountz and also beasted that test 1000x just in case. I think we need

[jira] [Commented] (SOLR-14306) Refactor coordination code into separate module and evaluate using Curator

2020-03-05 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052458#comment-17052458 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-14306: -- Yes, I don't like merging

[GitHub] [lucene-solr] jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats.

2020-03-05 Thread GitBox
jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats. URL: https://github.com/apache/lucene-solr/pull/1314#issuecomment-594242054 **Benchmarks** In these benchmarks, we find the nearest k=10 vectors and record the recall and queries

[GitHub] [lucene-solr] msokolov merged pull request #1313: LUCENE-8962: Split test case

2020-03-05 Thread GitBox
msokolov merged pull request #1313: LUCENE-8962: Split test case URL: https://github.com/apache/lucene-solr/pull/1313 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052508#comment-17052508 ] ASF subversion and git services commented on LUCENE-8962: - Commit

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052510#comment-17052510 ] ASF subversion and git services commented on LUCENE-8962: - Commit

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052512#comment-17052512 ] ASF subversion and git services commented on LUCENE-8962: - Commit

[jira] [Commented] (SOLR-14306) Refactor coordination code into separate module and evaluate using Curator

2020-03-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052526#comment-17052526 ] Jan Høydahl commented on SOLR-14306: {quote}It seems that refactoring coordination code into a

[jira] [Created] (SOLR-14308) Multi-threaded facet.query

2020-03-05 Thread Gregory Koldirkaev (Jira)
Gregory Koldirkaev created SOLR-14308: - Summary: Multi-threaded facet.query Key: SOLR-14308 URL: https://issues.apache.org/jira/browse/SOLR-14308 Project: Solr Issue Type: Improvement

[jira] [Commented] (SOLR-13749) Implement support for joining across collections with multiple shards ( XCJF )

2020-03-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053039#comment-17053039 ] David Smiley commented on SOLR-13749: - [~romseygeek] (8.5 RM) in this issue I'm proposing we expose

[jira] [Commented] (SOLR-14040) solr.xml shareSchema does not work in SolrCloud

2020-03-05 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053038#comment-17053038 ] Noble Paul commented on SOLR-14040: --- Please document this in the ref guide and we can unblock this. our

[GitHub] [lucene-solr] dnhatn commented on issue #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-03-05 Thread GitBox
dnhatn commented on issue #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#issuecomment-595607002 Hmm, I missed the fact that `mergeFinished` is executed under IndexWriter lock. I will dig into this again. Please ignore my

[jira] [Commented] (LUCENE-9241) fix most memory-hungry tests

2020-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052697#comment-17052697 ] ASF subversion and git services commented on LUCENE-9241: - Commit

[jira] [Commented] (SOLR-14307) "user caches" don't support "enabled" attribute

2020-03-05 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052757#comment-17052757 ] Lucene/Solr QA commented on SOLR-14307: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[GitHub] [lucene-solr] dnhatn commented on issue #1313: LUCENE-8962: Split test case

2020-03-05 Thread GitBox
dnhatn commented on issue #1313: LUCENE-8962: Split test case URL: https://github.com/apache/lucene-solr/pull/1313#issuecomment-595597021 I've left some comments in https://github.com/apache/lucene-solr/pull/1155. This is an

[jira] [Commented] (SOLR-14232) Add shareSchema leak protections

2020-03-05 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053037#comment-17053037 ] Noble Paul commented on SOLR-14232: --- let's say we have classes shared between your solrconfig and

[jira] [Commented] (SOLR-14040) solr.xml shareSchema does not work in SolrCloud

2020-03-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053036#comment-17053036 ] David Smiley commented on SOLR-14040: - > But it affected a small subset of users. Now, we have

[GitHub] [lucene-solr] dnhatn commented on issue #1319: LUCENE-9164: process all events before closing gracefully

2020-03-05 Thread GitBox
dnhatn commented on issue #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319#issuecomment-595598568 Thanks, Simon. I will take a look at this tomorrow. This

[jira] [Commented] (LUCENE-9136) Introduce IVFFlat to Lucene for ANN similarity search

2020-03-05 Thread Xin-Chun Zhang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052727#comment-17052727 ] Xin-Chun Zhang commented on LUCENE-9136: Hi, [~jtibshirani], thanks for you excellent work! ??I

[jira] [Comment Edited] (LUCENE-9136) Introduce IVFFlat to Lucene for ANN similarity search

2020-03-05 Thread Xin-Chun Zhang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052727#comment-17052727 ] Xin-Chun Zhang edited comment on LUCENE-9136 at 3/6/20, 3:34 AM: - Hi,

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-03-05 Thread GitBox
dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388717615 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3252,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-03-05 Thread GitBox
dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388705514 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3147,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-03-05 Thread GitBox
dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388705156 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3252,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-03-05 Thread GitBox
dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388704872 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3147,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-03-05 Thread GitBox
dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388717615 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3252,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-03-05 Thread GitBox
dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388704872 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3147,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-03-05 Thread GitBox
dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388705514 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3147,6

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-03-05 Thread GitBox
dnhatn commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r388705156 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3252,6

[jira] [Commented] (SOLR-13942) /api/cluster/zk/* to fetch raw ZK data

2020-03-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053047#comment-17053047 ] David Smiley commented on SOLR-13942: - FWIW I really like Shalin's input, and his option #3 which

[jira] [Commented] (SOLR-13765) Deadlock on Solr cloud request causing 'Too many open files' error

2020-03-05 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053061#comment-17053061 ] Munendra S N commented on SOLR-13765: - This issue is resolved in SOLR-13793 by limiting the number of

[GitHub] [lucene-solr] bruno-roustant commented on issue #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes.

2020-03-05 Thread GitBox
bruno-roustant commented on issue #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes. URL: https://github.com/apache/lucene-solr/pull/1320#issuecomment-595474374 Good point. I added it and classified as 'Other'.

[jira] [Commented] (LUCENE-9241) fix most memory-hungry tests

2020-03-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052668#comment-17052668 ] Robert Muir commented on LUCENE-9241: - [~dweiss] I saw a recent URLclassloader windows leak thread

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052608#comment-17052608 ] ASF subversion and git services commented on LUCENE-8962: - Commit

[GitHub] [lucene-solr] dnhatn commented on issue #1313: LUCENE-8962: Split test case

2020-03-05 Thread GitBox
dnhatn commented on issue #1313: LUCENE-8962: Split test case URL: https://github.com/apache/lucene-solr/pull/1313#issuecomment-595503029 @msfroh @msokolov Thank you for working on the fix. Unfortunately, this is still an issue. Many Elasticsearch tests are

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2020-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052607#comment-17052607 ] ASF subversion and git services commented on LUCENE-8962: - Commit

[jira] [Updated] (SOLR-14307) "user caches" don't support "enable"

2020-03-05 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14307: -- Attachment: SOLR-14307.patch Status: Open (was: Open) patch with fix and

[jira] [Updated] (SOLR-14307) "user caches" don't support "enable"

2020-03-05 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14307: -- Status: Patch Available (was: Open) > "user caches" don't support "enable" >

[jira] [Updated] (SOLR-14307) "user caches" don't support "enabled" attribute

2020-03-05 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14307: -- Summary: "user caches" don't support "enabled" attribute (was: "user caches" don't

[jira] [Commented] (LUCENE-9136) Introduce IVFFlat to Lucene for ANN similarity search

2020-03-05 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052614#comment-17052614 ] Julie Tibshirani commented on LUCENE-9136: -- Hello [~tomoko]! My explanation before was way too

[jira] [Resolved] (SOLR-13120) Bad Documentation Link

2020-03-05 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett resolved SOLR-13120. -- Resolution: Won't Fix The page in question hadn't been part of our official docs for a

[jira] [Commented] (LUCENE-9264) Remove SimpleFSDirectory in favor of NIOFsDirectory

2020-03-05 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052214#comment-17052214 ] Bruno Roustant commented on LUCENE-9264: +1 > Remove SimpleFSDirectory in favor of

[GitHub] [lucene-solr] ctargett commented on issue #1291: LUCENE-9016: RefGuide meta doc for how to publish website

2020-03-05 Thread GitBox
ctargett commented on issue #1291: LUCENE-9016: RefGuide meta doc for how to publish website URL: https://github.com/apache/lucene-solr/pull/1291#issuecomment-595274181 Sorry, I approved this and then looked at why precommit failed and there is still 1 page reference that is incorrect

[jira] [Commented] (SOLR-13807) Caching for term facet counts

2020-03-05 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052350#comment-17052350 ] Chris M. Hostetter commented on SOLR-13807: --- bq. my understanding of CacheHelper.getKey() is

[jira] [Closed] (LUCENE-9016) Document how to update web site

2020-03-05 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl closed LUCENE-9016. --- > Document how to update web site > --- > > Key:

[jira] [Resolved] (LUCENE-9016) Document how to update web site

2020-03-05 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved LUCENE-9016. - Resolution: Fixed > Document how to update web site > --- > >

[jira] [Commented] (LUCENE-9016) Document how to update web site

2020-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052354#comment-17052354 ] ASF subversion and git services commented on LUCENE-9016: - Commit

[jira] [Commented] (LUCENE-9264) Remove SimpleFSDirectory in favor of NIOFsDirectory

2020-03-05 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052390#comment-17052390 ] Michael McCandless commented on LUCENE-9264: +1 > Remove SimpleFSDirectory in favor of

[jira] [Commented] (SOLR-12325) introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet

2020-03-05 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052324#comment-17052324 ] Munendra S N commented on SOLR-12325: - +1 to adding additional test Few nitpicks * Remove any usage

[GitHub] [lucene-solr] jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats.

2020-03-05 Thread GitBox
jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats. URL: https://github.com/apache/lucene-solr/pull/1314#issuecomment-594242054 **Benchmarks** In these benchmarks, we find the nearest k=10 vectors and record the recall and queries

[GitHub] [lucene-solr] jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats.

2020-03-05 Thread GitBox
jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats. URL: https://github.com/apache/lucene-solr/pull/1314#issuecomment-594242054 **Benchmarks** In these benchmarks, we find the nearest k=10 vectors and record the recall and queries

[jira] [Commented] (LUCENE-9264) Remove SimpleFSDirectory in favor of NIOFsDirectory

2020-03-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052409#comment-17052409 ] Adrien Grand commented on LUCENE-9264: -- +1 [~ywelsch] would you like to open a pull request? >

[jira] [Commented] (LUCENE-9016) Document how to update web site

2020-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052352#comment-17052352 ] ASF subversion and git services commented on LUCENE-9016: - Commit

[GitHub] [lucene-solr] janhoy merged pull request #1291: LUCENE-9016: RefGuide meta doc for how to publish website

2020-03-05 Thread GitBox
janhoy merged pull request #1291: LUCENE-9016: RefGuide meta doc for how to publish website URL: https://github.com/apache/lucene-solr/pull/1291 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-03-05 Thread GitBox
jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r388497511 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-03-05 Thread GitBox
jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r388493819 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-03-05 Thread GitBox
jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r388497042 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java

[jira] [Commented] (SOLR-14306) Refactor coordination code into separate module and evaluate using Curator

2020-03-05 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052383#comment-17052383 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-14306: -- Thanks Jan. I think with the

[GitHub] [lucene-solr] jpountz commented on issue #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes.

2020-03-05 Thread GitBox
jpountz commented on issue #1320: LUCENE-9257: Always keep FST off-heap. Remove FSTLoadMode and Reader attributes. URL: https://github.com/apache/lucene-solr/pull/1320#issuecomment-595382926 In the spirit of @dsmiley 's recent email, let's add a CHANGES entry?

[GitHub] [lucene-solr] mikemccand commented on issue #1319: LUCENE-9164: process all events before closing gracefully

2020-03-05 Thread GitBox
mikemccand commented on issue #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319#issuecomment-595367820 I'll try to review this one soon! This is an

[GitHub] [lucene-solr] jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats.

2020-03-05 Thread GitBox
jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats. URL: https://github.com/apache/lucene-solr/pull/1314#issuecomment-594242054 **Benchmarks** sift-128-euclidean: a dataset of 1 million SIFT descriptors with 128 dims. ```

[GitHub] [lucene-solr] jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats.

2020-03-05 Thread GitBox
jtibshirani edited a comment on issue #1314: LUCENE-9136: Coarse quantization that reuses existing formats. URL: https://github.com/apache/lucene-solr/pull/1314#issuecomment-594242054 **Benchmarks** sift-128-euclidean: a dataset of 1 million SIFT descriptors with 128 dims. ```

[jira] [Commented] (SOLR-14274) Multiple CoreContainers will register the same JVM Metrics

2020-03-05 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052427#comment-17052427 ] Mike Drob commented on SOLR-14274: -- [~ab] - gentle ping on this, would be interested to know what you