dweiss commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830767123
> For developers, yes. For Jenkins: No. Jenkins only needs to collect the
jacoco.exec files and generates report on its own. So the jenkins job just sets
property and runs tests -
dweiss commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830766980
SimpleServer is invoked from another test. It shouldn't be included by
default in test runs though (there is a test file name pattern?). I'm not sure
why it's being called.
--
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830792571
Do we need the delete task at all? From Gradle's documentation:
> Tasks configured for running with the JaCoCo agent delete the destination
file for the execution data
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830815745
Hi @rmuir,
I removed the extra task. In my tests, the coverage was not adding up. In
all combinations (with "gradlew coverage", "gradlew -Dtests.coverage=true
test",...) it
dweiss commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830777822
I corrected the code - simple server actually utilizes test infrastructure
and will fail if it's not a "test"... I think what I committed solves the
problem with minimal effort?
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830808504
> > Tasks configured for running with the JaCoCo agent delete the
destination file for the execution data when the task starts executing. This
ensures that no stale coverage data is
[
https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-9188.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> Add jacoco code coverage support to gradle
Greg Miller created LUCENE-9948:
---
Summary: Automatically detect multi- vs. single-valued cases in
LongValueFacetCounts
Key: LUCENE-9948
URL: https://issues.apache.org/jira/browse/LUCENE-9948
Project:
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830776087
> SimpleServer is invoked from another test. It shouldn't be included by
default in test runs though (there is a test file name pattern?). I'm not sure
why it's being called.
uschindler commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624668806
##
File path:
lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java
##
@@ -607,17 +608,19 @@ NodeProcess
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830785124
> It shouldn't be included by default in test runs though (there is a test
file name pattern?)
Although this was not the problem here: We have no filename pattern! It
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830788731
This all looks fine now:
https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/18/ -- I also
ran the NRT replication tests with tests.nightly on my local machine, it
uschindler commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624675556
##
File path: gradle/testing/coverage.gradle
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830790991
I found a small problem with the delete task. @dweiss: can you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830819657
Config now looks like this:
--
This is an automated
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830785450
I think we should at least run the test once with tests.nightly=true, as
most tests in StresstestNRTReplication are only running nightly.
--
This is an automated message from
[
https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338034#comment-17338034
]
ASF subversion and git services commented on LUCENE-9188:
-
Commit
uschindler merged pull request #119:
URL: https://github.com/apache/lucene/pull/119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reassigned LUCENE-9188:
-
Assignee: Uwe Schindler
I merged the pull request.
> Add jacoco code coverage support
[
https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9188:
--
Attachment: screenshot-1.png
> Add jacoco code coverage support to gradle build
>
[
https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338036#comment-17338036
]
Uwe Schindler commented on LUCENE-9188:
---
The new Jenkins config now looks like this:
[
https://issues.apache.org/jira/browse/LUCENE-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338048#comment-17338048
]
Greg Miller commented on LUCENE-9946:
-
I've created LUCENE-9948 to track an API refresh for
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338046#comment-17338046
]
Greg Miller commented on LUCENE-9948:
-
Attached a PR with some "nocommit" questions in it. An
[
https://issues.apache.org/jira/browse/LUCENE-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338076#comment-17338076
]
ASF subversion and git services commented on LUCENE-9909:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338077#comment-17338077
]
ASF subversion and git services commented on LUCENE-9909:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9909.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> Some jflex regeneration tasks should also
dweiss merged pull request #121:
URL: https://github.com/apache/lucene/pull/121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
uschindler commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624732263
##
File path: gradle/testing/coverage.gradle
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338038#comment-17338038
]
Greg Miller commented on LUCENE-9948:
-
I've got a PR almost ready for the implementation changes. I
[
https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338040#comment-17338040
]
Uwe Schindler commented on LUCENE-9188:
---
To run coverage, now the following needs to be done for
gsmiller opened a new pull request #122:
URL: https://github.com/apache/lucene/pull/122
# Description
Automatically detect single- vs. multi-value cases instead of asking the
user to specify.
NOTE: Contains "nocommit" questions in comments that I'd like to resolve
before
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830829699
Thanks @uschindler @dweiss for the assistance here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dweiss commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624726031
##
File path: gradle/testing/coverage.gradle
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338091#comment-17338091
]
Robert Muir commented on LUCENE-9948:
-
For 9.0, i wouldnt add back compat at all or deprecations. I
uschindler commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624745614
##
File path: gradle/testing/coverage.gradle
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dweiss commented on a change in pull request #119:
URL: https://github.com/apache/lucene/pull/119#discussion_r624736809
##
File path: gradle/testing/coverage.gradle
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
Gautam Worah created LUCENE-9949:
Summary: Flaky test in TestCachePurging.testBackgroundPurges
Key: LUCENE-9949
URL: https://issues.apache.org/jira/browse/LUCENE-9949
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338187#comment-17338187
]
ASF subversion and git services commented on LUCENE-9047:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-9047.
--
Assignee: Ignacio Vera
Resolution: Fixed
> Directory APIs should be little endian
>
iverase merged pull request #107:
URL: https://github.com/apache/lucene/pull/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
40 matches
Mail list logo
