Re: [I] Test failure in TestHnswFloatVectorGraph [lucene]

msokolov commented on issue #12945: URL: https://github.com/apache/lucene/issues/12945#issuecomment-1858117628 I spent a while staring at the previous refactor commit, and: (1) I am convinced the refactor you did is way cleaner.(2) it was a lot to do in a refactor and it is hard to

Re: [PR] Use hppc IntIntHashMap to avoid Integer box/unbox when remapping vector ordinals during merge [lucene]

msokolov merged PR #12950: URL: https://github.com/apache/lucene/pull/12950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Use hppc IntIntHashMap to avoid Integer box/unbox when remapping vector ordinals during merge [lucene]

msokolov commented on PR #12950: URL: https://github.com/apache/lucene/pull/12950#issuecomment-1858315636 also cherry-picked to 9x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add ParentJoin KNN support [lucene]

gauravj88 commented on PR #12434: URL: https://github.com/apache/lucene/pull/12434#issuecomment-1857999310 Hello @benwtrent @alessandrobenedetti , I'm seeking assistance in comprehending how to calculate the total score for a parent document, sort it in descending order by the score, and

[I] Occasional OOMEs when running the test suite [lucene]

stefanvodita opened a new issue, #12949: URL: https://github.com/apache/lucene/issues/12949 ### Description I've seen `OutOfMemoryError`s a few times recently when doing `./gradlew test` or `./gradlew check`. I don't think this is related to my changes, because it's intermittent and

Re: [PR] Add new token filters for Japanese sutegana (捨て仮名) [lucene]

daixque commented on PR #12915: URL: https://github.com/apache/lucene/pull/12915#issuecomment-1858684072 I did refactoring to apply a same kind of enhancement to Katakana filter as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] Test failure in TestHnswFloatVectorGraph [lucene]

msokolov commented on issue #12945: URL: https://github.com/apache/lucene/issues/12945#issuecomment-1858052541 one weird thing I noticed is the failing test seed only fails when `-Ptests.directory=MMapDirectory` is present -- This is an automated message from the Apache Git Service. To

Re: [PR] Use group-varint encode the positions [lucene]

easyice commented on PR #12842: URL: https://github.com/apache/lucene/pull/12842#issuecomment-1858130375 > i'll test it with #12841 optimized code tomorrow. emmm... there's still no significant performance improvement, possibly the write path `writeGroupVInts` is a bit slower than

Re: [PR] Use hppc IntIntHashMap to avoid Integer box/unbox when remapping vector ordinals during merge [lucene]

msokolov commented on PR #12950: URL: https://github.com/apache/lucene/pull/12950#issuecomment-1858129013 actually I think we can use hppc's cursor to avoid containsKey/get having to do some duplicate work here ... I'll post a patch in a second -- This is an automated message from the

Re: [PR] Add Facets#getBulkSpecificValues method [lucene]

epotyom commented on code in PR #12862: URL: https://github.com/apache/lucene/pull/12862#discussion_r1427718945 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java: ## @@ -32,8 +32,8 @@ import org.apache.lucene.document.Field;