s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1941123474
@uschindler @dweiss I moved all version to property files and updated the
python script
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dweiss commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1941331344
I pushed a simple patch replacing properties with txt files - no need to
worry about property file syntax and easier to read too, I think.
I like how python script got simpler too.
stefanvodita commented on code in PR #13041:
URL: https://github.com/apache/lucene/pull/13041#discussion_r1487566325
##
lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/core/nodes/TokenizedPhraseQueryNode.java:
##
@@ -70,10 +70,8 @@ public QueryNode
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1487803547
##
dev-tools/scripts/addBackcompatIndexes.py:
##
@@ -114,53 +113,25 @@ def find_version(x):
x = re.sub(strip_dash_suffix_re, '', x) # remove the -suffix if
sabi0 commented on code in PR #13041:
URL: https://github.com/apache/lucene/pull/13041#discussion_r1487807932
##
lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/core/nodes/TokenizedPhraseQueryNode.java:
##
@@ -70,10 +70,8 @@ public QueryNode cloneTree()
uschindler commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1941478421
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dweiss commented on PR #13098:
URL: https://github.com/apache/lucene/pull/13098#issuecomment-1941517375
I could try to play with spaces, comments, etc. to align those two lines
but in the end it's just a hack - looking for cracks in gjf. What I suggested
as an alternative is guaranteed to
dweiss commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1941375395
I've broken it, I'll fix it in a sec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sabi0 commented on PR #13092:
URL: https://github.com/apache/lucene/pull/13092#issuecomment-1940885691
I see that `BackwardsCompatibilityTestBase` is failing after switching to
the fresh 'main':
```
AssertionError: Version: 9.11.0 missing [in thread "Test worker"]
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1487811954
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -48,25 +52,28 @@
public abstract class
jpountz commented on code in PR #13067:
URL: https://github.com/apache/lucene/pull/13067#discussion_r1487442233
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestIndexSortBackwardsCompatibility.java:
##
@@ -82,14 +84,20 @@ public void
jpountz commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1940963440
(which is what Simon is doing at #13095)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jpountz merged PR #13096:
URL: https://github.com/apache/lucene/pull/13096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stefanvodita commented on PR #13045:
URL: https://github.com/apache/lucene/pull/13045#issuecomment-1941119764
Hi @dianjifzm! Can you give more context for what you're trying to do? I
[passed the PR description through Google
s1monw merged PR #13067:
URL: https://github.com/apache/lucene/pull/13067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1487821423
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -48,25 +52,28 @@
public abstract class
uschindler merged PR #13097:
URL: https://github.com/apache/lucene/pull/13097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
uschindler commented on PR #13097:
URL: https://github.com/apache/lucene/pull/13097#issuecomment-1941501048
I will commit this only to main branch, as the file is only read from there.
Or I am missing something (does it need to be backported for another reason?)
--
This is an automated
uschindler commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1940917313
With our last change, we may need to change the script that adds the
backwards indexes. Or is this now how it worked before?
--
This is an automated message from the Apache Git
jpountz commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1940960455
@uschindler I'm not sure to understand what you mean. The script that adds
bw compat indices indeed needs updating to update the `oldVersions` array when
introducing bw compat indices
dweiss commented on PR #13092:
URL: https://github.com/apache/lucene/pull/13092#issuecomment-1941440581
Wait until this is fixed, merge with main and then we'll take it from there.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1487826242
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -50,7 +52,7 @@
public abstract class
jpountz commented on PR #13096:
URL: https://github.com/apache/lucene/pull/13096#issuecomment-1940726022
I pushed a new commit that revives the old logic that allowed up to one
version missing backward-compatibility data.
--
This is an automated message from the Apache Git Service.
To
sabi0 commented on PR #13092:
URL: https://github.com/apache/lucene/pull/13092#issuecomment-1942196592
I will happily do that. No problem.
(Just need to figure out how to get the 9x branch into my fork..)
--
This is an automated message from the Apache Git Service.
To respond to the
dweiss commented on PR #13092:
URL: https://github.com/apache/lucene/pull/13092#issuecomment-1942211430
Your fork should contain all the branches of the original repository. You
should typically have two remotes - one to your fork (origin), one to lucene's
upstream git. Let's say the
sabi0 commented on PR #13100:
URL: https://github.com/apache/lucene/pull/13100#issuecomment-1942263565
Should I do anything about CHANGES.txt here?
Cherry-pick the commit but inject another PR number?
Should the line still go to the 9.10 section?
--
This is an automated message from
sarthakaggarwal97 opened a new issue, #13099:
URL: https://github.com/apache/lucene/issues/13099
### Description
It was observed, for duplicated / similar type of data, the change in block
size from [60K to 8K](https://github.com/apache/lucene/commit/f1fdd24) results
in over 50%
dweiss merged PR #13092:
URL: https://github.com/apache/lucene/pull/13092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1488370861
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -48,25 +53,31 @@
public abstract class
sabi0 opened a new pull request, #13100:
URL: https://github.com/apache/lucene/pull/13100
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sabi0 commented on PR #13092:
URL: https://github.com/apache/lucene/pull/13092#issuecomment-1942257037
PR#13100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jpountz commented on issue #13099:
URL: https://github.com/apache/lucene/issues/13099#issuecomment-1941895525
The ability to configure Lucene file formats by adding tuning knobs has come
up a few times in the past and the answer has been to create a custom codec, to
keep the scope of what
s1monw commented on PR #13095:
URL: https://github.com/apache/lucene/pull/13095#issuecomment-1941931700
@uschindler I did separate out the specific indices and added a new file.
that makes maintenance simpler and moves the `-cfs` `-nocfs` duplication to the
code. Also applied you comments.
dweiss merged PR #13098:
URL: https://github.com/apache/lucene/pull/13098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1488367811
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -48,25 +53,31 @@
public abstract class
uschindler commented on PR #13098:
URL: https://github.com/apache/lucene/pull/13098#issuecomment-1941783874
Yeah, let's apply this for main branch. branch_9x is Java 11 only and I
think we can keep it as is, it won't survive for too long anymore (I hope).
--
This is an automated message
uschindler commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1488362426
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -48,25 +53,31 @@
public abstract class
dweiss commented on code in PR #13095:
URL: https://github.com/apache/lucene/pull/13095#discussion_r1488345592
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/BackwardsCompatibilityTestBase.java:
##
@@ -48,25 +52,28 @@
public abstract class
dweiss commented on PR #13092:
URL: https://github.com/apache/lucene/pull/13092#issuecomment-1942131273
I've applied this to main but it didn't backport cleanly to branch_9x. Would
you have some time to go through the conflicts and create another PR that
targets branch_9x, please? These
github-actions[bot] commented on PR #12947:
URL: https://github.com/apache/lucene/pull/12947#issuecomment-1942886749
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your
github-actions[bot] commented on PR #13060:
URL: https://github.com/apache/lucene/pull/13060#issuecomment-1942886567
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your
github-actions[bot] commented on PR #13035:
URL: https://github.com/apache/lucene/pull/13035#issuecomment-1942886656
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your
mrkm4ntr commented on PR #13066:
URL: https://github.com/apache/lucene/pull/13066#issuecomment-1943217368
@jpountz Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
43 matches
Mail list logo
