[GitHub] [lucene] rmuir commented on pull request #122: [nocommit] LUCENE-9948: Automatically detect multi- vs. single-valued cases in LongValueFacetCounts

2021-05-03 Thread GitBox 


rmuir commented on pull request #122:
URL: https://github.com/apache/lucene/pull/122#issuecomment-831327039


   Looks good: [
   ![Screen_Shot_2021-05-03_at_11 14 
55](https://user-images.githubusercontent.com/504194/116895104-d943aa80-ac00-11eb-8ffd-0117e8fbf876.png)
   ](url)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] rmuir commented on pull request #122: [nocommit] LUCENE-9948: Automatically detect multi- vs. single-valued cases in LongValueFacetCounts

2021-05-03 Thread GitBox 


rmuir commented on pull request #122:
URL: https://github.com/apache/lucene/pull/122#issuecomment-831319155


   one TODO i want to try for fun, is to look at output from `gradlew -p 
lucene/facet coverage` and see if all the e.g. optimized cases here are really 
tested (https://github.com/apache/lucene/pull/119). Will look into it later!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org