[GitHub] [lucene] uschindler commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator

2021-05-03 Thread GitBox


uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831351741


   the suppressAccessChecks permission got lost in master, so the NRT tests 
were not able to crush the test server with SIGSEGV. It's now working in both 
master and 8.x. I ran the tests and all worked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] uschindler commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator

2021-05-03 Thread GitBox


uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831347167


   I backported the fixes. But I can tell you: It was only a master problm, 8.x 
was fine. I still backported Dawid's fixes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] uschindler commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator

2021-05-03 Thread GitBox


uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831257258


   It will be funny, when Solr picks the new snapshot builds!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] uschindler commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator

2021-05-03 Thread GitBox


uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831256482


   What did you change, or was the test failures on Jenkins only because of the 
first merge on the directory API and this one fixed it?
   
   This explains why you opened THIS pull request. Sorry for the noise.
   
   Uwe


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] uschindler commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator

2021-05-03 Thread GitBox


uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831209602


   Hi @iverase 
   the merge broke tests: We fixed over the weekend the NRT tests. They had a 
bug in the security policy, so no NRT Test is running at all. So you did not 
see the test failure.
   
   If you fix it, make sure to run the replicator tests with 
`-Dtests.nightly=true`, so it runs all tests (takes a few minutes)
   
   I will backport the test fixes also to 8.x later. It's great that we fixed 
it yesterday :-) The NRT tests were not running since now YEARS!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org