atris commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-670692047
Thank you @madrob and @anshumg !
This is an automated message from the Apache Git Service.
To respond to the
atris commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-670616622
@madrob Updated, please see and let me know your thoughts.
This is an automated message from the Apache Git
atris commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-669054609
Thanks @anshumg !
@chatman Sure. I will leave the PR open until Friday morning IST post which,
barring objections, I plan to merge.
atris commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-669024693
@anshumg @madrob Updated. Please see and let me know if this looks ready to
go.
This is an automated message
atris commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-668469871
Thanks @anshumg . Fixed the same.
This is an automated message from the Apache Git Service.
To respond to the
atris commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-668466869
@anshumg Thank you so much for the review. I have updated per your comments
-- please see and let me know your thoughts and comments.
atris commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-668121187
@madrob I spent some time thinking and decided that we should not be
blocking rejected requests but instead returning them immediately with 429 (Too
Many Requests) HTTP code.
atris commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-662073876
@anshumg @madrob @sigram @ErickErickson Please take a look
This is an automated message from the Apache Git
