[GitHub] [lucene-solr] atris commented on pull request #1686: SOLR-13528: Implement Request Rate Limiters
atris commented on pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-670692047 Thank you @madrob and @anshumg ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on pull request #1686: SOLR-13528: Implement Request Rate Limiters
atris commented on pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-670616622 @madrob Updated, please see and let me know your thoughts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on pull request #1686: SOLR-13528: Implement Request Rate Limiters
atris commented on pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-669054609 Thanks @anshumg ! @chatman Sure. I will leave the PR open until Friday morning IST post which, barring objections, I plan to merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on pull request #1686: SOLR-13528: Implement Request Rate Limiters
atris commented on pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-669024693 @anshumg @madrob Updated. Please see and let me know if this looks ready to go. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on pull request #1686: SOLR-13528: Implement Request Rate Limiters
atris commented on pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-668469871 Thanks @anshumg . Fixed the same. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on pull request #1686: SOLR-13528: Implement Request Rate Limiters
atris commented on pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-668466869 @anshumg Thank you so much for the review. I have updated per your comments -- please see and let me know your thoughts and comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on pull request #1686: SOLR-13528: Implement Request Rate Limiters
atris commented on pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-668121187 @madrob I spent some time thinking and decided that we should not be blocking rejected requests but instead returning them immediately with 429 (Too Many Requests) HTTP code. Here is why: 1. User should have the ability to control the behaviour in case of a quota breach. 2. Adding queuing logic to Solr seems as an anti pattern -- are we over stretching the boundaries of our responsibility? 3. This might create a false impression that Solr has slowed down since request time will asymptotically increase before timeouts begin to happen. Rejecting upfront will keep the users with reality. 4. In many scenarios, it is important for the user to know the status of their request usage so as to adjust accordingly. Accordingly, I have updated the PR. Apologies for the delay. Please take a look and let me know your thoughts and comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on pull request #1686: SOLR-13528: Implement Request Rate Limiters
atris commented on pull request #1686: URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-662073876 @anshumg @madrob @sigram @ErickErickson Please take a look This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
