[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-670233414 Thanks @sigram for the comments. They're useful, will update the PR tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-670099928 I have implemented the cluster state abstractions and added some (naive and temporary) wiring to select this assign strategy. A lot of missing parts, this can't be merged anymore at this stage. Work In Progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-669606676 The PR has reached what I consider a satisfying and ready to merge state with the last commit. Please see some description in the [Jira](https://issues.apache.org/jira/browse/SOLR-14613?focusedCommentId=17171841=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17171841). I do hope to merge it by the end of the week, leaving time for discussion until then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-668454886 > So, please feel free to ignore #1714 . You can use #1694 in your framework, if you like it. If not, you go ahead . Thanks @noblepaul! It's still a bit hard for me to navigate who does what and how here (here being open source). I'll carry forward with this PR using for now the cluster abstractions introduced here. When [#1694](https://github.com/apache/lucene-solr/pull/1694) is done we can reconsider (we'll also have a better idea of the needs of this PR). I hope to commit it this week (only interfaces, no implementation) to then start work on the actual implementation (but I'll be mostly away for two weeks at the end of this week). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-668149122 FYI I stop work on this PR until we better define its scope. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-664048647 The work orders are the actions decided by the plugin to satisfy a request or requests sent by a Collection API command implementation. The chain is: Collection API -> command execution builds requests -> plugin code running, returns work orders -> collection API command execution executes the work orders resulting in cluster state changes and node changes (creating/deleting replicas). Maybe create collection doesn’t have to be decided by plugin code since it has to happen in any case when a new collection is created. It could be added by the collection api command itself (but then tricky interaction with the cluster state classes given it’s a partially built collection). Gumi means “elastic” in Hebrew. I’ll change that package name to... what? I’ll remove the cluster state classes (SolrCollection, Shard, Replica) and assume plugins get their view of cluster state elsewhere. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-664046112 There’s no direct mapping between work orders and collection API. I consider work orders the basic building blocs from which collection API actions can be built. Creating a replica (adding the data in ZK, checking for the config set etc) is different from adding a replica to an existing collection. Hence the two work orders. The new collection one doesn’t add any replicas to the collection but prepares the system to accept replicas for the collection (work that is not required when adding a replica to an existing collection). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-663997462 I agree about the naming, will change, will try to make these interfaces seem more like a generic thing for SolrCloud rather than something that’s Autoscaling specific. Regarding “Pleas refer to #1694 as a separate effort to make this simpler.”, I will not at this stage. I can participate in that other PR (already did) but it duplicates seriously the effort I’ve started here. Maybe we carry the two approaches in parallel and then we’ll be able to compare what’s best in one or the other and be able to build a third one that’s even better? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
