sigram commented on issue #1051: SOLR-13992: Refactor code to have collection, shard name in Replica,Slice URL: https://github.com/apache/lucene-solr/pull/1051#issuecomment-561052721 Finally! Big +1. (However, please check your IDE formatting rules - every time you add a method the opening `{` is glued to the preceding `)` - Apache style mandates a single space here. Similarly before the commas in argument lists).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
