[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-12-15 Thread Mikhail Khludnev (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249741#comment-17249741
 ] 

Mikhail Khludnev commented on LUCENE-9021:
--

Thanks, [~pbruski_]. It seems we've done here. 

I'm wondering why javacc can't optimize it itself.

> QueryParser should avoid creating an LookaheadSuccess(Error) object with 
> every instance
> ---
>
> Key: LUCENE-9021
> URL: https://issues.apache.org/jira/browse/LUCENE-9021
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Przemek Bruski
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.8
>
> Attachments: LUCENE-9021.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> This is basically the same as 
> https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-12-14 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249499#comment-17249499
 ] 

ASF subversion and git services commented on LUCENE-9021:
-

Commit 11d5461f99df08fd6f5042dee5c269832febda48 in lucene-solr's branch 
refs/heads/branch_8x from Przemek Bruski
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=11d5461f ]

LUCENE-9021: re-use the LookaheadSuccess exception in Lucene QueryParser

Co-authored-by: Przemek Bruski 

> QueryParser should avoid creating an LookaheadSuccess(Error) object with 
> every instance
> ---
>
> Key: LUCENE-9021
> URL: https://issues.apache.org/jira/browse/LUCENE-9021
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Przemek Bruski
>Priority: Major
> Attachments: LUCENE-9021.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> This is basically the same as 
> https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-12-14 Thread Przemek Bruski (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249099#comment-17249099
 ] 

Przemek Bruski commented on LUCENE-9021:


Done: https://github.com/apache/lucene-solr/pull/2143

> QueryParser should avoid creating an LookaheadSuccess(Error) object with 
> every instance
> ---
>
> Key: LUCENE-9021
> URL: https://issues.apache.org/jira/browse/LUCENE-9021
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Przemek Bruski
>Priority: Major
> Attachments: LUCENE-9021.patch
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> This is basically the same as 
> https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-12-12 Thread Mikhail Khludnev (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248362#comment-17248362
 ] 

Mikhail Khludnev commented on LUCENE-9021:
--

Pushed to master. Thanks, [~pbruski_]. Would you mind to take care for PR 
against {{branch_8x}}?  

> QueryParser should avoid creating an LookaheadSuccess(Error) object with 
> every instance
> ---
>
> Key: LUCENE-9021
> URL: https://issues.apache.org/jira/browse/LUCENE-9021
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Przemek Bruski
>Priority: Major
> Attachments: LUCENE-9021.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This is basically the same as 
> https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-12-12 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248361#comment-17248361
 ] 

ASF subversion and git services commented on LUCENE-9021:
-

Commit 6dfb55d5956bb27a05a3bc184df10705fe835ad8 in lucene-solr's branch 
refs/heads/revert-962-jira/LUCENE-9021 from Mikhail Khludnev
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6dfb55d ]

Revert "LUCENE-9021 QueryParser: re-use the LookaheadSuccess exception (#962)"

This reverts commit ccf3e604537e884e25d33dc9d921cc5e5e1fa284.


> QueryParser should avoid creating an LookaheadSuccess(Error) object with 
> every instance
> ---
>
> Key: LUCENE-9021
> URL: https://issues.apache.org/jira/browse/LUCENE-9021
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Przemek Bruski
>Priority: Major
> Attachments: LUCENE-9021.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This is basically the same as 
> https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-12-12 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248360#comment-17248360
 ] 

ASF subversion and git services commented on LUCENE-9021:
-

Commit ccf3e604537e884e25d33dc9d921cc5e5e1fa284 in lucene-solr's branch 
refs/heads/master from Przemek Bruski
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ccf3e60 ]

LUCENE-9021 QueryParser: re-use the LookaheadSuccess exception (#962)

* LUCENE-9021 QueryParser: re-use the LookaheadSuccess exception
Authored-by: Przemek Bruski 


> QueryParser should avoid creating an LookaheadSuccess(Error) object with 
> every instance
> ---
>
> Key: LUCENE-9021
> URL: https://issues.apache.org/jira/browse/LUCENE-9021
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Przemek Bruski
>Priority: Major
> Attachments: LUCENE-9021.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This is basically the same as 
> https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-12-12 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248359#comment-17248359
 ] 

ASF subversion and git services commented on LUCENE-9021:
-

Commit ccf3e604537e884e25d33dc9d921cc5e5e1fa284 in lucene-solr's branch 
refs/heads/master from Przemek Bruski
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ccf3e60 ]

LUCENE-9021 QueryParser: re-use the LookaheadSuccess exception (#962)

* LUCENE-9021 QueryParser: re-use the LookaheadSuccess exception
Authored-by: Przemek Bruski 


> QueryParser should avoid creating an LookaheadSuccess(Error) object with 
> every instance
> ---
>
> Key: LUCENE-9021
> URL: https://issues.apache.org/jira/browse/LUCENE-9021
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Przemek Bruski
>Priority: Major
> Attachments: LUCENE-9021.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This is basically the same as 
> https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-11-29 Thread Mikhail Khludnev (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240342#comment-17240342
 ] 

Mikhail Khludnev commented on LUCENE-9021:
--

Ready to commit. I see PR have passed precommit check, but it the patch has 
conflict. I kindly appreciate if it's resolved. 

> QueryParser should avoid creating an LookaheadSuccess(Error) object with 
> every instance
> ---
>
> Key: LUCENE-9021
> URL: https://issues.apache.org/jira/browse/LUCENE-9021
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Przemek Bruski
>Priority: Major
> Attachments: LUCENE-9021.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is basically the same as 
> https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-11-18 Thread Clemens Stukenbrock (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234877#comment-17234877
 ] 

Clemens Stukenbrock commented on LUCENE-9021:
-

Hello [~mkhl],  do you have any update on this topic? Kind regards

> QueryParser should avoid creating an LookaheadSuccess(Error) object with 
> every instance
> ---
>
> Key: LUCENE-9021
> URL: https://issues.apache.org/jira/browse/LUCENE-9021
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Przemek Bruski
>Priority: Major
> Attachments: LUCENE-9021.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is basically the same as 
> https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2019-11-02 Thread Mikhail Khludnev (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965405#comment-16965405
 ] 

Mikhail Khludnev commented on LUCENE-9021:
--

I think I can commit it. I would like someone to confirm it makes sense. 

> QueryParser should avoid creating an LookaheadSuccess(Error) object with 
> every instance
> ---
>
> Key: LUCENE-9021
> URL: https://issues.apache.org/jira/browse/LUCENE-9021
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Przemek Bruski
>Priority: Major
> Attachments: LUCENE-9021.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is basically the same as 
> https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2019-11-02 Thread Lucene/Solr QA (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965276#comment-16965276
 ] 

Lucene/Solr QA commented on LUCENE-9021:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
25s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  0m 24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | 
{color:green}  0m 24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  0m 24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
21s{color} | {color:green} queryparser in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}  3m  1s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-9021 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12983713/LUCENE-9021.patch |
| Optional Tests |  compile  javac  unit  ratsources  validatesourcepatterns  
checkforbiddenapis  |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP 
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / 5c6a299 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | LTS |
|  Test Results | 
https://builds.apache.org/job/PreCommit-LUCENE-Build/219/testReport/ |
| modules | C: lucene/queryparser U: lucene/queryparser |
| Console output | 
https://builds.apache.org/job/PreCommit-LUCENE-Build/219/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> QueryParser should avoid creating an LookaheadSuccess(Error) object with 
> every instance
> ---
>
> Key: LUCENE-9021
> URL: https://issues.apache.org/jira/browse/LUCENE-9021
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Przemek Bruski
>Priority: Major
> Attachments: LUCENE-9021.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is basically the same as 
> https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org