[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165714#comment-17165714 ] ASF subversion and git services commented on LUCENE-9312: - Commit 8ebf2d0b2187d849032747d0102ca5eb57b76f05 in lucene-solr's branch refs/heads/jira/SOLR-14608-export from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8ebf2d0 ] LUCENE-9312: Allow builds against arbitrary JVMs (squashed jira/LUCENE-9312) > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: master (9.0) > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165715#comment-17165715 ] ASF subversion and git services commented on LUCENE-9312: - Commit 8ebf2d0b2187d849032747d0102ca5eb57b76f05 in lucene-solr's branch refs/heads/jira/SOLR-14608-export from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8ebf2d0 ] LUCENE-9312: Allow builds against arbitrary JVMs (squashed jira/LUCENE-9312) > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: master (9.0) > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163968#comment-17163968 ] ASF subversion and git services commented on LUCENE-9312: - Commit 8ebf2d0b2187d849032747d0102ca5eb57b76f05 in lucene-solr's branch refs/heads/SOLR-14435 from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8ebf2d0 ] LUCENE-9312: Allow builds against arbitrary JVMs (squashed jira/LUCENE-9312) > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: master (9.0) > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163969#comment-17163969 ] ASF subversion and git services commented on LUCENE-9312: - Commit 8ebf2d0b2187d849032747d0102ca5eb57b76f05 in lucene-solr's branch refs/heads/SOLR-14435 from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8ebf2d0 ] LUCENE-9312: Allow builds against arbitrary JVMs (squashed jira/LUCENE-9312) > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: master (9.0) > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161808#comment-17161808 ] ASF subversion and git services commented on LUCENE-9312: - Commit 8ebf2d0b2187d849032747d0102ca5eb57b76f05 in lucene-solr's branch refs/heads/master from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8ebf2d0 ] LUCENE-9312: Allow builds against arbitrary JVMs (squashed jira/LUCENE-9312) > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161809#comment-17161809 ] ASF subversion and git services commented on LUCENE-9312: - Commit 8ebf2d0b2187d849032747d0102ca5eb57b76f05 in lucene-solr's branch refs/heads/master from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8ebf2d0 ] LUCENE-9312: Allow builds against arbitrary JVMs (squashed jira/LUCENE-9312) > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161687#comment-17161687 ] Tomoko Uchida commented on LUCENE-9312: --- bq. Please take a look at the commit and let me know if it works Anyway, the changes woks fine for me (MacOS and Linux), thank you! > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161684#comment-17161684
]
Tomoko Uchida commented on LUCENE-9312:
---
Off-topic: I had to set those fork options in "defaults-java.gradle" to show
javac error messages in English (my default locale is ja_JP; Java seems to have
lots of Japanese translation resource for better or worse...).
{code:java}
+++ b/gradle/defaults-java.gradle
@@ -25,6 +25,7 @@ allprojects {
// Use 'release' flag instead of 'source' and 'target'
tasks.withType(JavaCompile) {
options.compilerArgs += ["--release", "11"]
+ options.forkOptions.jvmArgs += ["-J-Duser.country=US",
"-J-Duser.language=en_US"]
}
{code}
Same options are already set in "render-javadoc.gradle", I'd like to have them
in default-java.gradle too, though am not sure where is the proper location for
them.
> Allow builds against arbitrary JVMs (even those unsupported by gradle)
> --
>
> Key: LUCENE-9312
> URL: https://issues.apache.org/jira/browse/LUCENE-9312
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161639#comment-17161639
]
Tomoko Uchida commented on LUCENE-9312:
---
I checked out the latest commits and run (whole) {{javadoc}} task. It works for
me with or without {{-Druntime.java.home}} option. ({{solr/core}} project
seems to fail with jdk12+ due to Java compilation error; but this should be
another matter)
{code}
lucene-solr $ ./gradlew -Druntime.java.home=/usr/local/java/adoptopenjdk/jdk12
javadoc
> Task :altJvmWarning
NOTE: Alternative java toolchain will be used for compilation and tests:
Project will use Java 12 from: /usr/local/java/adoptopenjdk/jdk-12.0.2+10
Gradle runs with Java 11 from: /usr/local/java/adoptopenjdk/jdk-11.0.3+7
...
> Task :solr:core:compileJava FAILED
...
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':solr:core:compileJava'.
> Compilation failed with exit code 1; see the compiler error output for
> details.
{code}
> Allow builds against arbitrary JVMs (even those unsupported by gradle)
> --
>
> Key: LUCENE-9312
> URL: https://issues.apache.org/jira/browse/LUCENE-9312
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161491#comment-17161491 ] ASF subversion and git services commented on LUCENE-9312: - Commit a8fdda60f944e12854f669b0e7003a73523b30b8 in lucene-solr's branch refs/heads/jira/LUCENE-9312 from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a8fdda6 ] Merge branch 'master' into jira/LUCENE-9312 > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161485#comment-17161485
]
Dawid Weiss commented on LUCENE-9312:
-
I changed your patch slightly, Tomoko. I used public Gradle APIs (they're
relatively new and still in beta, but still worth to switch from internal) and
I reorganized the logic of how the executable is resolved and passed to mimic
that of gradle's javadoc task. Please take a look at the commit and let me know
if it works (works for me when you override {{-Pruntime.java.home=...}}).
> Allow builds against arbitrary JVMs (even those unsupported by gradle)
> --
>
> Key: LUCENE-9312
> URL: https://issues.apache.org/jira/browse/LUCENE-9312
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161362#comment-17161362 ] ASF subversion and git services commented on LUCENE-9312: - Commit c43188d0282082c77f70f9a219f34a4e45118b4b in lucene-solr's branch refs/heads/jira/LUCENE-9312 from Tomoko Uchida [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=c43188d ] LUCENE-9312: evaluate 'javadocCmdPath' property in task definition > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161236#comment-17161236
]
Tomoko Uchida commented on LUCENE-9312:
---
{quote}We could have a global JVM setting... but I don't think it really
changes that much. If we switch to Java X + 1 then it's fairly simple to look
up those affected bits (javac, javadoc). Sometimes explicit is simpler, even if
it's duplication.
{quote}
I have no strong feeling about that; we should never forget javadoc stuff some
years later :)
> Allow builds against arbitrary JVMs (even those unsupported by gradle)
> --
>
> Key: LUCENE-9312
> URL: https://issues.apache.org/jira/browse/LUCENE-9312
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161223#comment-17161223
]
Tomoko Uchida commented on LUCENE-9312:
---
[~dweiss] I pushed the change for {{renderJavadoc}} and {{renderSiteJavadoc (by
following your comment in the gradle file, thank you).}}
It works for me as below (for debugging, I just added the javadoc command path
to be called to the output file):
{code:java}
lucene-solr$ ./gradlew
-Druntime.java.home=/Users/tomoko.uchida/.sdkman/candidates/java/14.0.1.hs-adpt
-p lucene/analysis/kuromoji javadoc
> Task :altJvmWarning
NOTE: Alternative java toolchain will be used for compilation and tests:
Project will use Java 14 from:
/Users/tomoko.uchida/.sdkman/candidates/java/14.0.1.hs-adpt
Gradle runs with Java 11 from:
/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
...
BUILD SUCCESSFUL in 32s
8 actionable tasks: 8 executed
lucene-solr$ cat
lucene/analysis/kuromoji/build/tmp/renderJavadoc/javadoc-output.txt
Javadoc command path:
/Users/tomoko.uchida/.sdkman/candidates/java/14.0.1.hs-adpt/bin/javadoc
{code}
> Allow builds against arbitrary JVMs (even those unsupported by gradle)
> --
>
> Key: LUCENE-9312
> URL: https://issues.apache.org/jira/browse/LUCENE-9312
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161215#comment-17161215 ] ASF subversion and git services commented on LUCENE-9312: - Commit 964dad20de4fcafa44c50cc282b60b698b767489 in lucene-solr's branch refs/heads/jira/LUCENE-9312 from Tomoko Uchida [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=964dad2 ] LUCENE-9312: set proper javadoc executable path (if Java runtime is specified). > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161153#comment-17161153 ] Dawid Weiss commented on LUCENE-9312: - We could have a global JVM setting... but I don't think it really changes that much. If we switch to Java X + 1 then it's fairly simple to look up those affected bits (javac, javadoc). Sometimes explicit is simpler, even if it's duplication. Please suggest something if you have something in mind though. > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161152#comment-17161152
]
Tomoko Uchida commented on LUCENE-9312:
---
We have two {{--release 11}} option in defaults-java.gradle and
render-javadoc.gradle. Maybe we can parametrize release target, in other words,
"11" ?
> Allow builds against arbitrary JVMs (even those unsupported by gradle)
> --
>
> Key: LUCENE-9312
> URL: https://issues.apache.org/jira/browse/LUCENE-9312
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161149#comment-17161149 ] Dawid Weiss commented on LUCENE-9312: - I have to switch contexts - feel free to fix that javadoc bit (left a todo there, Tomoko) and commit directly to the branch. I'll review later today (or tomorrow) and I think this would wrap up alternative JVM support? > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161148#comment-17161148
]
Tomoko Uchida commented on LUCENE-9312:
---
ah, it was already committed at {{h=92f6138}} - I've checkout it and it works
for me too.
> Allow builds against arbitrary JVMs (even those unsupported by gradle)
> --
>
> Key: LUCENE-9312
> URL: https://issues.apache.org/jira/browse/LUCENE-9312
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161143#comment-17161143
]
Tomoko Uchida commented on LUCENE-9312:
---
FYI this patch works for me. Is it okay to commit to jira/LUCENE-9312 branch?
{code:java}
lucene-solr$ git diff
diff --git a/gradle/defaults-java.gradle b/gradle/defaults-java.gradle
index d9110124389..76a049b68bb 100644
--- a/gradle/defaults-java.gradle
+++ b/gradle/defaults-java.gradle
@@ -25,6 +25,7 @@ allprojects {
tasks.withType(JavaCompile) {
options.encoding = "UTF-8"
options.compilerArgs += [
+"--release", "11",
"-Xlint:-deprecation",
"-Xlint:-serial",
"-Xlint:cast",
{code}
Run {{test}} task:
{code}
lucene-solr$ ./gradlew
-Druntime.java.home=/Users/tomoko.uchida/.sdkman/candidates/java/14.0.1.hs-adpt
-p lucene/analysis/kuromoji test
> Task :altJvmWarning
NOTE: Alternative java toolchain will be used for compilation and tests:
Project will use Java 14 from:
/Users/tomoko.uchida/.sdkman/candidates/java/14.0.1.hs-adpt
Gradle runs with Java 11 from:
/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
..
> Task :lucene:analysis:kuromoji:test
:lucene:analysis:kuromoji:test (SUCCESS): 159 test(s), 7 skipped
The slowest tests (exceeding 500 ms) during this run:
0.51s TestJapaneseTokenizer.testBocchan (:lucene:analysis:kuromoji)
BUILD SUCCESSFUL in 30s
20 actionable tasks: 10 executed, 10 up-to-date
{code}
> Allow builds against arbitrary JVMs (even those unsupported by gradle)
> --
>
> Key: LUCENE-9312
> URL: https://issues.apache.org/jira/browse/LUCENE-9312
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161142#comment-17161142 ] ASF subversion and git services commented on LUCENE-9312: - Commit 92f6138cd271ea262c8bacf7540f62ce7d67aa9b in lucene-solr's branch refs/heads/jira/LUCENE-9312 from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=92f6138 ] Merge branch 'master' into jira/LUCENE-9312 > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161130#comment-17161130 ] Uwe Schindler commented on LUCENE-9312: --- bb. I don't know... I bet it is because it's simpler. I just mentioned it because if somebody is paranoid about the toolchain then we should swap out jar as well... I don't care myself (we can remove that TODO if it's a no issue). That's not different to Ant. All tools out there ZIP on their own - forking a process for that makes no sense. We should not change this! I only think that the manifest should refer to the correct version (not sure if the build-jdk is some automatic setting there, I remeber we always had that in the manifest when we used Ant). > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161112#comment-17161112
]
Dawid Weiss commented on LUCENE-9312:
-
We only pass release - I didn't investigate why jdk 15 issues this warning.
{code}
opts << [ '--release', 11 ]
{code}
bq. Isn't the JAR task not be implemented internall by Gradle as a simple ZIP?
Or do you care about the manifest?
I don't know... I bet it is because it's simpler. I just mentioned it because
if somebody is paranoid about the toolchain then we should swap out jar as
well... I don't care myself (we can remove that TODO if it's a no issue).
> Allow builds against arbitrary JVMs (even those unsupported by gradle)
> --
>
> Key: LUCENE-9312
> URL: https://issues.apache.org/jira/browse/LUCENE-9312
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161113#comment-17161113 ] Dawid Weiss commented on LUCENE-9312: - Oh, sorry - was looking at the wrong thing. We pass 'release' from javadoc but gradle's javac does pass source and target so this would have to be fixed (it's a different issue from alt jdk swap though). > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161105#comment-17161105
]
Uwe Schindler commented on LUCENE-9312:
---
If the issue is not caused by a missing "release" option, use this:
{{\-Xlint:\-options}}
> Allow builds against arbitrary JVMs (even those unsupported by gradle)
> --
>
> Key: LUCENE-9312
> URL: https://issues.apache.org/jira/browse/LUCENE-9312
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161102#comment-17161102 ] Uwe Schindler commented on LUCENE-9312: --- bq. for any jar tasks Isn't the JAR task not be implemented internall by Gradle as a simple ZIP? Or do you care about the manifest? > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161101#comment-17161101
]
Uwe Schindler commented on LUCENE-9312:
---
bq. warning: [options] system modules path not set in conjunction with -source
11
Javac should not pass {{-source}} and {{-target}}. To work correctly it must
pass {{--release 11}}. This is causing the issue here, because the module path
is only "correct" when release flag is used. It is not a problem to pass source
and traget (if that's automatically) but the release falg must be there.
> Allow builds against arbitrary JVMs (even those unsupported by gradle)
> --
>
> Key: LUCENE-9312
> URL: https://issues.apache.org/jira/browse/LUCENE-9312
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161082#comment-17161082 ] Dawid Weiss commented on LUCENE-9312: - There are two todos left - replace the jvm for javadoc (should be trivial) and for any jar tasks (also should be relatively trivial). Feel free to just commit to that branch if you'd like to help out! > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[
https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161081#comment-17161081
]
Dawid Weiss commented on LUCENE-9312:
-
Tomoko, I've pushed branch jira/LUCENE-9312 - this adds public gradle API
support for JVM lookup and makes javac use the alternative JVM, if it's
specified. I've tested with Java 15 and it works (that is: it doesn't because
it emits a compilation warning and breaks the build).
{code}
gradlew -Druntime.java.home=/jdks/jdk-15 -p lucene/analysis/kuromoji test
> Task :altJvmWarning
NOTE: Alternative java toolchain will be used for compilation and tests:
Project will use Java 15 from: c:\_tmp\jdk-15
Gradle runs with Java 14 from: C:\Tools\java\jdk
> Task :randomizationInfo
Running tests with randomization seed: tests.seed=5BB3D802175D6281
> Task :lucene:core:compileJava FAILED
warning: [options] system modules path not set in conjunction with -source 11
error: warnings found and -Werror specified
1 error
1 warning
FAILURE: Build failed with an exception.
{code}
> Allow builds against arbitrary JVMs (even those unsupported by gradle)
> --
>
> Key: LUCENE-9312
> URL: https://issues.apache.org/jira/browse/LUCENE-9312
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160817#comment-17160817 ] Dawid Weiss commented on LUCENE-9312: - Exactly, thanks for looking it up, Tomoko. > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160683#comment-17160683 ] Tomoko Uchida commented on LUCENE-9312: --- I finally found the previous github thread (one of background of this issue) : https://github.com/apache/lucene-solr/pull/1388#discussion_r400021181 > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159944#comment-17159944 ] Tomoko Uchida commented on LUCENE-9312: --- Thanks for elaborating! > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159929#comment-17159929 ] Dawid Weiss commented on LUCENE-9312: - I don't think this matters. Arbitrary meaning "different from gradle's default). If you point it at an EA then it's going to be that. If you point it at some other VM (say, Java 11 with J9 instead of hotspot) then it's going to be that. > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159924#comment-17159924 ] Tomoko Uchida commented on LUCENE-9312: --- LUCENE-9122 says: running tests against "ea-JVMs", but this issue subject says: running build against "arbitrary JVMs"... is the difference between two wordings intentional ? > Allow builds against arbitrary JVMs (even those unsupported by gradle) > -- > > Key: LUCENE-9312 > URL: https://issues.apache.org/jira/browse/LUCENE-9312 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
