[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2021-12-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17457219#comment-17457219 ] Dawid Weiss commented on LUCENE-9623: - Can we close this one as a duplicate, [~tomoko]? > Add

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2021-04-02 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313763#comment-17313763 ] Tomoko Uchida commented on LUCENE-9623: --- bq. What packages are exported and what are kept private

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-12-05 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244635#comment-17244635 ] Tomoko Uchida commented on LUCENE-9623: --- I just wanted to make things a bit clearer. To me, there

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-12-05 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244601#comment-17244601 ] Tomoko Uchida commented on LUCENE-9623: --- {quote}it's actually better if it's a conscious decision

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-12-05 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244530#comment-17244530 ] Dawid Weiss commented on LUCENE-9623: - I don't think packages change that often and in my opinion

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-12-04 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244429#comment-17244429 ] Tomoko Uchida commented on LUCENE-9623: --- {quote}exports are done manual {quote} Ideally, we should

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-12-04 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244424#comment-17244424 ] Tomoko Uchida commented on LUCENE-9623: --- As for tests, I think it might be a good start to run

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-11-30 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240637#comment-17240637 ] Uwe Schindler commented on LUCENE-9623: --- When developing LUCENE-9281 i was not able to test this

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-11-30 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240636#comment-17240636 ] Uwe Schindler commented on LUCENE-9623: --- bq. Yes, I think so. I copy-pasted the auto generated

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-11-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240633#comment-17240633 ] Tomoko Uchida commented on LUCENE-9623: --- bq. We also need some testing of the artifacts! Our

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-11-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240619#comment-17240619 ] Tomoko Uchida commented on LUCENE-9623: --- {quote}bq.I'm really excited to try the module system,

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-11-30 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240610#comment-17240610 ] Uwe Schindler commented on LUCENE-9623: --- Ah I have seen in the examples above that it looks like

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-11-30 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240609#comment-17240609 ] Uwe Schindler commented on LUCENE-9623: --- By the way, this is why this issues was a requirement to

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-11-30 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240604#comment-17240604 ] Uwe Schindler commented on LUCENE-9623: --- We also need some testing of the artifacts! Our standard

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-11-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240543#comment-17240543 ] Dawid Weiss commented on LUCENE-9623: - I'm really not sure how it should work. :) I'm really excited

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-11-29 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240217#comment-17240217 ] Tomoko Uchida commented on LUCENE-9623: --- {quote}I think you could use gradle itself to generate

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-11-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240206#comment-17240206 ] Dawid Weiss commented on LUCENE-9623: - Hi Tomoko. I think you could use gradle itself to generate

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-11-29 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240195#comment-17240195 ] Tomoko Uchida commented on LUCENE-9623: --- Fortunately, jdeps seems to work almost fine for me

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-11-28 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240191#comment-17240191 ] Tomoko Uchida commented on LUCENE-9623: --- I attached [^generate-all-module-info.sh] that generates