[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198514#comment-17198514 ] ASF subversion and git services commented on SOLR-12823: Commit e5f66f7759c7927fc62bdc833595920da1d55329 in lucene-solr's branch refs/heads/reference_impl_dev from Ishan Chattopadhyaya [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e5f66f7 ] SOLR-12823: remove /clusterstate.json via Ishan (#1528) Original commit on master: commit 1ab9b811c65abb3d1a827c87b4f1135116ff90eb Author: murblanc <43050504+murbl...@users.noreply.github.com> Date: Tue Jun 9 20:59:17 2020 +0200 SOLR-12823: remove /clusterstate.json (#1528) # Conflicts: # solr/CHANGES.txt # solr/core/src/java/org/apache/solr/cloud/ZkController.java # solr/core/src/java/org/apache/solr/cloud/api/collections/AddReplicaCmd.java # solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java # solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java # solr/core/src/java/org/apache/solr/cloud/overseer/ClusterStateMutator.java # solr/core/src/java/org/apache/solr/cloud/overseer/ZkStateWriter.java # solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java # solr/core/src/test/org/apache/solr/cloud/CollectionsAPISolrJTest.java # solr/core/src/test/org/apache/solr/cloud/SliceStateTest.java # solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Ilan Ginzburg >Priority: Major > Fix For: master (9.0) > > Time Spent: 5h > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198515#comment-17198515 ] ASF subversion and git services commented on SOLR-12823: Commit e5f66f7759c7927fc62bdc833595920da1d55329 in lucene-solr's branch refs/heads/reference_impl_dev from Ishan Chattopadhyaya [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e5f66f7 ] SOLR-12823: remove /clusterstate.json via Ishan (#1528) Original commit on master: commit 1ab9b811c65abb3d1a827c87b4f1135116ff90eb Author: murblanc <43050504+murbl...@users.noreply.github.com> Date: Tue Jun 9 20:59:17 2020 +0200 SOLR-12823: remove /clusterstate.json (#1528) # Conflicts: # solr/CHANGES.txt # solr/core/src/java/org/apache/solr/cloud/ZkController.java # solr/core/src/java/org/apache/solr/cloud/api/collections/AddReplicaCmd.java # solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java # solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java # solr/core/src/java/org/apache/solr/cloud/overseer/ClusterStateMutator.java # solr/core/src/java/org/apache/solr/cloud/overseer/ZkStateWriter.java # solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java # solr/core/src/test/org/apache/solr/cloud/CollectionsAPISolrJTest.java # solr/core/src/test/org/apache/solr/cloud/SliceStateTest.java # solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Ilan Ginzburg >Priority: Major > Fix For: master (9.0) > > Time Spent: 5h > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143179#comment-17143179
]
Cassandra Targett commented on SOLR-12823:
--
Yes, because unseen in GitHub's rendering of the page is that there is a
comment under it that says: {{// DEVS: please put 9.0 Upgrade Notes in
`major-changes-in-solr-9.adoc`!.}}, so when someone tries to put anything there
they will know not to.
> remove clusterstate.json in Lucene/Solr 9.0
> ---
>
> Key: SOLR-12823
> URL: https://issues.apache.org/jira/browse/SOLR-12823
> Project: Solr
> Issue Type: Task
>Reporter: Varun Thacker
>Assignee: Ilan Ginzburg
>Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove
> that in 9.0
> It stays empty unless you explicitly ask to create the collection with the
> old "stateFormat" and there is no reason for one to create a collection with
> the old stateFormat.
> We should also remove the "stateFormat" argument in create collection
> We should also remove MIGRATESTATEVERSION as well
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143124#comment-17143124 ] Ishan Chattopadhyaya commented on SOLR-12823: - Oh, I see. I was confused due to the empty 9x section here https://github.com/apache/lucene-solr/blob/master/solr/solr-ref-guide/src/solr-upgrade-notes.adoc. [~ctargett], do we need that section? > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Ilan Ginzburg >Priority: Major > Fix For: master (9.0) > > Time Spent: 5h > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143119#comment-17143119
]
Ilan Ginzburg commented on SOLR-12823:
--
[~ichattopadhyaya] actually the original PR already updated
{{major-changes-in-solr-9.adoc}} so I guess we're ok here, nothing more to do.
> remove clusterstate.json in Lucene/Solr 9.0
> ---
>
> Key: SOLR-12823
> URL: https://issues.apache.org/jira/browse/SOLR-12823
> Project: Solr
> Issue Type: Task
>Reporter: Varun Thacker
>Assignee: Ilan Ginzburg
>Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove
> that in 9.0
> It stays empty unless you explicitly ask to create the collection with the
> old "stateFormat" and there is no reason for one to create a collection with
> the old stateFormat.
> We should also remove the "stateFormat" argument in create collection
> We should also remove MIGRATESTATEVERSION as well
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143089#comment-17143089 ] Ilan Ginzburg commented on SOLR-12823: -- [~ichattopadhyaya] I'll put out a PR with this. > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Ilan Ginzburg >Priority: Major > Fix For: master (9.0) > > Time Spent: 5h > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143061#comment-17143061 ] Ishan Chattopadhyaya commented on SOLR-12823: - I think we should add an upgrade note for this change here: https://github.com/apache/lucene-solr/blob/master/solr/solr-ref-guide/src/solr-upgrade-notes.adoc. > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Ilan Ginzburg >Priority: Major > Fix For: master (9.0) > > Time Spent: 5h > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142226#comment-17142226 ] ASF subversion and git services commented on SOLR-12823: Commit 62dd94d26b054f3fe1032ab3096db1148e59ed57 in lucene-solr's branch refs/heads/master from Ilan Ginzburg [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=62dd94d ] SOLR-12823: fix TestZKPropertiesWriter (#1575) SOLR-12823: remove clusterstate.json in Lucene/Solr 9.0 - fix TestZKPropertiesWriter TestZKPropertiesWriter relied on removed legacy features of the SolrCloud cluster to work. Start a MiniSolrCloudCluster (implies config set and other test resources config) and have the test use the core of a created collection. > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Mike Drob >Priority: Major > Fix For: master (9.0) > > Time Spent: 5h > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142227#comment-17142227 ] ASF subversion and git services commented on SOLR-12823: Commit 62dd94d26b054f3fe1032ab3096db1148e59ed57 in lucene-solr's branch refs/heads/master from Ilan Ginzburg [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=62dd94d ] SOLR-12823: fix TestZKPropertiesWriter (#1575) SOLR-12823: remove clusterstate.json in Lucene/Solr 9.0 - fix TestZKPropertiesWriter TestZKPropertiesWriter relied on removed legacy features of the SolrCloud cluster to work. Start a MiniSolrCloudCluster (implies config set and other test resources config) and have the test use the core of a created collection. > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Mike Drob >Priority: Major > Fix For: master (9.0) > > Time Spent: 5h > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134776#comment-17134776 ] Erick Erickson commented on SOLR-12823: --- Well, if you'd ever like to apply that knowledge to some of the intermittently failing tests, you'd be a hero ;) Two resources IDK if you're aware of: Hoss' rollups: [http://fucit.org/solr-jenkins-reports/] Besting script: [https://gist.github.com/markrmiller/dbdb792216dc98b018ad] I have a spare machine laying around so if you're so inclined I'd be happy to beast things. A number of the tests fail a small percentage of the time... > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Mike Drob >Priority: Major > Fix For: master (9.0) > > Time Spent: 4h 50m > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134591#comment-17134591 ] Ilan Ginzburg commented on SOLR-12823: -- I have learned quite a bit on how SolrCloud tests are done by integrating SolrCloud into a new environment that didn't have the test resources infra. Can't say it was fun, but at least it's done :) (it's not very pretty though) [https://github.com/apache/lucene-solr/pull/1575] > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Mike Drob >Priority: Major > Fix For: master (9.0) > > Time Spent: 4h 50m > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133360#comment-17133360 ] ASF subversion and git services commented on SOLR-12823: Commit b4dcbfa3de7c512baab642942320d48fb6f180c4 in lucene-solr's branch refs/heads/master from murblanc [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b4dcbfa ] SOLR-12823: fix failures in CloudHttp2SolrClientTest CloudSolrClientTest TestCloudSolrClientConnections (#1565) Co-authored-by: Ilan Ginzburg > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Mike Drob >Priority: Major > Fix For: master (9.0) > > Time Spent: 4h 40m > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132721#comment-17132721
]
Erick Erickson commented on SOLR-12823:
---
AFAIK all of the tests are run by both build systems.
What you might be hitting is the annotations. {{CloudHttp2SolrClientTest}} for
instance is annotated with @Slow, unless you have (for ant)
{code:java}
-Dtests.slow=true
{code}
it wouldn't run.
This is not a huge deal, if you want to enable that annotation, feel free but
it'll make things, well, slow ;). By and large, nobody is worried by this kind
of glitch as long as it's addressed reasonably, either by disabling the test or
finding the root cause. Preferably the latter of course...
> remove clusterstate.json in Lucene/Solr 9.0
> ---
>
> Key: SOLR-12823
> URL: https://issues.apache.org/jira/browse/SOLR-12823
> Project: Solr
> Issue Type: Task
>Reporter: Varun Thacker
>Assignee: Mike Drob
>Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove
> that in 9.0
> It stays empty unless you explicitly ask to create the collection with the
> old "stateFormat" and there is no reason for one to create a collection with
> the old stateFormat.
> We should also remove the "stateFormat" argument in create collection
> We should also remove MIGRATESTATEVERSION as well
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132716#comment-17132716
]
Ilan Ginzburg commented on SOLR-12823:
--
PR [https://github.com/apache/lucene-solr/pull/1565] fixes tests
{{CloudHttp2SolrClientTest}}, {{CloudSolrClientTest}} and
{{TestCloudSolrClientConnections}}.
Will fix {{TestZKPropertiesWriter}} separately, adding to this PR or creating a
new one if this one is merged (don't hesitate to merge this one).
Which ant/gradle target runs such tests that are not included in {{ant test}}?
> remove clusterstate.json in Lucene/Solr 9.0
> ---
>
> Key: SOLR-12823
> URL: https://issues.apache.org/jira/browse/SOLR-12823
> Project: Solr
> Issue Type: Task
>Reporter: Varun Thacker
>Assignee: Mike Drob
>Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove
> that in 9.0
> It stays empty unless you explicitly ask to create the collection with the
> old "stateFormat" and there is no reason for one to create a collection with
> the old stateFormat.
> We should also remove the "stateFormat" argument in create collection
> We should also remove MIGRATESTATEVERSION as well
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17131078#comment-17131078 ] Ilan Ginzburg commented on SOLR-12823: -- Just deleted my previous comment: environment issue led me to believe some test failures were occurring before my PR got merged. If you got a notification, please ignore it, and if you didn't, good. > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Mike Drob >Priority: Major > Fix For: master (9.0) > > Time Spent: 4h 10m > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130920#comment-17130920
]
Ilan Ginzburg commented on SOLR-12823:
--
Failures of:
{code:java}
CloudHttp2SolrClientTest.testWrongZkChrootTest()
CloudSolrClientTest.testWrongZkChrootTest()
TestCloudSolrClientConnections.testCloudClientCanConnectAfterClusterComesUp()
TestCloudSolrClientConnections.testCloudClientUploads()
{code}
Are all due to the same root cause: {{/aliases.json}} is not found in ZK.
I removed the large {{/clusterstate.json}} commit (reverted master to commit
54c5dd7d6d8b486df9132e637a6d7c5871ac4664 “LUCENE-9148: Move the BKD index to
its own file. (#1475)”) and I see the same failures.
I therefore believe these failures are independent of the
{{/clusterstate.json}} removal, please let me know [~mdrob] if you think
otherwise.
I will concentrate on {{TestZKPropertiesWriter.testZKPropertiesWriter()}}.
Also, which test target should I run to detect these issues ahead of time next
time? {{ant test}} didn’t run them, {{gradlew test}} didn’t either.
> remove clusterstate.json in Lucene/Solr 9.0
> ---
>
> Key: SOLR-12823
> URL: https://issues.apache.org/jira/browse/SOLR-12823
> Project: Solr
> Issue Type: Task
>Reporter: Varun Thacker
>Assignee: Mike Drob
>Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove
> that in 9.0
> It stays empty unless you explicitly ask to create the collection with the
> old "stateFormat" and there is no reason for one to create a collection with
> the old stateFormat.
> We should also remove the "stateFormat" argument in create collection
> We should also remove MIGRATESTATEVERSION as well
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129983#comment-17129983
]
Mike Drob commented on SOLR-12823:
--
There appear to be a couple more reproducing failing tests... Added a few more
AwaitsFix. Looks like I didn't do a great job of verifying things.
{noformat}
gradlew :solr:solrj:test --tests "TestCloudSolrClientConnections"
-Ptests.seed=6D2E28EEF10CB2FC -Ptests.file.encoding=UTF-8
gradlew :solr:solrj:test --tests "CloudHttp2SolrClientTest"
-Ptests.seed=6D2E28EEF10CB2FC -Ptests.file.encoding=UTF-8
gradlew :solr:solrj:test --tests "CloudSolrClientTest"
-Ptests.seed=6D2E28EEF10CB2FC -Ptests.file.encoding=UTF-8
{noformat}
All fails because we don't give a good error message anymore (removed from
ZkStateReader.createClusterStateWatchersAndUpdate).
> remove clusterstate.json in Lucene/Solr 9.0
> ---
>
> Key: SOLR-12823
> URL: https://issues.apache.org/jira/browse/SOLR-12823
> Project: Solr
> Issue Type: Task
>Reporter: Varun Thacker
>Assignee: Mike Drob
>Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove
> that in 9.0
> It stays empty unless you explicitly ask to create the collection with the
> old "stateFormat" and there is no reason for one to create a collection with
> the old stateFormat.
> We should also remove the "stateFormat" argument in create collection
> We should also remove MIGRATESTATEVERSION as well
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129897#comment-17129897 ] Ilan Ginzburg commented on SOLR-12823: -- I'll work on that tomorrow. If I don't manage to repair it tomorrow, will (ask someone to) tag AwaitsFix. Thanks [~mdrob] for the analysis, confirms a fuzzier intuition I had about the issue. > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Mike Drob >Priority: Major > Fix For: master (9.0) > > Time Spent: 4h 10m > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129877#comment-17129877 ] Erick Erickson commented on SOLR-12823: --- If you're not going to be able to get to it, this is one of those cases were AwaitsFix seems right to me. And thanks for the heads-up... > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Assignee: Mike Drob >Priority: Major > Fix For: master (9.0) > > Time Spent: 4h 10m > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129849#comment-17129849
]
Mike Drob commented on SOLR-12823:
--
I spent some time looking at this, the failure is because the old test was
using legacy cloud mode which skipped all the validation in
{{ZkController::checkStateInZk}}. There's also a logic bug that
{{checkStateInZk}} needs to be called _after_ we set a fallback coreNodeName,
otherwise the fallback CNN doesn't matter since we already threw an exception
by that point. I'd guess that the test case needs to be reworked to just use a
proper MiniSolrCloudCluster, but didn't have time to get that far.
> remove clusterstate.json in Lucene/Solr 9.0
> ---
>
> Key: SOLR-12823
> URL: https://issues.apache.org/jira/browse/SOLR-12823
> Project: Solr
> Issue Type: Task
>Reporter: Varun Thacker
>Assignee: Mike Drob
>Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove
> that in 9.0
> It stays empty unless you explicitly ask to create the collection with the
> old "stateFormat" and there is no reason for one to create a collection with
> the old stateFormat.
> We should also remove the "stateFormat" argument in create collection
> We should also remove MIGRATESTATEVERSION as well
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129715#comment-17129715 ] ASF subversion and git services commented on SOLR-12823: Commit 1ab9b811c65abb3d1a827c87b4f1135116ff90eb in lucene-solr's branch refs/heads/master from murblanc [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1ab9b81 ] SOLR-12823: remove /clusterstate.json (#1528) * SOLR-12823: remove /clusterstate.json Remove all code dealing with Zookeeper's /clusterstate.json, remove Collection API's MIGRATESTATEVERSION, remove legacyCloud option. Also fixes SOLR-11877 DocCollection.getStateFormat is buggy Co-authored-by: Ilan Ginzburg > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Priority: Major > Time Spent: 4h > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 9.0
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129716#comment-17129716 ] ASF subversion and git services commented on SOLR-12823: Commit 1ab9b811c65abb3d1a827c87b4f1135116ff90eb in lucene-solr's branch refs/heads/master from murblanc [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1ab9b81 ] SOLR-12823: remove /clusterstate.json (#1528) * SOLR-12823: remove /clusterstate.json Remove all code dealing with Zookeeper's /clusterstate.json, remove Collection API's MIGRATESTATEVERSION, remove legacyCloud option. Also fixes SOLR-11877 DocCollection.getStateFormat is buggy Co-authored-by: Ilan Ginzburg > remove clusterstate.json in Lucene/Solr 9.0 > --- > > Key: SOLR-12823 > URL: https://issues.apache.org/jira/browse/SOLR-12823 > Project: Solr > Issue Type: Task >Reporter: Varun Thacker >Priority: Major > Time Spent: 4h > Remaining Estimate: 0h > > clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove > that in 9.0 > It stays empty unless you explicitly ask to create the collection with the > old "stateFormat" and there is no reason for one to create a collection with > the old stateFormat. > We should also remove the "stateFormat" argument in create collection > We should also remove MIGRATESTATEVERSION as well > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
