[jira] [Commented] (SOLR-14197) Reduce API of SolrResourceLoader
[ https://issues.apache.org/jira/browse/SOLR-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241856#comment-17241856 ] ASF subversion and git services commented on SOLR-14197: Commit ce1b907924a30dd3312e24cbad0b981c5be11799 in lucene-solr's branch refs/heads/branch_8x from Thomas Mortagne [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ce1b907 ] SOLR-15017: Core's lib/ dir was ignored sometimes (#2107) A core's lib/ folder was ignored when the core's configuration did not define any element. This is a regression introduced in 8.6 by SOLR-14197. (cherry picked from commit feb897a962453e6b92dd7bbe51eb2c434cf3143d) > Reduce API of SolrResourceLoader > > > Key: SOLR-14197 > URL: https://issues.apache.org/jira/browse/SOLR-14197 > Project: Solr > Issue Type: Improvement >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Fix For: 8.6 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > SolrResourceLoader must exist as an implementation of Lucene ResourceLoader. > Over time it has grown a lot more methods that are beyond the scope of doing > just that. I think SRL should be simplified to get back to its core > necessity, which hopefully allows us to make other changes (either in SRL or > nearby) with less entanglement. Some API creep: > * listConfigDir _(not used)_ > * newAdminHandlerInstance _(not used)_ > * getDataDir > * getCoreName _(only used for logging)_ > * getCoreProperties > * openSchema and configSchema _(not needed; barely used)_ > EDIT: The following to be done in a follow-up issue: > Some methods ought to go to a new subclass of SolrResourceLoader that is > specifically for a standalone-mode core: > * resourceLocation > * getConfigDir > * getInstancePath > * persistConfLocally -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14197) Reduce API of SolrResourceLoader
[ https://issues.apache.org/jira/browse/SOLR-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241852#comment-17241852 ] ASF subversion and git services commented on SOLR-14197: Commit feb897a962453e6b92dd7bbe51eb2c434cf3143d in lucene-solr's branch refs/heads/master from Thomas Mortagne [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=feb897a ] SOLR-15017: Core's lib/ dir was ignored sometimes (#2107) A core's lib/ folder was ignored when the core's configuration did not define any element. This is a regression introduced in 8.6 by SOLR-14197. > Reduce API of SolrResourceLoader > > > Key: SOLR-14197 > URL: https://issues.apache.org/jira/browse/SOLR-14197 > Project: Solr > Issue Type: Improvement >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Fix For: 8.6 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > SolrResourceLoader must exist as an implementation of Lucene ResourceLoader. > Over time it has grown a lot more methods that are beyond the scope of doing > just that. I think SRL should be simplified to get back to its core > necessity, which hopefully allows us to make other changes (either in SRL or > nearby) with less entanglement. Some API creep: > * listConfigDir _(not used)_ > * newAdminHandlerInstance _(not used)_ > * getDataDir > * getCoreName _(only used for logging)_ > * getCoreProperties > * openSchema and configSchema _(not needed; barely used)_ > EDIT: The following to be done in a follow-up issue: > Some methods ought to go to a new subclass of SolrResourceLoader that is > specifically for a standalone-mode core: > * resourceLocation > * getConfigDir > * getInstancePath > * persistConfLocally -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14197) Reduce API of SolrResourceLoader
[ https://issues.apache.org/jira/browse/SOLR-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057174#comment-17057174 ] ASF subversion and git services commented on SOLR-14197: Commit 17ae79b0905b2bf8635c1b260b30807cae2f5463 in lucene-solr's branch refs/heads/branch_8x from David Smiley [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=17ae79b ] SOLR-14197: SolrResourceLoader refactorings to reduce API * Deprecate SRL.listConfigDir (unused) * Deprecate SRL.getDataDir * Deprecate SRL.getCoreProperties XmlConfigFile needs to be passed in the substitutableProperties IndexSchema needs to be passed in the substitutableProperties Remove redundant Properties from CoreContainer constructors * Remove SRL.newAdminHandlerInstance (unused) * Deprecate SRL.openSchema and openConfig * Avoid SRL.getConfigDir Also harmonized similar initialization logic between DIH Tika processor & ExtractingRequestHandler. * Ensure SRL.addToClassLoader and reloadLuceneSPI are called at most once Don't auto-load "lib" in constructor; wrong place for this logic. * Avoid SRL.getInstancePath Added SolrCore.getInstancePath instead Use CoreContainer.getSolrHome instead NodeConfig should track solrHome separate from SolrResourceLoader * Simplify some SolrCore constructors * Move locateSolrHome to new SolrPaths (Deprecate existing) * Move "User Files" stuff to SolrPaths (Deprecate existing) (cherry picked from commit 732348ec7f9c6b6f7bf9d539a40e50d16198) > Reduce API of SolrResourceLoader > > > Key: SOLR-14197 > URL: https://issues.apache.org/jira/browse/SOLR-14197 > Project: Solr > Issue Type: Improvement >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > SolrResourceLoader must exist as an implementation of Lucene ResourceLoader. > Over time it has grown a lot more methods that are beyond the scope of doing > just that. I think SRL should be simplified to get back to its core > necessity, which hopefully allows us to make other changes (either in SRL or > nearby) with less entanglement. Some API creep: > * listConfigDir _(not used)_ > * newAdminHandlerInstance _(not used)_ > * getDataDir > * getCoreName _(only used for logging)_ > * getCoreProperties > * openSchema and configSchema _(not needed; barely used)_ > Some methods ought to go to a new subclass of SolrResourceLoader that is > specifically for a standalone-mode core: > * resourceLocation > * getConfigDir > * getInstancePath > * persistConfLocally -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14197) Reduce API of SolrResourceLoader
[ https://issues.apache.org/jira/browse/SOLR-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056993#comment-17056993 ] ASF subversion and git services commented on SOLR-14197: Commit 732348ec7f9c6b6f7bf9d539a40e50d16198 in lucene-solr's branch refs/heads/master from David Smiley [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=732348e ] SOLR-14197: SolrResourceLoader refactorings to reduce API * Remove SRL.listConfigDir (unused) * Remove SRL.getDataDir * Remove SRL.getCoreName * Remove SRL.getCoreProperties XmlConfigFile needs to be passed in the substitutableProperties IndexSchema needs to be passed in the substitutableProperties Remove redundant Properties from CoreContainer constructors * Remove SRL.newAdminHandlerInstance (unused) * Remove SRL.openSchema and openConfig * Avoid SRL.getConfigDir Also harmonized similar initialization logic between DIH Tika processor & ExtractingRequestHandler. * Ensure SRL.addToClassLoader and reloadLuceneSPI are called at most once Don't auto-load "lib" in constructor; wrong place for this logic. * Avoid SRL.getInstancePath Added SolrCore.getInstancePath instead Use CoreContainer.getSolrHome instead NodeConfig should track solrHome separate from SolrResourceLoader * Simplify some SolrCore constructors * Move locateSolrHome to new SolrPaths * Move "User Files" stuff to SolrPaths > Reduce API of SolrResourceLoader > > > Key: SOLR-14197 > URL: https://issues.apache.org/jira/browse/SOLR-14197 > Project: Solr > Issue Type: Improvement >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > SolrResourceLoader must exist as an implementation of Lucene ResourceLoader. > Over time it has grown a lot more methods that are beyond the scope of doing > just that. I think SRL should be simplified to get back to its core > necessity, which hopefully allows us to make other changes (either in SRL or > nearby) with less entanglement. Some API creep: > * listConfigDir _(not used)_ > * newAdminHandlerInstance _(not used)_ > * getDataDir > * getCoreName _(only used for logging)_ > * getCoreProperties > * openSchema and configSchema _(not needed; barely used)_ > Some methods ought to go to a new subclass of SolrResourceLoader that is > specifically for a standalone-mode core: > * resourceLocation > * getConfigDir > * getInstancePath > * persistConfLocally -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
