[jira] [Commented] (SOLR-14983) Score returned in search request is original score and not reranked score
[
https://issues.apache.org/jira/browse/SOLR-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230622#comment-17230622
]
ASF subversion and git services commented on SOLR-14983:
Commit ad27dd7c56e4f9e1d1828206e7595b557ed070cb in lucene-solr's branch
refs/heads/branch_8x from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ad27dd7 ]
SOLR-14983: Fix response returning original score instead of reranked score due
to query and filter combining.
(Krishan Goyal, Jason Baik, Christine Poerschke)
> Score returned in search request is original score and not reranked score
> -
>
> Key: SOLR-14983
> URL: https://issues.apache.org/jira/browse/SOLR-14983
> Project: Solr
> Issue Type: Bug
>Affects Versions: 8.0
>Reporter: Krishan Goyal
>Assignee: Christine Poerschke
>Priority: Major
> Attachments: 0001-LUCENE-9542-Unit-test-to-reproduce-bug.patch,
> SOLR-14983.patch, SOLR-14983.patch
>
>
> Score returned in search request is original score and not reranked score
> post the changes in https://issues.apache.org/jira/browse/LUCENE-8412.
> Commit -
> [https://github.com/apache/lucene-solr/commit/55bfadbce115a825a75686fe0bfe71406bc3ee44#diff-4e354f104ed52bd7f620b0c05ae8467d]
> Specifically -
> if (cmd.getSort() != null && query instanceof RankQuery == false &&
> (cmd.getFlags() & GET_SCORES) != 0) {
> TopFieldCollector.populateScores(topDocs.scoreDocs, this, query);
> }
> in SolrIndexSearcher.java recomputes the score but outputs only the original
> score and not the reranked score.
>
> The issue is cmd.getQuery() is a type of RankQuery but the "query" variable
> is a boolean query and probably replacing query with cmd.getQuery() should be
> the right fix for this so that the score is not overriden for rerank queries
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14983) Score returned in search request is original score and not reranked score
[
https://issues.apache.org/jira/browse/SOLR-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230620#comment-17230620
]
ASF subversion and git services commented on SOLR-14983:
Commit 2f02040a4c45e4dfdb1f569ae05637c86f0f001b in lucene-solr's branch
refs/heads/master from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2f02040 ]
SOLR-14983: Fix response returning original score instead of reranked score due
to query and filter combining.
(Krishan Goyal, Jason Baik, Christine Poerschke)
> Score returned in search request is original score and not reranked score
> -
>
> Key: SOLR-14983
> URL: https://issues.apache.org/jira/browse/SOLR-14983
> Project: Solr
> Issue Type: Bug
>Affects Versions: 8.0
>Reporter: Krishan Goyal
>Assignee: Christine Poerschke
>Priority: Major
> Attachments: 0001-LUCENE-9542-Unit-test-to-reproduce-bug.patch,
> SOLR-14983.patch, SOLR-14983.patch
>
>
> Score returned in search request is original score and not reranked score
> post the changes in https://issues.apache.org/jira/browse/LUCENE-8412.
> Commit -
> [https://github.com/apache/lucene-solr/commit/55bfadbce115a825a75686fe0bfe71406bc3ee44#diff-4e354f104ed52bd7f620b0c05ae8467d]
> Specifically -
> if (cmd.getSort() != null && query instanceof RankQuery == false &&
> (cmd.getFlags() & GET_SCORES) != 0) {
> TopFieldCollector.populateScores(topDocs.scoreDocs, this, query);
> }
> in SolrIndexSearcher.java recomputes the score but outputs only the original
> score and not the reranked score.
>
> The issue is cmd.getQuery() is a type of RankQuery but the "query" variable
> is a boolean query and probably replacing query with cmd.getQuery() should be
> the right fix for this so that the score is not overriden for rerank queries
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14983) Score returned in search request is original score and not reranked score
[
https://issues.apache.org/jira/browse/SOLR-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225928#comment-17225928
]
Christine Poerschke commented on SOLR-14983:
Attached unit test tweak:
* the SolrIndexSearcher change is in two places yet the unit test previously
did not reflect that. Either {{getDocListAndSetNC}} or {{getDocListNC}} is
called based on the presence or absence of the {{GET_DOCSET}} flag – e.g.
[https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.7.0/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java#L1406-L1414]
– and so the unit test now covers both flag possibilities.
Looking ahead to patch commit time:
* [~krishan1390], do you have any preference as to {{solr/CHANGES.txt}}
attribution choice of name for yourself e.g. "Krishan" (current JIRA full name)
or "krishan1390" (JIRA Username) or a variant of the two or something else
perhaps? It's entirely your choice, different people use different styles e.g.
[https://lucene.apache.org/solr/8_6_3/changes/Changes.html] for the 8.6.3
release.
* [~Baik], I'm going to assume you wish to use "Jason Baik" (current JIRA full
name) for your {{solr/CHANGES.txt}} attribution choice of name but if you
prefer a different style, please let me know.
* "precommit" checks now pass (two unused imports needed removing) and I'm yet
to fully run all the solr test suites but assuming they pass and if there's no
further comments or concerns etc. here then I'll aim to commit the change
middle of next week hopefully.
> Score returned in search request is original score and not reranked score
> -
>
> Key: SOLR-14983
> URL: https://issues.apache.org/jira/browse/SOLR-14983
> Project: Solr
> Issue Type: Bug
>Affects Versions: 8.0
>Reporter: Krishan
>Priority: Major
> Attachments: 0001-LUCENE-9542-Unit-test-to-reproduce-bug.patch,
> SOLR-14983.patch, SOLR-14983.patch
>
>
> Score returned in search request is original score and not reranked score
> post the changes in https://issues.apache.org/jira/browse/LUCENE-8412.
> Commit -
> [https://github.com/apache/lucene-solr/commit/55bfadbce115a825a75686fe0bfe71406bc3ee44#diff-4e354f104ed52bd7f620b0c05ae8467d]
> Specifically -
> if (cmd.getSort() != null && query instanceof RankQuery == false &&
> (cmd.getFlags() & GET_SCORES) != 0) {
> TopFieldCollector.populateScores(topDocs.scoreDocs, this, query);
> }
> in SolrIndexSearcher.java recomputes the score but outputs only the original
> score and not the reranked score.
>
> The issue is cmd.getQuery() is a type of RankQuery but the "query" variable
> is a boolean query and probably replacing query with cmd.getQuery() should be
> the right fix for this so that the score is not overriden for rerank queries
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14983) Score returned in search request is original score and not reranked score
[
https://issues.apache.org/jira/browse/SOLR-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225923#comment-17225923
]
Krishan commented on SOLR-14983:
Yea looks good. Thanks [~cpoerschke] and [~Baik] for the fix and test cases.
> Score returned in search request is original score and not reranked score
> -
>
> Key: SOLR-14983
> URL: https://issues.apache.org/jira/browse/SOLR-14983
> Project: Solr
> Issue Type: Bug
>Affects Versions: 8.0
>Reporter: Krishan
>Priority: Major
> Attachments: 0001-LUCENE-9542-Unit-test-to-reproduce-bug.patch,
> SOLR-14983.patch
>
>
> Score returned in search request is original score and not reranked score
> post the changes in https://issues.apache.org/jira/browse/LUCENE-8412.
> Commit -
> [https://github.com/apache/lucene-solr/commit/55bfadbce115a825a75686fe0bfe71406bc3ee44#diff-4e354f104ed52bd7f620b0c05ae8467d]
> Specifically -
> if (cmd.getSort() != null && query instanceof RankQuery == false &&
> (cmd.getFlags() & GET_SCORES) != 0) {
> TopFieldCollector.populateScores(topDocs.scoreDocs, this, query);
> }
> in SolrIndexSearcher.java recomputes the score but outputs only the original
> score and not the reranked score.
>
> The issue is cmd.getQuery() is a type of RankQuery but the "query" variable
> is a boolean query and probably replacing query with cmd.getQuery() should be
> the right fix for this so that the score is not overriden for rerank queries
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14983) Score returned in search request is original score and not reranked score
[
https://issues.apache.org/jira/browse/SOLR-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225605#comment-17225605
]
Jason Baik commented on SOLR-14983:
---
Looks good on our side.
> Score returned in search request is original score and not reranked score
> -
>
> Key: SOLR-14983
> URL: https://issues.apache.org/jira/browse/SOLR-14983
> Project: Solr
> Issue Type: Bug
>Affects Versions: 8.0
>Reporter: Krishan
>Priority: Major
> Attachments: 0001-LUCENE-9542-Unit-test-to-reproduce-bug.patch,
> SOLR-14983.patch
>
>
> Score returned in search request is original score and not reranked score
> post the changes in https://issues.apache.org/jira/browse/LUCENE-8412.
> Commit -
> [https://github.com/apache/lucene-solr/commit/55bfadbce115a825a75686fe0bfe71406bc3ee44#diff-4e354f104ed52bd7f620b0c05ae8467d]
> Specifically -
> if (cmd.getSort() != null && query instanceof RankQuery == false &&
> (cmd.getFlags() & GET_SCORES) != 0) {
> TopFieldCollector.populateScores(topDocs.scoreDocs, this, query);
> }
> in SolrIndexSearcher.java recomputes the score but outputs only the original
> score and not the reranked score.
>
> The issue is cmd.getQuery() is a type of RankQuery but the "query" variable
> is a boolean query and probably replacing query with cmd.getQuery() should be
> the right fix for this so that the score is not overriden for rerank queries
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14983) Score returned in search request is original score and not reranked score
[
https://issues.apache.org/jira/browse/SOLR-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225544#comment-17225544
]
Christine Poerschke commented on SOLR-14983:
Attached SOLR-14983.patch file
* has the proposed {{cmd.getQuery()}} instead of {{query}} fix
* adds a {{testReranking}} case into the existing {{SolrIndexSearcherTest}}
suite using [~Baik]'s 0001-LUCENE-9542-Unit-test-to-reproduce-bug.patch
approach of a private {{RankQuery}} class that produces known value scores.
What do you think?
> Score returned in search request is original score and not reranked score
> -
>
> Key: SOLR-14983
> URL: https://issues.apache.org/jira/browse/SOLR-14983
> Project: Solr
> Issue Type: Bug
>Affects Versions: 8.0
>Reporter: Krishan
>Priority: Major
> Attachments: 0001-LUCENE-9542-Unit-test-to-reproduce-bug.patch,
> SOLR-14983.patch
>
>
> Score returned in search request is original score and not reranked score
> post the changes in https://issues.apache.org/jira/browse/LUCENE-8412.
> Commit -
> [https://github.com/apache/lucene-solr/commit/55bfadbce115a825a75686fe0bfe71406bc3ee44#diff-4e354f104ed52bd7f620b0c05ae8467d]
> Specifically -
> if (cmd.getSort() != null && query instanceof RankQuery == false &&
> (cmd.getFlags() & GET_SCORES) != 0) {
> TopFieldCollector.populateScores(topDocs.scoreDocs, this, query);
> }
> in SolrIndexSearcher.java recomputes the score but outputs only the original
> score and not the reranked score.
>
> The issue is cmd.getQuery() is a type of RankQuery but the "query" variable
> is a boolean query and probably replacing query with cmd.getQuery() should be
> the right fix for this so that the score is not overriden for rerank queries
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
