stefanvodita commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966411059
I have. The diff looks correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966395258
The other PR looks straight-forward to me. Have you compared the two files
directly after merging? They should be mostly identical and only the
BASE_VERSION line should be different.
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966393719
> Here it is: #13139. I wasn't sure about the difficulties @dweiss was
encountering - I expect this to just work.
I think Dawid's problems were preexisting, not related to this
stefanvodita commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966359649
Here it is: #13139.
I wasn't sure about the difficulties @dweiss was encountering - I expect
this to just work.
--
This is an automated message from the Apache Git Service.
To
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966353181
Will you forward port the patch to main branch? I can help with that, have
some freetime.
This will allow us to make everything Java 21 ready tomorrow, so we have one
file
stefanvodita merged PR #13108:
URL: https://github.com/apache/lucene/pull/13108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966098725
> I don't think it's going to be so easy - some things just didn't work for
me with local artifacts. I'll follow up, perhaps tomorrow.
That was always a problem, I know.
dweiss commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1965938522
I think we can merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dweiss commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1965313190
I don't think it's going to be so easy - some things just didn't work for me
with local artifacts. I'll follow up, perhaps tomorrow.
--
This is an automated message from the Apache Git
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1965306394
I checked the script. Forward port should be more or less:
- copy file to main branch
- change BASE_VERSION constant in the script
The new script is no longer a search
dweiss commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1965293218
Just FYI - I've returned to trying to add a nightly smoketester workflow
check. The main branch required some changes to the script as well, which sort
of proves Rob's point that we need
stefanvodita commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1964103920
> If you run with Lucene 9.10.0 (just released last week), it should work.
I think so, but the 9.10.0 RC artefacts were no longer available at
stefanvodita commented on code in PR #13108:
URL: https://github.com/apache/lucene/pull/13108#discussion_r1502581745
##
dev-tools/scripts/smokeTestRelease.py:
##
@@ -911,33 +917,45 @@ def crawl(downloadedFiles, urlString, targetDir,
exclusions=set()):
stefanvodita commented on code in PR #13108:
URL: https://github.com/apache/lucene/pull/13108#discussion_r1502581266
##
dev-tools/scripts/smokeTestRelease.py:
##
@@ -633,9 +636,12 @@ def verifyUnpacked(java, artifact, unpackPath,
gitRevision, version, testArgs):
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1963087051
> There was an error about 8.11.3 back compatibility not being tested, but I
think that has to do with it being released after 9.9.0, and not with the
changes to the script.
uschindler commented on code in PR #13108:
URL: https://github.com/apache/lucene/pull/13108#discussion_r1501911529
##
dev-tools/scripts/smokeTestRelease.py:
##
@@ -633,9 +636,12 @@ def verifyUnpacked(java, artifact, unpackPath,
gitRevision, version, testArgs):
stefanvodita commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1963074533
@uschindler - I addressed your first three points. On the last two points I
think I'm missing some of the context to understand the issues. I'll try to dig
a bit to understand
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1961117087
Basically, to make the whole script better maintainable:
- remove the hardcoded Java 17, Java 11 variable names.
- have a central setting with the "baseline" java version.
-
stefanvodita commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1961068426
Right, there are only a couple things left to do. I'll wrap this one up
during the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the
ChrisHegarty commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1961043488
> > That's great! If we extract the JDK version number as well, maybe we can
commit this.
>
> Extracting the JDK version number is already implemented, because there's
a
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1947486317
> That's great! If we extract the JDK version number as well, maybe we can
commit this.
Extracting the JDK version number is already implemented, because there's a
check for
stefanvodita commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1947475358
That's great! If we extract the JDK version number as well, maybe we can
commit this.
@uschindler - would you want the parameter for a specific JDK version
removed on both
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1947365781
Smoke tester succeeded (see mailing list).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1946765849
Runs: https://jenkins.thetaphi.de/job/Lucene-Release-Tester-v2/2/console
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1946763411
Thanks, will retrigger the job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1946757305
waaah it doesnt like the version :-(
Can you comment out the version check in your branch?
--
This is an automated message from the Apache Git Service.
To respond to the
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1946751077
It's already in testing:
https://jenkins.thetaphi.de/job/Lucene-Release-Tester-v2/1/console
--
This is an automated message from the Apache Git Service.
To respond to the message,
stefanvodita commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1946714708
We can, that would be cleaner. But this should work for testing 9.10, right?
Marking as draft, since I don’t think we would merge as-is.
--
This is an automated message from
uschindler commented on PR #13108:
URL: https://github.com/apache/lucene/pull/13108#issuecomment-1946691964
Can we remove the java 17 one? Or at least map the java 17 command line
parameter as additional alternative.
--
This is an automated message from the Apache Git Service.
To respond
29 matches
Mail list logo
