Re: [PR] Allow multiple JDKs in smoke test [lucene]
stefanvodita commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966411059 I have. The diff looks correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966395258 The other PR looks straight-forward to me. Have you compared the two files directly after merging? They should be mostly identical and only the BASE_VERSION line should be different. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966393719 > Here it is: #13139. I wasn't sure about the difficulties @dweiss was encountering - I expect this to just work. I think Dawid's problems were preexisting, not related to this PR and porting it forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
stefanvodita commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966359649 Here it is: #13139. I wasn't sure about the difficulties @dweiss was encountering - I expect this to just work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966353181 Will you forward port the patch to main branch? I can help with that, have some freetime. This will allow us to make everything Java 21 ready tomorrow, so we have one file less to search/replace version numbers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
stefanvodita merged PR #13108: URL: https://github.com/apache/lucene/pull/13108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1966098725 > I don't think it's going to be so easy - some things just didn't work for me with local artifacts. I'll follow up, perhaps tomorrow. That was always a problem, I know. Therefore we had in the old ant build some target that created a "release folder" in the exact way how it is deployed on web server. After that it worked with file URLs. There is the Jenkins task still available: https://ci-builds.apache.org/job/Lucene/job/Lucene-Solr-SmokeRelease-8.11/, the 9.x and main ones were disabled and later removed after the gradle switch. I'd like to add the Jenkins task back, Github is IMHO too expensive unless we run no tests. +1 to merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
dweiss commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1965938522 I think we can merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
dweiss commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1965313190 I don't think it's going to be so easy - some things just didn't work for me with local artifacts. I'll follow up, perhaps tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1965306394 I checked the script. Forward port should be more or less: - copy file to main branch - change BASE_VERSION constant in the script The new script is no longer a search replace Desaster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
dweiss commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1965293218 Just FYI - I've returned to trying to add a nightly smoketester workflow check. The main branch required some changes to the script as well, which sort of proves Rob's point that we need to run it regularly, otherwise it goes out of sync with the code quickly... I'll try to forward-port @stefanvodita 's changes to main and will create a pr when I think it presents a reasonable state (still working my way through some python checks). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
stefanvodita commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1964103920 > If you run with Lucene 9.10.0 (just released last week), it should work. I think so, but the 9.10.0 RC artefacts were no longer available at https://dist.apache.org/repos/dist/dev/lucene/. Not sure why some versions are still there and some aren't. It was easier just to use the 9.9.0 RC that is still there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
stefanvodita commented on code in PR #13108:
URL: https://github.com/apache/lucene/pull/13108#discussion_r1502581745
##
dev-tools/scripts/smokeTestRelease.py:
##
@@ -911,33 +917,45 @@ def crawl(downloadedFiles, urlString, targetDir,
exclusions=set()):
sys.stdout.write('.')
-def make_java_config(parser, java17_home):
- def _make_runner(java_home, version):
-print('Java %s JAVA_HOME=%s' % (version, java_home))
+def make_java_config(parser, alt_java_homes):
+ def _make_runner(java_home, is_base_version=False):
if cygwin:
java_home = subprocess.check_output('cygpath -u "%s"' % java_home,
shell=True).decode('utf-8').strip()
cmd_prefix = 'export JAVA_HOME="%s" PATH="%s/bin:$PATH"
JAVACMD="%s/bin/java"' % \
(java_home, java_home, java_home)
s = subprocess.check_output('%s; java -version' % cmd_prefix,
shell=True,
stderr=subprocess.STDOUT).decode('utf-8')
-if s.find(' version "%s' % version) == -1:
- parser.error('got wrong version for java %s:\n%s' % (version, s))
+
+actual_version = re.search(r'version "([1-9][0-9]*)', s).group(1)
+print('Java %s JAVA_HOME=%s' % (actual_version, java_home))
+
+if (is_base_version and BASE_JAVA_VERSION != actual_version) \
+or int(BASE_JAVA_VERSION) > int(actual_version):
Review Comment:
Sure, I'll do separate messages for the two cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
stefanvodita commented on code in PR #13108:
URL: https://github.com/apache/lucene/pull/13108#discussion_r1502581266
##
dev-tools/scripts/smokeTestRelease.py:
##
@@ -633,9 +636,12 @@ def verifyUnpacked(java, artifact, unpackPath,
gitRevision, version, testArgs):
checkAllJARs(os.getcwd(), gitRevision, version)
-testDemo(java.run_java11, isSrc, version, '11')
-if java.run_java17:
- testDemo(java.run_java17, isSrc, version, '17')
+testDemo(java.run_java, isSrc, version, BASE_JAVA_VERSION)
+if java.run_alt_javas:
+ for run_alt_java, alt_java_version in zip(java.run_alt_javas,
java.alt_java_versions):
+print("DELETEME")
Review Comment:
Thanks for noticing, I forgot about this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1963087051 > There was an error about 8.11.3 back compatibility not being tested, but I think that has to do with it being released after 9.9.0, and not with the changes to the script. If you run with Lucene 9.10.0 (just released last week), it should work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on code in PR #13108:
URL: https://github.com/apache/lucene/pull/13108#discussion_r1501911529
##
dev-tools/scripts/smokeTestRelease.py:
##
@@ -633,9 +636,12 @@ def verifyUnpacked(java, artifact, unpackPath,
gitRevision, version, testArgs):
checkAllJARs(os.getcwd(), gitRevision, version)
-testDemo(java.run_java11, isSrc, version, '11')
-if java.run_java17:
- testDemo(java.run_java17, isSrc, version, '17')
+testDemo(java.run_java, isSrc, version, BASE_JAVA_VERSION)
+if java.run_alt_javas:
+ for run_alt_java, alt_java_version in zip(java.run_alt_javas,
java.alt_java_versions):
+print("DELETEME")
Review Comment:
Yes, DELETE ME ! :-)
##
dev-tools/scripts/smokeTestRelease.py:
##
@@ -911,33 +917,45 @@ def crawl(downloadedFiles, urlString, targetDir,
exclusions=set()):
sys.stdout.write('.')
-def make_java_config(parser, java17_home):
- def _make_runner(java_home, version):
-print('Java %s JAVA_HOME=%s' % (version, java_home))
+def make_java_config(parser, alt_java_homes):
+ def _make_runner(java_home, is_base_version=False):
if cygwin:
java_home = subprocess.check_output('cygpath -u "%s"' % java_home,
shell=True).decode('utf-8').strip()
cmd_prefix = 'export JAVA_HOME="%s" PATH="%s/bin:$PATH"
JAVACMD="%s/bin/java"' % \
(java_home, java_home, java_home)
s = subprocess.check_output('%s; java -version' % cmd_prefix,
shell=True,
stderr=subprocess.STDOUT).decode('utf-8')
-if s.find(' version "%s' % version) == -1:
- parser.error('got wrong version for java %s:\n%s' % (version, s))
+
+actual_version = re.search(r'version "([1-9][0-9]*)', s).group(1)
+print('Java %s JAVA_HOME=%s' % (actual_version, java_home))
+
+if (is_base_version and BASE_JAVA_VERSION != actual_version) \
+or int(BASE_JAVA_VERSION) > int(actual_version):
Review Comment:
I think the messages are a bit misleading depending on context. Maybe
differentiate between `is_base_version` and the alternate version mode:
- if `is_base_version == true` then compare with exact same version and
complain about that
- if `is_base_version == false` print a message about `actual_version`need
to be `>= BASE_JAVA_VERSION`
The `>=` is important, because I want to test OpenJ9 vs Hotspot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
stefanvodita commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1963074533 @uschindler - I addressed your first three points. On the last two points I think I'm missing some of the context to understand the issues. I'll try to dig a bit to understand those better. Is this a "progress not perfection" situation, where we can treat the last 2 points in a separate PR or are they tightly bound with the rest of this work? As far as testing, it's a bit annoying to do, but I think I've got the script working correctly. I used the latest [available RC](https://dist.apache.org/repos/dist/dev/lucene/) (9.9.0): ``` JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto python3 -u dev-tools/scripts/smokeTestRelease.py --test-alternative-java /usr/lib/jvm/java-20-amazon-corretto --test-alternative-java /usr/lib/jvm/java-21-amazon-corretto \ https://dist.apache.org/repos/dist/dev/lucene/lucene-9.9.0-RC1-rev-92a5e5b02e0e083126c4122f2b7a02426c21a037 ``` There was an error about 8.11.3 back compatibility not being tested, but I think that has to do with it being released after 9.9.0, and not with the changes to the script. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1961117087 Basically, to make the whole script better maintainable: - remove the hardcoded Java 17, Java 11 variable names. - have a central setting with the "baseline" java version. - When running the code it would just check that JAVA_HOME is exactly the baseline version and all other additionally added JVM versions should - Finally, the gradle tasks should not be executed with a changes JAVA_HOME. Instead the RUNTIME_JAVA_HOME env var should be poulated and Gradle be running with the base version. This removes the problem of not being able to execute Gradle with Java 22 - Special case: Everything executed using without Gradle (like the Lucene Demo) should of course be executed the JAVA_HOME env var, so they are directly executed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
stefanvodita commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1961068426 Right, there are only a couple things left to do. I'll wrap this one up during the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
ChrisHegarty commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1961043488 > > That's great! If we extract the JDK version number as well, maybe we can commit this. > > Extracting the JDK version number is already implemented, because there's a check for Java 11 and Java 17 already. > > > @uschindler - would you want the parameter for a specific JDK version removed on both `main` and `branch_9x` i.e. remove `--test-java19` from `main` and remove `--test-java17` from `branch_9x`? +1 > I would remove all of them. Only the base version should be checked (so in 9.x base version must be 11). The other versions passed as cmd line parameter should maybe just checked to be >= base version. +1 What's the latest status of this PR? It looks like it is in reasonable shape and just needs to address some comments, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1947486317 > That's great! If we extract the JDK version number as well, maybe we can commit this. Extracting the JDK version number is already implemented, because there's a check for Java 11 and Java 17 already. > @uschindler - would you want the parameter for a specific JDK version removed on both `main` and `branch_9x` i.e. remove `--test-java19` from `main` and remove `--test-java17` from `branch_9x`? I would remove all of them. Only the base version should be checked (so in 9.x base version must be 11). The other versions passed as cmd line parameter should maybe just checked to be >= base version. If you want backwards compatibility, you can keep the old cmd line parameters and just add the arguments from the specific parameters to the list of alternative versions. But as this is a developer tools only, I don't think we need any backwards compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
stefanvodita commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1947475358 That's great! If we extract the JDK version number as well, maybe we can commit this. @uschindler - would you want the parameter for a specific JDK version removed on both `main` and `branch_9x` i.e. remove `--test-java19` from `main` and remove `--test-java17` from `branch_9x`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1947365781 Smoke tester succeeded (see mailing list). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1946765849 Runs: https://jenkins.thetaphi.de/job/Lucene-Release-Tester-v2/2/console -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1946763411 Thanks, will retrigger the job! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1946757305 waaah it doesnt like the version :-( Can you comment out the version check in your branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1946751077 It's already in testing: https://jenkins.thetaphi.de/job/Lucene-Release-Tester-v2/1/console -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
stefanvodita commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1946714708 We can, that would be cleaner. But this should work for testing 9.10, right? Marking as draft, since I don’t think we would merge as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Allow multiple JDKs in smoke test [lucene]
uschindler commented on PR #13108: URL: https://github.com/apache/lucene/pull/13108#issuecomment-1946691964 Can we remove the java 17 one? Or at least map the java 17 command line parameter as additional alternative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
