uschindler merged PR #13104:
URL: https://github.com/apache/lucene/pull/13104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
uschindler commented on PR #13104:
URL: https://github.com/apache/lucene/pull/13104#issuecomment-1946149224
Let's open another issue about this. I think we did the final only fields
for query instances, but token streams are not behaving bad as they are not
cached and have state.
easyice commented on PR #13104:
URL: https://github.com/apache/lucene/pull/13104#issuecomment-1946004282
Thank you for the great suggestions!
@uschindler You are right, all the setters are used after the construction
only, It makes sense if they are only set on construction. The only
uschindler commented on PR #13104:
URL: https://github.com/apache/lucene/pull/13104#issuecomment-1944583551
I wonder why the token stream has a setter at all. The field should be
final.
I thought we want to have those settings all final and only set on
construction.
--
This is
rmuir commented on PR #13104:
URL: https://github.com/apache/lucene/pull/13104#issuecomment-1944453765
good catch! should we move this check to `setTokenType()`? Since it is a
`public` method, it seems like a better place to add the check?
--
This is an automated message from the Apache
