easyice commented on PR #12954:
URL: https://github.com/apache/lucene/pull/12954#issuecomment-1890884774
Close this in favor of https://github.com/apache/lucene/pull/12997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
easyice closed pull request #12954: Reduce frequencies buffer size when they
are not needed
URL: https://github.com/apache/lucene/pull/12954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on PR #12954:
URL: https://github.com/apache/lucene/pull/12954#issuecomment-1880898477
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your
easyice commented on PR #12954:
URL: https://github.com/apache/lucene/pull/12954#issuecomment-1866446008
Here is the benchmark for new approach (avoid for-loop in `reset()`), the
`PKLookup` task still has a speedup, but the speedup for `Wildcard` task is
disappeared, i checked the memory
jpountz commented on PR #12954:
URL: https://github.com/apache/lucene/pull/12954#issuecomment-1864765767
> so maybe we can consider an other approach: try to avoid the for-loop in
reset() if the instance can be reused
+1 this sounds like a good idea!
--
This is an automated
easyice commented on PR #12954:
URL: https://github.com/apache/lucene/pull/12954#issuecomment-1864749851
I took several hours to confirm the results, the benchmark shows it became
faster, this exceeded my expectation, we think the speedup is due to remove the
loop that initializes the
easyice commented on PR #12954:
URL: https://github.com/apache/lucene/pull/12954#issuecomment-1862859903
ohhh.. You said makes sense, i will check it. Thank you Adrien!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jpountz commented on PR #12954:
URL: https://github.com/apache/lucene/pull/12954#issuecomment-1862482539
I wonder if there is a performance impact, since this is moving a condition
from something that runs once per block of 128 docs to something that map run
on every doc.
--
This is an
