vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1595034249
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -67,12 +68,16 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1595034249
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -67,12 +68,16 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
github-actions[bot] commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-2083913815
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1565442746
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
}
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1565442746
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
}
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1565442746
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
}
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1515861738
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
}
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1544202746
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
}
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1565285501
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
}
github-actions[bot] commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-2052720580
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1544202746
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
}
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1515861738
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
}
vsop-479 commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1983159835
> Have you tried to measure any performance change with this? E.g. you could
run a luceneutil benchy with just PrefixQuery, or, Regexp/WildcardQuery that
also have this property
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1515861738
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
}
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1515793831
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -67,12 +68,16 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1515793831
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -67,12 +68,16 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
mikemccand commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1514268562
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/IntersectTermsEnum.java:
##
@@ -534,6 +555,9 @@ private BytesRef _next() throws IOException {
vsop-479 commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1980188859
> I think the optimization may be similar to the one done in
AutomatonTermsEnum?
It seems the optimization of `AutomatonTermsEnum` is to improve iterating
term mode, from
vsop-479 commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1974836248
@mikemccand
I renamed the field used to indicate wether an accept state can match all
suffixes, and detected it in `RunAutomaton`.
Please take a look when you get a chance.
--
vsop-479 commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1972857051
There is still problem in the implementation of detecting whether accept
state can match all suffix (`RunAutomaton.canMatchAllSuffix`), I am trying to
figure it out.
On the
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1505632559
##
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##
@@ -92,6 +93,7 @@ public Automaton() {
public Automaton(int numStates, int
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1505632559
##
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##
@@ -92,6 +93,7 @@ public Automaton() {
public Automaton(int numStates, int
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1505621389
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -67,12 +68,16 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1505583695
##
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##
@@ -70,6 +70,7 @@ public class Automaton implements Accountable,
TransitionAccessor {
vsop-479 commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1968284534
> I think the optimization may be similar to the one done in
AutomatonTermsEnum?
Thanks for reminding that, I will dig into `AutomatonTermsEnum`'s
optimization.
--
This is an
rmuir commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1968087576
I think the optimization may be similar to the one done in
AutomatonTermsEnum?
vsop-479 commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1968078407
@mikemccand Thanks for you suggestion, I am trying to implement it.
> Have you tried to measure any performance change with this? E.g. you could
run a luceneutil benchy with just
mikemccand commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1504523798
##
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##
@@ -92,6 +93,7 @@ public Automaton() {
public Automaton(int numStates, int
mikemccand commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1966886223
I will have a look -- thanks for the ping @jpountz.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jpountz commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1961611793
`IntersectsTermsEnum` is a bit scary to me, maybe @mikemccand can take a
look, I expect him to be more familiar with it.
--
This is an automated message from the Apache Git Service.
github-actions[bot] commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-1953303608
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your
31 matches
Mail list logo
