github-actions[bot] commented on PR #12842:
URL: https://github.com/apache/lucene/pull/12842#issuecomment-2028507574
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your
easyice commented on PR #12842:
URL: https://github.com/apache/lucene/pull/12842#issuecomment-2002039103
Yeah, it looks like we can optimize `writeGroupVInt` in the same way as we
did for the read logic. I'd love to try and run some benchmarks.
--
This is an automated message from the
jpountz commented on PR #12842:
URL: https://github.com/apache/lucene/pull/12842#issuecomment-1994545075
It looks like `writeGroupVInt` has room for improvement. Can we improve it
by making it look a bit more like the read logic?
--
This is an automated message from the Apache Git
easyice commented on PR #12842:
URL: https://github.com/apache/lucene/pull/12842#issuecomment-1976298566
Hi Adrien, for simplicity, I changed the logic to use group-varint for when
positions only (no offsets and no payloads). In addition, since
`writeGroupVInt` is slower than `writeVInt`,
easyice commented on code in PR #12842:
URL: https://github.com/apache/lucene/pull/12842#discussion_r1501300476
##
lucene/core/src/java/org/apache/lucene/index/FreqProxTermsWriter.java:
##
@@ -428,12 +443,36 @@ void reset(Sorter.DocMap docMap, PostingsEnum in, boolean
jpountz commented on code in PR #12842:
URL: https://github.com/apache/lucene/pull/12842#discussion_r1500898031
##
lucene/core/src/java/org/apache/lucene/index/FreqProxTermsWriter.java:
##
@@ -428,12 +443,36 @@ void reset(Sorter.DocMap docMap, PostingsEnum in, boolean
github-actions[bot] commented on PR #12842:
URL: https://github.com/apache/lucene/pull/12842#issuecomment-1880899578
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your
easyice commented on PR #12842:
URL: https://github.com/apache/lucene/pull/12842#issuecomment-1858130375
> i'll test it with #12841 optimized code tomorrow.
emmm... there's still no significant performance improvement, possibly the
write path `writeGroupVInts` is a bit slower than
easyice commented on PR #12842:
URL: https://github.com/apache/lucene/pull/12842#issuecomment-1856293777
Sorry for the late update! i spent some more time on other PR, i encoded the
positions with group-varint when `storeOffsets` is false and there are no
payloads. with the last commit, it
easyice commented on PR #12842:
URL: https://github.com/apache/lucene/pull/12842#issuecomment-1826180124
Thanks for your suggestion, i'm thinking about that too, i will continue
working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message,
jpountz commented on PR #12842:
URL: https://github.com/apache/lucene/pull/12842#issuecomment-1825874597
Thanks for looking. Unfortunately, the case I'm most interested in is when
`storeOffsets` is false and there are no payloads, since this is the default. :)
--
This is an automated
11 matches
Mail list logo
