Re: [PR] Use growNoCopy in some places [lucene]

dweiss commented on PR #12951: URL: https://github.com/apache/lucene/pull/12951#issuecomment-1925823962 I've backported to branch_9x as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Use growNoCopy in some places [lucene]

dweiss merged PR #12951: URL: https://github.com/apache/lucene/pull/12951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Use growNoCopy in some places [lucene]

easyice commented on PR #12951: URL: https://github.com/apache/lucene/pull/12951#issuecomment-1925637932 @epotyom @dweiss Hi, can you help me to merge if it looks okay? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Use growNoCopy in some places [lucene]

github-actions[bot] commented on PR #12951: URL: https://github.com/apache/lucene/pull/12951#issuecomment-1924928770 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Use growNoCopy in some places [lucene]

easyice commented on PR #12951: URL: https://github.com/apache/lucene/pull/12951#issuecomment-1900247470 Thank you for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Use growNoCopy in some places [lucene]

easyice commented on code in PR #12951: URL: https://github.com/apache/lucene/pull/12951#discussion_r1458564693 ## lucene/core/src/java/org/apache/lucene/util/fst/Util.java: ## Review Comment: Nice find! Thank you @epotyom ! -- This is an automated message from the

Re: [PR] Use growNoCopy in some places [lucene]

epotyom commented on code in PR #12951: URL: https://github.com/apache/lucene/pull/12951#discussion_r1457735063 ## lucene/core/src/java/org/apache/lucene/util/fst/Util.java: ## Review Comment: I think `toUTF16` is another method in this class that can use `growNoCopy`.

Re: [PR] Use growNoCopy in some places [lucene]

github-actions[bot] commented on PR #12951: URL: https://github.com/apache/lucene/pull/12951#issuecomment-1880898535 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Use growNoCopy in some places [lucene]

easyice commented on code in PR #12951: URL: https://github.com/apache/lucene/pull/12951#discussion_r1428978833 ## lucene/core/src/java/org/apache/lucene/util/BytesRefBuilder.java: ## @@ -60,6 +60,13 @@ public void grow(int capacity) { ref.bytes = ArrayUtil.grow(ref.bytes,

Re: [PR] Use growNoCopy in some places [lucene]

dweiss commented on code in PR #12951: URL: https://github.com/apache/lucene/pull/12951#discussion_r1428895426 ## lucene/core/src/java/org/apache/lucene/util/BytesRefBuilder.java: ## @@ -60,6 +60,13 @@ public void grow(int capacity) { ref.bytes = ArrayUtil.grow(ref.bytes,