[jira] [Commented] (MPLUGIN-335) Support JDK 10 for plugin generation

[ https://issues.apache.org/jira/browse/MPLUGIN-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464710#comment-16464710 ] ASF GitHub Bot commented on MPLUGIN-335: aldaris opened a new pull request #13: [MPLUGIN-335] -

[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186258276 ## File path:

[jira] [Updated] (MNG-6386) ${project.baseUri} is not a valid URI (according to RFC 3986)

[ https://issues.apache.org/jira/browse/MNG-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6386: Fix Version/s: (was: 3.6.0-candidate) 3.5.4-candidate > ${project.baseUri} is

[GitHub] aldaris opened a new pull request #13: [MPLUGIN-335] - Fix build and tests

aldaris opened a new pull request #13: [MPLUGIN-335] - Fix build and tests URL: https://github.com/apache/maven-plugin-tools/pull/13 The previous PR ignored JDK<9 builds and caused test failures on JDK9+. This PR should address these.

[jira] [Commented] (MPLUGIN-335) Support JDK 10 for plugin generation

[ https://issues.apache.org/jira/browse/MPLUGIN-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464712#comment-16464712 ] ASF GitHub Bot commented on MPLUGIN-335: olamy closed pull request #13: [MPLUGIN-335] - Fix build

[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186258276 ## File path:

[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186260085 ## File path:

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386793374 Make it three commits.  This is an automated

[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186258477 ## File path:

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464741#comment-16464741 ] Michael Osipov commented on MNG-6401: - Only 3.0 is affected? What about 3.5.3? > Cannot interpolate

[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186260157 ## File path:

[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186260157 ## File path:

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386799705 I think, we may get rid of integration test class `JUnit5IT` as it refers to the soon deprecated

[GitHub] olamy closed pull request #13: [MPLUGIN-335] - Fix build and tests

olamy closed pull request #13: [MPLUGIN-335] - Fix build and tests URL: https://github.com/apache/maven-plugin-tools/pull/13 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[jira] [Commented] (MPLUGIN-335) Support JDK 10 for plugin generation

[ https://issues.apache.org/jira/browse/MPLUGIN-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464715#comment-16464715 ] Hudson commented on MPLUGIN-335: Build failed in Jenkins: Maven TLP » maven-plugin-tools » master #23

[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186267506 ## File path:

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386828650 JDK 10 seems okay now. JDK 7 still chokes on "--target 1.8" options...

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386828650 JDK 10 seems okay now. JDK 7 still chokes on "--target 1.8" options...

[GitHub] michael-o commented on issue #140: Add org.slf4j.event to exported packages

michael-o commented on issue #140: Add org.slf4j.event to exported packages URL: https://github.com/apache/maven/pull/140#issuecomment-386833306 @dconneely Please see MNG-6360. This seems to be overcome already. Can you confirm?

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[ https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464892#comment-16464892 ] ASF GitHub Bot commented on MNG-6360: - michael-o commented on issue #157: [MNG-6360] adding

[GitHub] michael-o commented on a change in pull request #160: Fix links to Apache/CDDL/MIT licenses

michael-o commented on a change in pull request #160: Fix links to Apache/CDDL/MIT licenses URL: https://github.com/apache/maven/pull/160#discussion_r186272200 ## File path: apache-maven/src/main/appended-resources/META-INF/LICENSE.vm ## @@ -21,19 +21,23 @@ Apache Maven

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386825239 > ... You have to squash all commits ... Losing history and reasoning is okay?

[GitHub] michael-o commented on issue #126: Update code style quikstart-arhetype

michael-o commented on issue #126: Update code style quikstart-arhetype URL: https://github.com/apache/maven/pull/126#issuecomment-386833015 Please close. This is an automated message from the Apache Git Service. To respond

[GitHub] michael-o commented on issue #157: [MNG-6360] adding org.slf4j.event in exported packages

michael-o commented on issue #157: [MNG-6360] adding org.slf4j.event in exported packages URL: https://github.com/apache/maven/pull/157#issuecomment-386833261 @rmannibucau As discussed on JIRA, this can be closed. Do you agree?

[GitHub] asfgit closed pull request #132: Fix the Javadoc to use a proper @link tag when pointing to ProjectBuilder

asfgit closed pull request #132: Fix the Javadoc to use a proper @link tag when pointing to ProjectBuilder URL: https://github.com/apache/maven/pull/132 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rmannibucau commented on issue #157: [MNG-6360] adding org.slf4j.event in exported packages

rmannibucau commented on issue #157: [MNG-6360] adding org.slf4j.event in exported packages URL: https://github.com/apache/maven/pull/157#issuecomment-386835055 No more blocking This is an automated message from the Apache

[GitHub] rmannibucau closed pull request #157: [MNG-6360] adding org.slf4j.event in exported packages

rmannibucau closed pull request #157: [MNG-6360] adding org.slf4j.event in exported packages URL: https://github.com/apache/maven/pull/157 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[ https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464898#comment-16464898 ] ASF GitHub Bot commented on MNG-6360: - rmannibucau closed pull request #157: [MNG-6360] adding

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[ https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464897#comment-16464897 ] ASF GitHub Bot commented on MNG-6360: - rmannibucau commented on issue #157: [MNG-6360] adding

[GitHub] jkatada commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

jkatada commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-386855007 > As far as I understand this PR, you are interpolating the settings before it is fead to SettingsXpp3Reader?

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464985#comment-16464985 ] ASF GitHub Bot commented on MNG-6401: - jkatada opened a new pull request #31: [MNG-6401] Add IT for

[GitHub] jkatada opened a new pull request #31: [MNG-6401] Add IT for interpolation in settings.xml

jkatada opened a new pull request #31: [MNG-6401] Add IT for interpolation in settings.xml URL: https://github.com/apache/maven-integration-testing/pull/31 [Corresponding Maven pull request.](https://github.com/apache/maven/pull/163)

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464986#comment-16464986 ] ASF GitHub Bot commented on MNG-6401: - jkatada commented on issue #163: [MNG-6401] - Cannot interpolate

[GitHub] Tibor17 commented on issue #178: SUREFIRE-1422

Tibor17 commented on issue #178: SUREFIRE-1422 URL: https://github.com/apache/maven-surefire/pull/178#issuecomment-386840236 Already pushed from the branch `SUREFIRE-1503`. This is an automated message from the Apache Git

[jira] [Commented] (SUREFIRE-1422) Forking fails on Linux if /bin/ps isn't available

[ https://issues.apache.org/jira/browse/SUREFIRE-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464924#comment-16464924 ] ASF GitHub Bot commented on SUREFIRE-1422: -- Tibor17 commented on issue #178: SUREFIRE-1422

[jira] [Commented] (SUREFIRE-1422) Forking fails on Linux if /bin/ps isn't available

[ https://issues.apache.org/jira/browse/SUREFIRE-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464923#comment-16464923 ] ASF GitHub Bot commented on SUREFIRE-1422: -- Tibor17 closed pull request #178: SUREFIRE-1422

[GitHub] Tibor17 closed pull request #178: SUREFIRE-1422

Tibor17 closed pull request #178: SUREFIRE-1422 URL: https://github.com/apache/maven-surefire/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841297 Now I see, you used the build process JDK `${java.home}/bin/java` Very well!

[jira] [Updated] (MNG-5756) Java home output in mvn -v is misleading

[ https://issues.apache.org/jira/browse/MNG-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-5756: Fix Version/s: 3.5.4-candidate > Java home output in mvn -v is misleading >

[jira] [Assigned] (MNG-5756) Java home output in mvn -v is misleading

[ https://issues.apache.org/jira/browse/MNG-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-5756: --- Assignee: Michael Osipov > Java home output in mvn -v is misleading >

[GitHub] clambertus closed pull request #118: Upgrade SLF4J to 1.7.25

clambertus closed pull request #118: Upgrade SLF4J to 1.7.25 URL: https://github.com/apache/maven/pull/118 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] clambertus closed pull request #126: Update code style quikstart-arhetype

clambertus closed pull request #126: Update code style quikstart-arhetype URL: https://github.com/apache/maven/pull/126 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[jira] [Commented] (MNG-6296) New option -Dstyle.color is not working

[ https://issues.apache.org/jira/browse/MNG-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464913#comment-16464913 ] ASF GitHub Bot commented on MNG-6296: - clambertus closed pull request #135: [MNG-6296] Parse properties

[GitHub] clambertus closed pull request #135: [MNG-6296] Parse properties before configuring the logging settings

clambertus closed pull request #135: [MNG-6296] Parse properties before configuring the logging settings URL: https://github.com/apache/maven/pull/135 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Commented] (SUREFIRE-1383) dependenciesToScan Does Not Leverage Classpath Elements

[ https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464920#comment-16464920 ] Tibor Digana commented on SUREFIRE-1383: Created branch

[GitHub] Tibor17 commented on issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverage Classpath Elements

Tibor17 commented on issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverage Classpath Elements URL: https://github.com/apache/maven-surefire/pull/157#issuecomment-386839993 @owenfarrell @paulduffin I have finished the implementation in the branch `1383` but I changed the

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464925#comment-16464925 ] KATADA Junya commented on MNG-6401: --- Sorry, 3.5.3 is also affected. I updated "Affects Version/s" field.

[jira] [Commented] (SUREFIRE-1004) Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT

[ https://issues.apache.org/jira/browse/SUREFIRE-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464926#comment-16464926 ] ASF GitHub Bot commented on SUREFIRE-1004: -- Tibor17 commented on issue #173: [SUREFIRE-1004]

[jira] [Updated] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KATADA Junya updated MNG-6401: -- Affects Version/s: 3.5.3 > Cannot interpolate property in proxy port of settings.xml >

[GitHub] Tibor17 commented on issue #173: [SUREFIRE-1004] Support full gavtc format for dependenciesToScan

Tibor17 commented on issue #173: [SUREFIRE-1004] Support full gavtc format for dependenciesToScan URL: https://github.com/apache/maven-surefire/pull/173#issuecomment-386840313 @bindul I think we can merge this to master but this PR will have a merge conflict soon because I will merge

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386840975 @sormuras Did you also have a problem with JaCoCO:0.7.9 on JDK10? Do we need to have `scope=compile` on the

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841327 That's exactly why we have two JDKs. This is an

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841297 Noe I see, you used the build process JDK `${java.home}/bin/java` Very well!

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464940#comment-16464940 ] Michael Osipov commented on MNG-6401: - Same applies to all boolean fields. It is even worse, you don't

[jira] [Commented] (MNG-5756) Java home output in mvn -v is misleading

[ https://issues.apache.org/jira/browse/MNG-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464912#comment-16464912 ] Michael Osipov commented on MNG-5756: - So I pushed a test branch for this. The solution is a reduced

[jira] [Created] (MNG-6403) Artifact#VERSION_FILE_PATTERN does not escape period between date and time

Michael Osipov created MNG-6403: --- Summary: Artifact#VERSION_FILE_PATTERN does not escape period between date and time Key: MNG-6403 URL: https://issues.apache.org/jira/browse/MNG-6403 Project: Maven

[jira] [Updated] (SUREFIRE-1383) dependenciesToScan Does Not Leverage Classpath Elements

[ https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1383: --- Fix Version/s: (was: 2.21.1) 3.0.0-M1 > dependenciesToScan Does Not

[jira] [Commented] (SUREFIRE-1383) dependenciesToScan Does Not Leverage Classpath Elements

[ https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464921#comment-16464921 ] ASF GitHub Bot commented on SUREFIRE-1383: -- Tibor17 commented on issue #157: SUREFIRE-1383

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841131 @sormuras How did you skip tests on `surefire-junit-platform` with JDK 1.7?

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464933#comment-16464933 ] ASF GitHub Bot commented on MNG-6401: - michael-o commented on issue #163: [MNG-6401] - Cannot

[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-386841740 As far as I understand this PR, you are interpolating the settings before it is fead to `SettingsXpp3Reader`?

[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-386842019 Can you also provide an IT for that? @hboutemy, @rfscholte This is a very interesting case and I can confirm

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464935#comment-16464935 ] ASF GitHub Bot commented on MNG-6401: - michael-o commented on issue #163: [MNG-6401] - Cannot

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464936#comment-16464936 ] Michael Osipov commented on MNG-6401: - Issue confirmed. > Cannot interpolate property in proxy port of

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386821219 @sormuras Did you override the branch `1330`? Because I squashed last cca 5 commits to one. You have to squash

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386822137 I will have a look to the sniffer plugin in the evening and I will try to run the build.

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386827017 Why are they banned? [linux-jdk10-maven3.5.x] Found Banned Dependency:

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386825239 > ... You have to squash all commits ... Losing history and reasoning is okay? Done.