[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
slachiewicz commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766870955 ``` [INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ maven-filtering --- [WARNING] Used undeclared dependencies found: [WARNING]

[jira] [Updated] (MNG-7086) MavenProject.getDependencyArtifacts is deprecated with no replacement documented

2021-01-25 Thread Robert Krajewski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Krajewski updated MNG-7086: -- Priority: Minor (was: Major) > MavenProject.getDependencyArtifacts is deprecated with no

[jira] [Created] (MNG-7086) MavenProject.getDependencyArtifacts is deprecated with no replacement documented

2021-01-25 Thread Robert Krajewski (Jira)
Robert Krajewski created MNG-7086: - Summary: MavenProject.getDependencyArtifacts is deprecated with no replacement documented Key: MNG-7086 URL: https://issues.apache.org/jira/browse/MNG-7086

[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
slachiewicz commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766868911 thx @dennisl - would you be able to sync the maven version to 3.1.1 as try to confirm that this proposed approach works?

[GitHub] [maven] gnodet commented on a change in pull request #433: [MNG-7079] Upgrade to jansi 2.2.0

2021-01-25 Thread GitBox
gnodet commented on a change in pull request #433: URL: https://github.com/apache/maven/pull/433#discussion_r563970985 ## File path: pom.xml ## @@ -319,12 +319,12 @@ under the License. org.apache.maven.shared maven-shared-utils -3.2.1 +

[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
slachiewicz commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766874181 real case: https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1091 This is an

[jira] [Created] (MNG-7084) enable injection of 'org.apache.maven.plugin.logging.Log'

2021-01-25 Thread Matthieu Brouillard (Jira)
Matthieu Brouillard created MNG-7084: Summary: enable injection of 'org.apache.maven.plugin.logging.Log' Key: MNG-7084 URL: https://issues.apache.org/jira/browse/MNG-7084 Project: Maven

[GitHub] [maven-shared-utils] gnodet commented on a change in pull request #70: [MNG-6915] Add a helper method to get the terminal width

2021-01-25 Thread GitBox
gnodet commented on a change in pull request #70: URL: https://github.com/apache/maven-shared-utils/pull/70#discussion_r563991395 ## File path: src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java ## @@ -201,4 +201,21 @@ public void run()

[jira] [Updated] (MENFORCER-372) Switch to JUnit5

2021-01-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MENFORCER-372: --- Fix Version/s: 3.0.1 > Switch to JUnit5 > > >

[jira] [Comment Edited] (MPIR-402) Modules Report: provide links to Maven Central

2021-01-25 Thread Florian Brunner (Jira)
[ https://issues.apache.org/jira/browse/MPIR-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271395#comment-17271395 ] Florian Brunner edited comment on MPIR-402 at 1/25/21, 7:51 PM: If you have

[jira] [Commented] (MNG-7086) MavenProject.getDependencyArtifacts is deprecated with no replacement documented

2021-01-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271639#comment-17271639 ] Michael Osipov commented on MNG-7086: - This, unfortunately, applies to a lot of code. >

[GitHub] [maven-dependency-tree] slachiewicz commented on a change in pull request #6: [PoC] Require maven 3.1.1

2021-01-25 Thread GitBox
slachiewicz commented on a change in pull request #6: URL: https://github.com/apache/maven-dependency-tree/pull/6#discussion_r564028858 ## File path: src/main/java/org/apache/maven/shared/dependency/graph/DependencyGraphBuilder.java ## @@ -26,7 +26,7 @@ import

[GitHub] [maven-enforcer] KroArtem opened a new pull request #87: [MENFORCER-377] - Remove travis support (github covers the same checks)

2021-01-25 Thread GitBox
KroArtem opened a new pull request #87: URL: https://github.com/apache/maven-enforcer/pull/87 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed

[jira] [Commented] (MENFORCER-377) Remove reference to travis or switch to travis.com

2021-01-25 Thread Krosheninnikov Artem (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271704#comment-17271704 ] Krosheninnikov Artem commented on MENFORCER-377: Well, it seems like travis support

[GitHub] [maven-shared-utils] gnodet commented on a change in pull request #70: [MNG-6915] Add a helper method to get the terminal width

2021-01-25 Thread GitBox
gnodet commented on a change in pull request #70: URL: https://github.com/apache/maven-shared-utils/pull/70#discussion_r563993812 ## File path: src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java ## @@ -201,4 +201,21 @@ public void run()

[GitHub] [maven-enforcer] slachiewicz commented on pull request #85: [MENFORCER-371] Require maven 3.1.1

2021-01-25 Thread GitBox
slachiewicz commented on pull request #85: URL: https://github.com/apache/maven-enforcer/pull/85#issuecomment-767087603 Thx merged with additional commits This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (SUREFIRE-1788) Unhandled native logs in SurefireForkChannel

2021-01-25 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271664#comment-17271664 ] Tibor Digana commented on SUREFIRE-1788: [~kriegaex] Pls create a new ticket and specify the

[jira] [Commented] (MENFORCER-371) Require Maven 3.1.1

2021-01-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271663#comment-17271663 ] Hudson commented on MENFORCER-371: -- Build failed in Jenkins: Maven » Maven TLP » maven-enforcer »

[GitHub] [maven-dependency-tree] slachiewicz commented on a change in pull request #6: [PoC] Require maven 3.1.1

2021-01-25 Thread GitBox
slachiewicz commented on a change in pull request #6: URL: https://github.com/apache/maven-dependency-tree/pull/6#discussion_r564028264 ## File path: pom.xml ## @@ -173,7 +139,8 @@ These files contains the expected output of this component and can not contain

[GitHub] [maven-shared-utils] gnodet edited a comment on pull request #77: replace deprecated fields

2021-01-25 Thread GitBox
gnodet edited a comment on pull request #77: URL: https://github.com/apache/maven-shared-utils/pull/77#issuecomment-767143954 I think the commit at https://github.com/apache/maven-shared-utils/pull/67/commits/09e880253655b05bc63252f57157043cf5d87868, part of

[GitHub] [maven-shared-utils] gnodet commented on pull request #77: replace deprecated fields

2021-01-25 Thread GitBox
gnodet commented on pull request #77: URL: https://github.com/apache/maven-shared-utils/pull/77#issuecomment-767143954 I think the commit at https://github.com/apache/maven-shared-utils/pull/67/commits/09e880253655b05bc63252f57157043cf5d87868 kinda removes the need for this change.

[jira] [Comment Edited] (MPIR-402) Modules Report: provide links to Maven Central

2021-01-25 Thread Florian Brunner (Jira)
[ https://issues.apache.org/jira/browse/MPIR-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271395#comment-17271395 ] Florian Brunner edited comment on MPIR-402 at 1/25/21, 7:52 PM: If you have

[jira] [Updated] (MENFORCER-350) requireMavenVersion x.y.x is processed as (,x.y.z] instead of [x.y.z,)

2021-01-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MENFORCER-350: --- Fix Version/s: 3.0.0-M4 > requireMavenVersion x.y.x is processed as

[jira] [Assigned] (MENFORCER-350) requireMavenVersion x.y.x is processed as (,x.y.z] instead of [x.y.z,)

2021-01-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MENFORCER-350: -- Assignee: Sylwester Lachiewicz > requireMavenVersion x.y.x is

[jira] [Updated] (MENFORCER-350) requireMavenVersion x.y.x is processed as (,x.y.z] instead of [x.y.z,)

2021-01-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MENFORCER-350: --- Labels: (was: close-pending) > requireMavenVersion x.y.x is processed

[jira] [Closed] (MENFORCER-350) requireMavenVersion x.y.x is processed as (,x.y.z] instead of [x.y.z,)

2021-01-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MENFORCER-350. -- Resolution: Fixed > requireMavenVersion x.y.x is processed as (,x.y.z]

[GitHub] [maven-shared-utils] gnodet commented on a change in pull request #70: [MNG-6915] Add a helper method to get the terminal width

2021-01-25 Thread GitBox
gnodet commented on a change in pull request #70: URL: https://github.com/apache/maven-shared-utils/pull/70#discussion_r564009694 ## File path: src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java ## @@ -201,4 +201,21 @@ public void run()

[GitHub] [maven-enforcer] asfgit closed pull request #85: [MENFORCER-371] Require maven 3.1.1

2021-01-25 Thread GitBox
asfgit closed pull request #85: URL: https://github.com/apache/maven-enforcer/pull/85 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven] gnodet commented on a change in pull request #433: [MNG-7079] Upgrade to jansi 2.2.0

2021-01-25 Thread GitBox
gnodet commented on a change in pull request #433: URL: https://github.com/apache/maven/pull/433#discussion_r563970985 ## File path: pom.xml ## @@ -319,12 +319,12 @@ under the License. org.apache.maven.shared maven-shared-utils -3.2.1 +

[jira] [Commented] (MPIR-402) Modules Report: provide links to Maven Central

2021-01-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271667#comment-17271667 ] Michael Osipov commented on MPIR-402: - Your rendering contains two interesting things: artifact id and

[GitHub] [maven-shared-utils] gnodet commented on a change in pull request #70: [MNG-6915] Add a helper method to get the terminal width

2021-01-25 Thread GitBox
gnodet commented on a change in pull request #70: URL: https://github.com/apache/maven-shared-utils/pull/70#discussion_r564009153 ## File path: src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java ## @@ -201,4 +201,21 @@ public void run()

[jira] [Updated] (MENFORCER-371) Require Maven 3.1.1

2021-01-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MENFORCER-371: --- Fix Version/s: 3.0.0-M4 > Require Maven 3.1.1 > --- > >

[jira] [Updated] (MENFORCER-377) Remove reference to travis or switch to travis.com

2021-01-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MENFORCER-377: --- Fix Version/s: 3.0.0-M4 > Remove reference to travis or switch to

[jira] [Assigned] (MENFORCER-377) Remove reference to travis or switch to travis.com

2021-01-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MENFORCER-377: -- Assignee: Sylwester Lachiewicz > Remove reference to travis or

[GitHub] [maven-enforcer] slachiewicz merged pull request #87: Remove duplicate .gitignore lines

2021-01-25 Thread GitBox
slachiewicz merged pull request #87: URL: https://github.com/apache/maven-enforcer/pull/87 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MENFORCER-377) Remove reference to travis or switch to travis.com

2021-01-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271716#comment-17271716 ] Sylwester Lachiewicz commented on MENFORCER-377: Sorry [~KroArtem] I missed Yours PR -

[jira] [Closed] (MENFORCER-377) Remove reference to travis or switch to travis.com

2021-01-25 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MENFORCER-377. -- Resolution: Fixed > Remove reference to travis or switch to travis.com >

[jira] [Commented] (MENFORCER-377) Remove reference to travis or switch to travis.com

2021-01-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271722#comment-17271722 ] Hudson commented on MENFORCER-377: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-enforcer »

[GitHub] [maven-enforcer] KroArtem commented on pull request #87: Remove duplicate .gitignore lines

2021-01-25 Thread GitBox
KroArtem commented on pull request #87: URL: https://github.com/apache/maven-enforcer/pull/87#issuecomment-767155960 Since travis is already removed, I've left what was also in this PR (removing duplicated lines from gitignore)

[GitHub] [maven-enforcer] slachiewicz merged pull request #88: Update github actions: define java 15, java 16-ea, update actions/cac…

2021-01-25 Thread GitBox
slachiewicz merged pull request #88: URL: https://github.com/apache/maven-enforcer/pull/88 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-enforcer] slachiewicz closed pull request #83: update maven dependency tree

2021-01-25 Thread GitBox
slachiewicz closed pull request #83: URL: https://github.com/apache/maven-enforcer/pull/83 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-enforcer] slachiewicz commented on pull request #83: update maven dependency tree

2021-01-25 Thread GitBox
slachiewicz commented on pull request #83: URL: https://github.com/apache/maven-enforcer/pull/83#issuecomment-767166677 I'm working on it, I'll open new PR with all needed changes This is an automated message from the Apache

[GitHub] [maven-enforcer] KroArtem opened a new pull request #88: Update github actions: define java 15, java 16-ea, update actions/cac…

2021-01-25 Thread GitBox
KroArtem opened a new pull request #88: URL: https://github.com/apache/maven-enforcer/pull/88 …he@v1 to actions/cache@v2 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[jira] [Updated] (MNG-7085) Loggers documentation clarifications

2021-01-25 Thread Matthieu Brouillard (Jira)
[ https://issues.apache.org/jira/browse/MNG-7085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthieu Brouillard updated MNG-7085: - Description: Following discussions from dev-list in ["Logging api in

[GitHub] [maven] michael-o commented on a change in pull request #436: [MNG-7080] Add a --color option to simplify color support

2021-01-25 Thread GitBox
michael-o commented on a change in pull request #436: URL: https://github.com/apache/maven/pull/436#discussion_r563901162 ## File path: pom.xml ## @@ -319,12 +319,12 @@ under the License. org.apache.maven.shared maven-shared-utils -3.2.1 +

[GitHub] [maven-archetype] jaredculp commented on pull request #61: [ARCHETYPE-612] Fixes to required property sort approach

2021-01-25 Thread GitBox
jaredculp commented on pull request #61: URL: https://github.com/apache/maven-archetype/pull/61#issuecomment-766919691 Yeah we basically decided to write a shell script as a wrapper which does all the parsing and then passes the values to the archetype in batch mode.

[jira] [Commented] (MPIR-402) Modules Report: provide links to Maven Central

2021-01-25 Thread Florian Brunner (Jira)
[ https://issues.apache.org/jira/browse/MPIR-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271395#comment-17271395 ] Florian Brunner commented on MPIR-402: -- If you have a look at "Project Modules" report of e.g.

[GitHub] [maven] gnodet commented on a change in pull request #436: [MNG-7080] Add a --color option to simplify color support

2021-01-25 Thread GitBox
gnodet commented on a change in pull request #436: URL: https://github.com/apache/maven/pull/436#discussion_r563906834 ## File path: pom.xml ## @@ -319,12 +319,12 @@ under the License. org.apache.maven.shared maven-shared-utils -3.2.1 +

[GitHub] [maven] gnodet commented on a change in pull request #436: [MNG-7080] Add a --color option to simplify color support

2021-01-25 Thread GitBox
gnodet commented on a change in pull request #436: URL: https://github.com/apache/maven/pull/436#discussion_r563906834 ## File path: pom.xml ## @@ -319,12 +319,12 @@ under the License. org.apache.maven.shared maven-shared-utils -3.2.1 +

[GitHub] [maven-filtering] dennisl commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
dennisl commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766864034 I agree with @elharo This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
slachiewicz commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766872291 With each minimum Maven upgrade, someone needs to review all deps and update the version of aether to match with that will be delivered by Maven installation. No older,

[jira] [Created] (MNG-7085) Loggers documentation clarifications

2021-01-25 Thread Matthieu Brouillard (Jira)
Matthieu Brouillard created MNG-7085: Summary: Loggers documentation clarifications Key: MNG-7085 URL: https://issues.apache.org/jira/browse/MNG-7085 Project: Maven Issue Type:

[GitHub] [maven-checkstyle-plugin] elharo merged pull request #44: use try with resources and charset

2021-01-25 Thread GitBox
elharo merged pull request #44: URL: https://github.com/apache/maven-checkstyle-plugin/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven] gnodet commented on a change in pull request #436: [MNG-7080] Add a --color option to simplify color support

2021-01-25 Thread GitBox
gnodet commented on a change in pull request #436: URL: https://github.com/apache/maven/pull/436#discussion_r563906834 ## File path: pom.xml ## @@ -319,12 +319,12 @@ under the License. org.apache.maven.shared maven-shared-utils -3.2.1 +

[GitHub] [maven-enforcer] KroArtem commented on a change in pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule

2021-01-25 Thread GitBox
KroArtem commented on a change in pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#discussion_r563658948 ## File path: enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVendor.java ## @@ -31,40 +33,112 @@ */ public class

[GitHub] [maven-common-artifact-filters] michael-o commented on pull request #15: Big speed improvements for patterns that do not contain any wildcard

2021-01-25 Thread GitBox
michael-o commented on pull request #15: URL: https://github.com/apache/maven-common-artifact-filters/pull/15#issuecomment-766815463 > @michael-o @elharo I've fixed the (what I consider) real issues, i.e. the missing copyright and some check style errors. I think the problems mentioned

[GitHub] [maven-shared-utils] gnodet commented on pull request #77: replace deprecated fields

2021-01-25 Thread GitBox
gnodet commented on pull request #77: URL: https://github.com/apache/maven-shared-utils/pull/77#issuecomment-767143954 I think the commit at https://github.com/apache/maven-shared-utils/pull/67/commits/09e880253655b05bc63252f57157043cf5d87868 kinda removes the need for this change.

[GitHub] [maven-enforcer] slachiewicz merged pull request #88: Update github actions: define java 15, java 16-ea, update actions/cac…

2021-01-25 Thread GitBox
slachiewicz merged pull request #88: URL: https://github.com/apache/maven-enforcer/pull/88 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-enforcer] slachiewicz commented on pull request #83: update maven dependency tree

2021-01-25 Thread GitBox
slachiewicz commented on pull request #83: URL: https://github.com/apache/maven-enforcer/pull/83#issuecomment-767166677 I'm working on it, I'll open new PR with all needed changes This is an automated message from the Apache

[GitHub] [maven] michael-o commented on a change in pull request #436: [MNG-7080] Add a --color option to simplify color support

2021-01-25 Thread GitBox
michael-o commented on a change in pull request #436: URL: https://github.com/apache/maven/pull/436#discussion_r563901162 ## File path: pom.xml ## @@ -319,12 +319,12 @@ under the License. org.apache.maven.shared maven-shared-utils -3.2.1 +

[GitHub] [maven-common-artifact-filters] gnodet commented on pull request #15: Big speed improvements for patterns that do not contain any wildcard

2021-01-25 Thread GitBox
gnodet commented on pull request #15: URL: https://github.com/apache/maven-common-artifact-filters/pull/15#issuecomment-766796366 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-filtering] dennisl commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
dennisl commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766864034 I agree with @elharo This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #87: [MNG-7051] Test activation of non-existing profiles

2021-01-25 Thread GitBox
michael-o commented on a change in pull request #87: URL: https://github.com/apache/maven-integration-testing/pull/87#discussion_r563393294 ## File path: core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java ## @@ -106,6 +106,10 @@ public static Test

[GitHub] [maven-enforcer] KroArtem commented on pull request #87: Remove duplicate .gitignore lines

2021-01-25 Thread GitBox
KroArtem commented on pull request #87: URL: https://github.com/apache/maven-enforcer/pull/87#issuecomment-767155960 Since travis is already removed, I've left what was also in this PR (removing duplicated lines from gitignore)

[GitHub] [maven-enforcer] rfscholte commented on a change in pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule

2021-01-25 Thread GitBox
rfscholte commented on a change in pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#discussion_r563653714 ## File path: enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVendor.java ## @@ -31,40 +33,112 @@ */ public class

[GitHub] [maven-common-artifact-filters] gnodet edited a comment on pull request #15: Big speed improvements for patterns that do not contain any wildcard

2021-01-25 Thread GitBox
gnodet edited a comment on pull request #15: URL: https://github.com/apache/maven-common-artifact-filters/pull/15#issuecomment-766803358 @michael-o @elharo I've fixed the (what I consider) real issues, i.e. the missing copyright and some check style errors. I think the problems mentioned

[GitHub] [maven] gnodet commented on a change in pull request #433: [MNG-7079] Upgrade to jansi 2.2.0

2021-01-25 Thread GitBox
gnodet commented on a change in pull request #433: URL: https://github.com/apache/maven/pull/433#discussion_r563970985 ## File path: pom.xml ## @@ -319,12 +319,12 @@ under the License. org.apache.maven.shared maven-shared-utils -3.2.1 +

[GitHub] [maven-archetype] jaredculp commented on pull request #61: [ARCHETYPE-612] Fixes to required property sort approach

2021-01-25 Thread GitBox
jaredculp commented on pull request #61: URL: https://github.com/apache/maven-archetype/pull/61#issuecomment-766919691 Yeah we basically decided to write a shell script as a wrapper which does all the parsing and then passes the values to the archetype in batch mode.

[GitHub] [maven-common-artifact-filters] michael-o commented on a change in pull request #15: Big speed improvements for patterns that do not contain any wildcard

2021-01-25 Thread GitBox
michael-o commented on a change in pull request #15: URL: https://github.com/apache/maven-common-artifact-filters/pull/15#discussion_r563674915 ## File path: src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java ## @@ -107,322 +147,829 @@

[GitHub] [maven-enforcer] slachiewicz commented on pull request #85: [MENFORCER-371] Require maven 3.1.1

2021-01-25 Thread GitBox
slachiewicz commented on pull request #85: URL: https://github.com/apache/maven-enforcer/pull/85#issuecomment-767087603 Thx merged with additional commits This is an automated message from the Apache Git Service. To respond

[GitHub] [maven] michael-o commented on a change in pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

2021-01-25 Thread GitBox
michael-o commented on a change in pull request #429: URL: https://github.com/apache/maven/pull/429#discussion_r563362703 ## File path: maven-core/src/main/java/org/apache/maven/DefaultMaven.java ## @@ -493,25 +508,88 @@ private void

[GitHub] [maven-common-artifact-filters] slachiewicz commented on pull request #16: remove unused dependency

2021-01-25 Thread GitBox
slachiewicz commented on pull request #16: URL: https://github.com/apache/maven-common-artifact-filters/pull/16#issuecomment-766408356 reason why we have still this dependency.. https://github.com/apache/maven-common-artifact-filters/pull/12

[GitHub] [maven-filtering] elharo commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
elharo commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766457052 If one specifically imports classes from these dependencies, then they should be declared. Relaying on transitive dependencies is brittle. 5 months later I don't recall

[GitHub] [maven-checkstyle-plugin] bmarwell commented on a change in pull request #44: use try with resources and charset

2021-01-25 Thread GitBox
bmarwell commented on a change in pull request #44: URL: https://github.com/apache/maven-checkstyle-plugin/pull/44#discussion_r563372857 ## File path: src/main/java/org/apache/maven/plugins/checkstyle/rss/VelocityTemplate.java ## @@ -77,52 +79,34 @@ public VelocityComponent

[GitHub] [maven-dependency-tree] elharo commented on a change in pull request #6: [PoC] Require maven 3.1.1

2021-01-25 Thread GitBox
elharo commented on a change in pull request #6: URL: https://github.com/apache/maven-dependency-tree/pull/6#discussion_r563399792 ## File path: pom.xml ## @@ -173,7 +139,8 @@ These files contains the expected output of this component and can not contain a

[GitHub] [maven-common-artifact-filters] michael-o edited a comment on pull request #15: Big speed improvements for patterns that do not contain any wildcard

2021-01-25 Thread GitBox
michael-o edited a comment on pull request #15: URL: https://github.com/apache/maven-common-artifact-filters/pull/15#issuecomment-766815463 > @michael-o @elharo I've fixed the (what I consider) real issues, i.e. the missing copyright and some check style errors. I think the problems

[GitHub] [maven-shared-utils] gnodet edited a comment on pull request #77: replace deprecated fields

2021-01-25 Thread GitBox
gnodet edited a comment on pull request #77: URL: https://github.com/apache/maven-shared-utils/pull/77#issuecomment-767143954 I think the commit at https://github.com/apache/maven-shared-utils/pull/67/commits/09e880253655b05bc63252f57157043cf5d87868, part of

[GitHub] [maven-enforcer] elharo commented on a change in pull request #86: [MENFORCER-376] Add excludes/includes functionality to RequireJavaVendor rule

2021-01-25 Thread GitBox
elharo commented on a change in pull request #86: URL: https://github.com/apache/maven-enforcer/pull/86#discussion_r563677436 ## File path: enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVendor.java ## @@ -31,40 +33,112 @@ */ public class

[GitHub] [maven-common-artifact-filters] elharo commented on a change in pull request #15: Big speed improvements for patterns that do not contain any wildcard

2021-01-25 Thread GitBox
elharo commented on a change in pull request #15: URL: https://github.com/apache/maven-common-artifact-filters/pull/15#discussion_r563684005 ## File path: src/test/java/org/apache/maven/shared/artifact/filter/OldPatternIncludesArtifactFilter.java ## @@ -0,0 +1,428 @@

[GitHub] [maven-enforcer] slachiewicz closed pull request #83: update maven dependency tree

2021-01-25 Thread GitBox
slachiewicz closed pull request #83: URL: https://github.com/apache/maven-enforcer/pull/83 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-checkstyle-plugin] elharo merged pull request #44: use try with resources and charset

2021-01-25 Thread GitBox
elharo merged pull request #44: URL: https://github.com/apache/maven-checkstyle-plugin/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-shared-utils] gnodet commented on a change in pull request #70: [MNG-6915] Add a helper method to get the terminal width

2021-01-25 Thread GitBox
gnodet commented on a change in pull request #70: URL: https://github.com/apache/maven-shared-utils/pull/70#discussion_r563991395 ## File path: src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java ## @@ -201,4 +201,21 @@ public void run()

[GitHub] [maven-filtering] slachiewicz commented on pull request #14: declare dependencies

2021-01-25 Thread GitBox
slachiewicz commented on pull request #14: URL: https://github.com/apache/maven-filtering/pull/14#issuecomment-766429749 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven-enforcer] asfgit closed pull request #85: [MENFORCER-371] Require maven 3.1.1

2021-01-25 Thread GitBox
asfgit closed pull request #85: URL: https://github.com/apache/maven-enforcer/pull/85 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-checkstyle-plugin] elharo commented on a change in pull request #44: use try with resources and charset

2021-01-25 Thread GitBox
elharo commented on a change in pull request #44: URL: https://github.com/apache/maven-checkstyle-plugin/pull/44#discussion_r563715320 ## File path: src/main/java/org/apache/maven/plugins/checkstyle/rss/VelocityTemplate.java ## @@ -77,52 +79,34 @@ public VelocityComponent

[GitHub] [maven-common-artifact-filters] gnodet commented on a change in pull request #15: Big speed improvements for patterns that do not contain any wildcard

2021-01-25 Thread GitBox
gnodet commented on a change in pull request #15: URL: https://github.com/apache/maven-common-artifact-filters/pull/15#discussion_r563702687 ## File path: src/test/java/org/apache/maven/shared/artifact/filter/OldPatternIncludesArtifactFilter.java ## @@ -0,0 +1,428 @@

[jira] [Created] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-01-25 Thread Alexander Kriegisch (Jira)
Alexander Kriegisch created SUREFIRE-1881: - Summary: Java agent printing to native console makes build block when using SurefireForkNodeFactory Key: SUREFIRE-1881 URL:

[GitHub] [maven-dependency-tree] slachiewicz commented on a change in pull request #6: [PoC] Require maven 3.1.1

2021-01-25 Thread GitBox
slachiewicz commented on a change in pull request #6: URL: https://github.com/apache/maven-dependency-tree/pull/6#discussion_r564028264 ## File path: pom.xml ## @@ -173,7 +139,8 @@ These files contains the expected output of this component and can not contain

[jira] [Updated] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-25 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kriegisch updated SUREFIRE-1882: -- Attachment: 2021-01-26T13-22-12_972-jvmRun1.dump > 3.0.0-M6-SNAPSHOT no

[jira] [Updated] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-25 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kriegisch updated SUREFIRE-1882: -- Description: When running my build on JDK 8, I see {code} [INFO] ---

[jira] [Updated] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-25 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kriegisch updated SUREFIRE-1882: -- Description: When running my build on JDK 8, I see {code} [INFO] ---

[jira] [Updated] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-25 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kriegisch updated SUREFIRE-1882: -- Description: When running my build on JDK 8, I see {code} [INFO] ---

[GitHub] [maven-enforcer] slachiewicz merged pull request #87: Remove duplicate .gitignore lines

2021-01-25 Thread GitBox
slachiewicz merged pull request #87: URL: https://github.com/apache/maven-enforcer/pull/87 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-25 Thread Alexander Kriegisch (Jira)
Alexander Kriegisch created SUREFIRE-1882: - Summary: 3.0.0-M6-SNAPSHOT no longer working with Java 8 Key: SUREFIRE-1882 URL: https://issues.apache.org/jira/browse/SUREFIRE-1882 Project: Maven

[jira] [Updated] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-25 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kriegisch updated SUREFIRE-1882: -- Description: When running my build, I see {{[INFO] ---

[jira] [Updated] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-25 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kriegisch updated SUREFIRE-1882: -- Description: When running my build on JDK 8, I see {code} [INFO] ---

[jira] [Updated] (SUREFIRE-1882) 3.0.0-M6-SNAPSHOT no longer working with Java 8

2021-01-25 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kriegisch updated SUREFIRE-1882: -- Description: When running my build on JDK 8, I see {code} [INFO] ---

[jira] [Updated] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-01-25 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kriegisch updated SUREFIRE-1881: -- Description: This is a follow-up to SUREFIRE-1788 which was closed

[jira] [Updated] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

2021-01-25 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kriegisch updated SUREFIRE-1881: -- Description: This is a follow-up to SUREFIRE-1788 which was closed

[jira] [Commented] (SUREFIRE-1788) Unhandled native logs in SurefireForkChannel

2021-01-25 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271875#comment-17271875 ] Alexander Kriegisch commented on SUREFIRE-1788: --- I have created SUREFIRE-1881 including

  1   2   >