[jira] [Commented] (MRESOLVER-307) Support listing of workspace artifacts

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678535#comment-17678535 ] ASF GitHub Bot commented on MRESOLVER-307: -- cstamas commented on PR #230: URL:

[GitHub] [maven-resolver] cstamas commented on pull request #230: MRESOLVER-307 - Support listing of workspace artifacts

2023-01-18 Thread GitBox
cstamas commented on PR #230: URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1396567377 After reconsidering this change, I am -1 on it (now or 2.x), reasons: * I see no point of adding new methods to resolver interface that resolver itself is NOT going to use *

[GitHub] [maven] cstamas commented on pull request #913: MNG-7630 - Support listing of workspace models

2023-01-18 Thread GitBox
cstamas commented on PR #913: URL: https://github.com/apache/maven/pull/913#issuecomment-1396560239 Am fine with this go into 3.9 and not impose any change in resolver, and here is why: * there is already this MavenWorkspaceReader that already extends resolver WorkspaceReader by adding

[GitHub] [maven] cstamas commented on pull request #913: MNG-7630 - Support listing of workspace models

2023-01-18 Thread GitBox
cstamas commented on PR #913: URL: https://github.com/apache/maven/pull/913#issuecomment-1396562822 pls rebase against latest maven-3.9.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (MNG-7630) Support listing of workspace models and implement upcomming interface methods

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678533#comment-17678533 ] ASF GitHub Bot commented on MNG-7630: - cstamas commented on PR #913: URL:

[jira] [Commented] (MNG-7630) Support listing of workspace models and implement upcomming interface methods

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678528#comment-17678528 ] ASF GitHub Bot commented on MNG-7630: - cstamas commented on PR #913: URL:

[GitHub] [maven-compiler-plugin] cstamas commented on pull request #151: Move away from legacy maven-compat

2023-01-18 Thread GitBox
cstamas commented on PR #151: URL: https://github.com/apache/maven-compiler-plugin/pull/151#issuecomment-1396571932 Am fine if anyone (@psiroky ?) picks up these changes and continue with them (as there is no need for else branch for example), no need for any attribution, just go on with

[jira] [Assigned] (MENFORCER-460) Deprecate display-info mojo

2023-01-18 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MENFORCER-460: - Assignee: Slawomir Jaranowski > Deprecate display-info mojo >

[GitHub] [maven-mvnd] ppalaga commented on pull request #764: Fix core export provider

2023-01-18 Thread GitBox
ppalaga commented on PR #764: URL: https://github.com/apache/maven-mvnd/pull/764#issuecomment-1386681460 @oehme, BTW if you now send some dummy PR, it will publish the distribution zips for 3 (of 4, excl. Apple M1) supported platforms under Checks > Artifacts. You could perhaps use those

[GitHub] [maven] gnodet commented on pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on PR #954: URL: https://github.com/apache/maven/pull/954#issuecomment-1387205641 In the internal project local repository structure, I've added a child directory with the version of a given artifact. This gives a structure which is closer to the maven local repository,

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678282#comment-17678282 ] ASF GitHub Bot commented on MNG-7629: - cstamas commented on code in PR #954: URL:

[GitHub] [maven] cstamas commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
cstamas commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073658196 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven-mvnd] gnodet commented on issue #770: Threads parameter is not working on Apple Silicon

2023-01-18 Thread GitBox
gnodet commented on issue #770: URL: https://github.com/apache/maven-mvnd/issues/770#issuecomment-1387225150 Can you reproduce the issue ? Are you sure you don't have the `mvnd.threads` property set in [one of the configuration file](https://github.com/apache/maven-mvnd#configuration) ?

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678293#comment-17678293 ] ASF GitHub Bot commented on MNG-7629: - gnodet commented on code in PR #954: URL:

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073601881 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +309,130 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073602143 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -117,18 +105,19 @@ public File findArtifact(Artifact artifact) { } public List

[GitHub] [maven] cstamas commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
cstamas commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073670208 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073701518 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven-integration-testing] gnodet closed pull request #219: [MNG-7629] Add an IT

2023-01-18 Thread GitBox
gnodet closed pull request #219: [MNG-7629] Add an IT URL: https://github.com/apache/maven-integration-testing/pull/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven-mvnd] gnodet commented on a diff in pull request #717: Try native image then fallback to pure java version

2023-01-18 Thread GitBox
gnodet commented on code in PR #717: URL: https://github.com/apache/maven-mvnd/pull/717#discussion_r1073627453 ## dist/src/main/provisio/maven-distro.xml: ## @@ -97,6 +97,7 @@ mvnd mvnd.exe + Review Comment: What is the purpose of

[GitHub] [maven] cstamas commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
cstamas commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073654940 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] cstamas commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
cstamas commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073654940 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678319#comment-17678319 ] ASF GitHub Bot commented on MNG-7629: - gnodet commented on code in PR #954: URL:

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678253#comment-17678253 ] ASF GitHub Bot commented on MNG-7629: - gnodet commented on code in PR #954: URL:

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678254#comment-17678254 ] ASF GitHub Bot commented on MNG-7629: - gnodet commented on code in PR #954: URL:

[GitHub] [maven] gnodet commented on pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on PR #954: URL: https://github.com/apache/maven/pull/954#issuecomment-1387156322 > > > ... in order to be able to partially run mvn test. > > > > > > I'm not sure I understand. You mean "run `mvn test` on a multi-module project without requiring the user to have

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678280#comment-17678280 ] ASF GitHub Bot commented on MNG-7629: - cstamas commented on code in PR #954: URL:

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678281#comment-17678281 ] ASF GitHub Bot commented on MNG-7629: - cstamas commented on code in PR #954: URL:

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r107336 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] cstamas commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
cstamas commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073675245 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678290#comment-17678290 ] ASF GitHub Bot commented on MNG-7629: - cstamas commented on code in PR #954: URL:

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678258#comment-17678258 ] ASF GitHub Bot commented on MNG-7629: - gnodet commented on PR #954: URL:

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678273#comment-17678273 ] ASF GitHub Bot commented on MNG-7629: - gnodet commented on PR #954: URL:

[GitHub] [maven-mvnd] gzm55 commented on a diff in pull request #717: Try native image then fallback to pure java version

2023-01-18 Thread GitBox
gzm55 commented on code in PR #717: URL: https://github.com/apache/maven-mvnd/pull/717#discussion_r1073667250 ## dist/src/main/provisio/maven-distro.xml: ## @@ -97,6 +97,7 @@ mvnd mvnd.exe + Review Comment: the flag file is used

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678286#comment-17678286 ] ASF GitHub Bot commented on MNG-7629: - gnodet commented on code in PR #954: URL:

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073679949 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678296#comment-17678296 ] ASF GitHub Bot commented on MNG-7629: - cstamas commented on code in PR #954: URL:

[GitHub] [maven] cstamas commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
cstamas commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073687908 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073764622 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[jira] [Commented] (SUREFIRE-1812) Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class) are not reported

2023-01-18 Thread Jiri Ondrusek (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678246#comment-17678246 ] Jiri Ondrusek commented on SUREFIRE-1812: - [~tibordigana]  I verified the current state of the

[GitHub] [maven-mvnd] gnodet closed issue #762: Support for Maven 3.8.7?

2023-01-18 Thread GitBox
gnodet closed issue #762: Support for Maven 3.8.7? URL: https://github.com/apache/maven-mvnd/issues/762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678287#comment-17678287 ] ASF GitHub Bot commented on MNG-7629: - cstamas commented on code in PR #954: URL:

[jira] [Commented] (MNG-7629) Improve resolution of modules within a multi-module build

2023-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678299#comment-17678299 ] ASF GitHub Bot commented on MNG-7629: - gnodet commented on code in PR #954: URL:

[jira] [Commented] (MENFORCER-386) caching implementation

2023-01-18 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678341#comment-17678341 ] Slawomir Jaranowski commented on MENFORCER-386: --- Which rule do you mention in issue? >

[jira] [Updated] (MENFORCER-457) Bump assertj-core from 3.23.1 to 3.24.2

2023-01-18 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MENFORCER-457: -- Summary: Bump assertj-core from 3.23.1 to 3.24.2 (was: Bump assertj-core

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #235: [MENFORCER-457] Bump assertj-core from 3.24.1 to 3.24.2

2023-01-18 Thread GitBox
slawekjaranowski merged PR #235: URL: https://github.com/apache/maven-enforcer/pull/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (MARCHETYPES-75) Bump web archetype deployment descriptor to v4, portlet to v3

2023-01-18 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MARCHETYPES-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MARCHETYPES-75. -- Fix Version/s: 1.5 Assignee: Slawomir Jaranowski

[GitHub] [maven-archetypes] slawekjaranowski merged pull request #6: [MARCHETYPES-75] Bump web archetype deployment descriptor to v4, portlet to v3

2023-01-18 Thread GitBox
slawekjaranowski merged PR #6: URL: https://github.com/apache/maven-archetypes/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MENFORCER-413) Upgrading from 3.0.0-M3 to 3.0.0 causes strange errors about Spring Roo

2023-01-18 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678338#comment-17678338 ] Slawomir Jaranowski commented on MENFORCER-413: --- Can you provide a simple project which

[GitHub] [maven-compiler-plugin] ajarmoniuk commented on pull request #151: Move away from legacy maven-compat

2023-01-18 Thread GitBox
ajarmoniuk commented on PR #151: URL: https://github.com/apache/maven-compiler-plugin/pull/151#issuecomment-1387479684 Hey, I can do that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #237: [MENFORCER-460] Deprecate display-info mojo

2023-01-18 Thread GitBox
slawekjaranowski opened a new pull request, #237: URL: https://github.com/apache/maven-enforcer/pull/237 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER)

[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #151: Move away from legacy maven-compat

2023-01-18 Thread GitBox
psiroky commented on code in PR #151: URL: https://github.com/apache/maven-compiler-plugin/pull/151#discussion_r1080568677 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1841,29 +1838,36 @@ private List resolveProcessorPathEntries()

[GitHub] [maven-compiler-plugin] psiroky commented on pull request #151: Move away from legacy maven-compat

2023-01-18 Thread GitBox
psiroky commented on PR #151: URL: https://github.com/apache/maven-compiler-plugin/pull/151#issuecomment-1396108191 @cstamas @laeubi Hello! It would be great to get this one merged. Is there anything I can help with? It seems like getting rid of `AbstractMojoTestCase` might be

[jira] [Commented] (MENFORCER-386) caching implementation

2023-01-18 Thread Delany (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678389#comment-17678389 ] Delany commented on MENFORCER-386: -- I set lots of rules, but I especially want to avoid redoing

[jira] [Created] (MRELEASE-1112) Add a quick login to release repo early in the release process

2023-01-18 Thread Matt Pavlovich (Jira)
Matt Pavlovich created MRELEASE-1112: Summary: Add a quick login to release repo early in the release process Key: MRELEASE-1112 URL: https://issues.apache.org/jira/browse/MRELEASE-1112 Project: