Re: [PR] Batch update to plugin [maven-invoker-plugin]

2023-12-29 Thread via GitHub
slawekjaranowski commented on code in PR #207: URL: https://github.com/apache/maven-invoker-plugin/pull/207#discussion_r1438496545 ## pom.xml: ## @@ -62,12 +62,13 @@ under the License. 8 -3.2.5 +3.2.5 +3.9.6 Review Comment: I'm not still sure about

Re: [PR] Batch update to plugin [maven-invoker-plugin]

2023-12-29 Thread via GitHub
slawekjaranowski commented on code in PR #207: URL: https://github.com/apache/maven-invoker-plugin/pull/207#discussion_r1438493924 ## pom.xml: ## @@ -369,6 +389,16 @@ under the License. + +org.apache.maven.plugins +

[jira] [Commented] (MNG-7976) Investigate MNG-6127 IT instability

2023-12-29 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801159#comment-17801159 ] Tamas Cservenak commented on MNG-7976: -- The related IT regularly fails, seems like something is

[jira] [Commented] (MNG-7976) Investigate MNG-6127 IT instability

2023-12-29 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801160#comment-17801160 ] Tamas Cservenak commented on MNG-7976: -- Just look at CI history on master (gh)... > Investigate

[PR] Bump org.jsoup:jsoup from 1.15.3 to 1.17.2 [maven-dist-tool]

2023-12-29 Thread via GitHub
dependabot[bot] opened a new pull request, #48: URL: https://github.com/apache/maven-dist-tool/pull/48 Bumps [org.jsoup:jsoup](https://github.com/jhy/jsoup) from 1.15.3 to 1.17.2. Release notes Sourced from https://github.com/jhy/jsoup/releases;>org.jsoup:jsoup's releases.

Re: [PR] Bump org.jsoup:jsoup from 1.15.3 to 1.17.1 [maven-dist-tool]

2023-12-29 Thread via GitHub
dependabot[bot] closed pull request #39: Bump org.jsoup:jsoup from 1.15.3 to 1.17.1 URL: https://github.com/apache/maven-dist-tool/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump org.jsoup:jsoup from 1.15.3 to 1.17.1 [maven-dist-tool]

2023-12-29 Thread via GitHub
dependabot[bot] commented on PR #39: URL: https://github.com/apache/maven-dist-tool/pull/39#issuecomment-1872061053 Superseded by #48. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump com.google.guava:guava from 32.1.3-jre to 33.0.0-jre [maven-indexer]

2023-12-29 Thread via GitHub
cstamas commented on PR #349: URL: https://github.com/apache/maven-indexer/pull/349#issuecomment-1872076261 Am on hold with this one for now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Use @Component only [maven-dependency-plugin]

2023-12-29 Thread via GitHub
slawekjaranowski commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1872079561 Unit test pass. Site build due to parameters list can be null  -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter [maven-plugin-tools]

2023-12-29 Thread via GitHub
slawekjaranowski commented on PR #253: URL: https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1872082488 Parameter list can be null ... we also need a fix like: ```diff ---

[jira] [Commented] (MPLUGIN-495) WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801172#comment-17801172 ] ASF GitHub Bot commented on MPLUGIN-495: slawekjaranowski commented on PR #253: URL:

Re: [PR] ArtifactContext should not log warnings if artifacts are no zip files. [maven-indexer]

2023-12-29 Thread via GitHub
cstamas commented on code in PR #347: URL: https://github.com/apache/maven-indexer/pull/347#discussion_r1438260247 ## indexer-core/src/main/java/org/apache/maven/index/ArtifactContext.java: ## @@ -104,7 +107,11 @@ else if (getArtifact() != null && getArtifact().isFile()) {

[PR] Bump org.jsoup:jsoup from 1.17.1 to 1.17.2 [maven-plugin-tools]

2023-12-29 Thread via GitHub
dependabot[bot] opened a new pull request, #254: URL: https://github.com/apache/maven-plugin-tools/pull/254 Bumps [org.jsoup:jsoup](https://github.com/jhy/jsoup) from 1.17.1 to 1.17.2. Release notes Sourced from https://github.com/jhy/jsoup/releases;>org.jsoup:jsoup's releases.

[jira] [Created] (MINDEXER-212) Update jsoup to 1.17.2

2023-12-29 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MINDEXER-212: Summary: Update jsoup to 1.17.2 Key: MINDEXER-212 URL: https://issues.apache.org/jira/browse/MINDEXER-212 Project: Maven Indexer Issue Type:

[jira] [Created] (MINDEXER-213) Update Lucene to 9.9.1

2023-12-29 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MINDEXER-213: Summary: Update Lucene to 9.9.1 Key: MINDEXER-213 URL: https://issues.apache.org/jira/browse/MINDEXER-213 Project: Maven Indexer Issue Type:

[jira] [Created] (MINDEXER-214) ArtifactContext should not log warnings if artifact is not zip file

2023-12-29 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MINDEXER-214: Summary: ArtifactContext should not log warnings if artifact is not zip file Key: MINDEXER-214 URL: https://issues.apache.org/jira/browse/MINDEXER-214

[jira] [Updated] (MINDEXER-206) Search Backend SMO and RR handle different Artifact.extension

2023-12-29 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MINDEXER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MINDEXER-206: - Fix Version/s: 7.1.3 (was: 7.1.2) > Search Backend SMO and RR

[jira] [Closed] (MINDEXER-212) Update jsoup to 1.17.2

2023-12-29 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MINDEXER-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-212. Resolution: Fixed > Update jsoup to 1.17.2 > -- > >

Re: [PR] Bump org.jsoup:jsoup from 1.17.1 to 1.17.2 [maven-indexer]

2023-12-29 Thread via GitHub
cstamas merged PR #350: URL: https://github.com/apache/maven-indexer/pull/350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump lucene.version from 9.9.0 to 9.9.1 [maven-indexer]

2023-12-29 Thread via GitHub
cstamas merged PR #348: URL: https://github.com/apache/maven-indexer/pull/348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (MINDEXER-212) Update jsoup to 1.17.2

2023-12-29 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MINDEXER-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-212: Assignee: Tamas Cservenak > Update jsoup to 1.17.2 > -- > >

[jira] [Closed] (MINDEXER-213) Update Lucene to 9.9.1

2023-12-29 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MINDEXER-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-213. Resolution: Fixed > Update Lucene to 9.9.1 > -- > >

[jira] [Assigned] (MINDEXER-213) Update Lucene to 9.9.1

2023-12-29 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MINDEXER-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-213: Assignee: Tamas Cservenak > Update Lucene to 9.9.1 > -- > >

Re: [PR] ArtifactContext should not log warnings if artifacts are no zip files. [maven-indexer]

2023-12-29 Thread via GitHub
cstamas merged PR #347: URL: https://github.com/apache/maven-indexer/pull/347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (MINDEXER-214) ArtifactContext should not log warnings if artifact is not zip file

2023-12-29 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MINDEXER-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-214: Assignee: Tamas Cservenak > ArtifactContext should not log warnings if artifact

[jira] [Closed] (MINDEXER-214) ArtifactContext should not log warnings if artifact is not zip file

2023-12-29 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MINDEXER-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-214. Resolution: Fixed > ArtifactContext should not log warnings if artifact is not zip file

Re: [PR] Use @Component only [maven-dependency-plugin]

2023-12-29 Thread via GitHub
michael-o commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1871955789 > Unit tests still fail for me But executing ITs are ok ... Yes, that's the point. A misconfig or dep is missing. -- This is an automated message from the

[jira] [Commented] (MPLUGIN-495) WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801135#comment-17801135 ] ASF GitHub Bot commented on MPLUGIN-495: slawekjaranowski commented on PR #253: URL:

Re: [PR] [MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter [maven-plugin-tools]

2023-12-29 Thread via GitHub
slawekjaranowski commented on PR #253: URL: https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871963058 https://github.com/apache/maven-dependency-plugin/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter [maven-plugin-tools]

2023-12-29 Thread via GitHub
slawekjaranowski commented on PR #253: URL: https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871962667 > > hm, nope, i assumed this PR fails to build > > It works, but not the subsequent use in tests. ITs do work, actually. So I guessed that some dep is

[jira] [Commented] (MPLUGIN-495) WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801137#comment-17801137 ] ASF GitHub Bot commented on MPLUGIN-495: slawekjaranowski commented on PR #253: URL:

Re: [PR] Use @Component only [maven-dependency-plugin]

2023-12-29 Thread via GitHub
slawekjaranowski commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1871964145 @michael-o @cstamas please look at my commit ... I fix one test by adding mock MavenProject and MavenSession as component in test -- This is an automated

[PR] Use @Component only [maven-dependency-plugin]

2023-12-29 Thread via GitHub
michael-o opened a new pull request, #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360 This should depict the failing behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-29 Thread via GitHub
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1871876782 > If I understand correctly, I'll remove here dependency to Xerces and then wait until it will not be needed by Doxia core. I cannot see where Doxia Core uses

[jira] [Commented] (DOXIASITETOOLS-321) Upgrade htmlunit 2.x to 3.9

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801122#comment-17801122 ] ASF GitHub Bot commented on DOXIASITETOOLS-321: --- michael-o commented on PR #124:

Re: [PR] Use @Component only [maven-dependency-plugin]

2023-12-29 Thread via GitHub
slawekjaranowski commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1871946562 Unit tests still fail for me But executing ITs are ok ... -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter [maven-plugin-tools]

2023-12-29 Thread via GitHub
slawekjaranowski commented on PR #253: URL: https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871973607 We can remove `org.apache.maven.tools.plugin.util.PluginUtils#MAVEN_COMPONENTS` -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (MPLUGIN-495) WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801144#comment-17801144 ] ASF GitHub Bot commented on MPLUGIN-495: slawekjaranowski commented on PR #253: URL:

[jira] [Resolved] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink

2023-12-29 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved DOXIA-715. --- Fix Version/s: 2.0.0 2.0.0-M9 Resolution: Fixed Fixed in

[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801252#comment-17801252 ] ASF GitHub Bot commented on DOXIA-714: -- michael-o commented on code in PR #185: URL:

Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]

2023-12-29 Thread via GitHub
michael-o commented on code in PR #185: URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438393908 ## doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java: ## @@ -45,12 +48,9 @@ public class MarkdownSink

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-29 Thread via GitHub
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1872333258 @slachiewicz I have added a temporary fix. This requires https://github.com/apache/maven-doxia/pull/187 to be merged first. -- This is an automated message from the

[jira] [Commented] (MPMD-379) Support PMD 7.0.0

2023-12-29 Thread Charles Honton (Jira)
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801261#comment-17801261 ] Charles Honton commented on MPMD-379: - [PMD

[jira] [Commented] (DOXIASITETOOLS-321) Upgrade htmlunit 2.x to 3.9

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801262#comment-17801262 ] ASF GitHub Bot commented on DOXIASITETOOLS-321: --- michael-o commented on PR #124:

Re: [PR] [MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter [maven-plugin-tools]

2023-12-29 Thread via GitHub
michael-o commented on PR #253: URL: https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1872263806 > Parameter list can be null ... we also need a fix like: > > ```diff > ---

[jira] [Commented] (MPLUGIN-495) WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801239#comment-17801239 ] ASF GitHub Bot commented on MPLUGIN-495: michael-o commented on PR #253: URL:

[jira] [Commented] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801240#comment-17801240 ] ASF GitHub Bot commented on DOXIA-715: -- kwin opened a new pull request, #186: URL:

Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]

2023-12-29 Thread via GitHub
kwin commented on code in PR #185: URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438369940 ## doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java: ## @@ -817,6 +820,9 @@ public void text(String text, SinkEventAttributes

Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]

2023-12-29 Thread via GitHub
kwin commented on code in PR #185: URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438391211 ## doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java: ## @@ -45,12 +48,9 @@ public class MarkdownSink extends

[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801249#comment-17801249 ] ASF GitHub Bot commented on DOXIA-714: -- kwin commented on code in PR #185: URL:

[PR] Bump org.jsoup:jsoup from 1.17.1 to 1.17.2 [maven-dependency-plugin]

2023-12-29 Thread via GitHub
dependabot[bot] opened a new pull request, #361: URL: https://github.com/apache/maven-dependency-plugin/pull/361 Bumps [org.jsoup:jsoup](https://github.com/jhy/jsoup) from 1.17.1 to 1.17.2. Release notes Sourced from https://github.com/jhy/jsoup/releases;>org.jsoup:jsoup's

[jira] [Commented] (DOXIASITETOOLS-321) Upgrade htmlunit 2.x to 3.9

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801231#comment-17801231 ] ASF GitHub Bot commented on DOXIASITETOOLS-321: --- michael-o commented on PR #124:

[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801237#comment-17801237 ] ASF GitHub Bot commented on DOXIA-714: -- michael-o commented on code in PR #185: URL:

[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801236#comment-17801236 ] ASF GitHub Bot commented on DOXIA-714: -- michael-o commented on code in PR #185: URL:

Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]

2023-12-29 Thread via GitHub
michael-o commented on code in PR #185: URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438360834 ## doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java: ## @@ -208,6 +208,19 @@ protected String

Re: [PR] Use @Component only [maven-dependency-plugin]

2023-12-29 Thread via GitHub
michael-o commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1872256364 @slawekjaranowski This is fantastic work, **thank you**. Your change must go with the upgrade of MPLUGIN with every modified plugin as well as this one. -- This is an

Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]

2023-12-29 Thread via GitHub
kwin commented on code in PR #185: URL: https://github.com/apache/maven-doxia/pull/185#discussion_r143838 ## doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java: ## @@ -644,10 +645,65 @@ public void testTable() { if (isXmlSink()) {

[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801232#comment-17801232 ] ASF GitHub Bot commented on DOXIA-714: -- kwin commented on code in PR #185: URL:

Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]

2023-12-29 Thread via GitHub
kwin commented on code in PR #185: URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438355892 ## doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java: ## @@ -817,6 +820,9 @@ public void text(String text, SinkEventAttributes

[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801233#comment-17801233 ] ASF GitHub Bot commented on DOXIA-714: -- kwin commented on code in PR #185: URL:

[jira] [Created] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink

2023-12-29 Thread Konrad Windszus (Jira)
Konrad Windszus created DOXIA-715: - Summary: Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink Key: DOXIA-715 URL: https://issues.apache.org/jira/browse/DOXIA-715

Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]

2023-12-29 Thread via GitHub
michael-o commented on code in PR #185: URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438352084 ## doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java: ## @@ -644,10 +645,65 @@ public void testTable() { if (isXmlSink()) {

[jira] [Updated] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink

2023-12-29 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated DOXIA-715: -- Affects Version/s: 2.0.0-M8 (was: 2.0.0-M7) > Sink.text(String,

[jira] [Updated] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink

2023-12-29 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated DOXIA-715: -- Description: All attributes passed as second argument to {{Sink.text(String,

[jira] [Updated] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink

2023-12-29 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated DOXIA-715: -- Fix Version/s: (was: 2.0.0-M8) (was: 2.0.0) > Sink.text(String,

Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]

2023-12-29 Thread via GitHub
michael-o commented on code in PR #185: URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438360736 ## doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java: ## @@ -817,6 +820,9 @@ public void text(String text,

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-29 Thread via GitHub
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1872244289 Checking... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801230#comment-17801230 ] ASF GitHub Bot commented on DOXIA-714: -- michael-o commented on code in PR #185: URL:

[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801234#comment-17801234 ] ASF GitHub Bot commented on DOXIA-714: -- kwin commented on code in PR #185: URL:

Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]

2023-12-29 Thread via GitHub
kwin commented on code in PR #185: URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438356143 ## doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java: ## @@ -208,6 +208,19 @@ protected String getTableBlock(String

[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801241#comment-17801241 ] ASF GitHub Bot commented on DOXIA-714: -- kwin commented on code in PR #185: URL:

[jira] [Commented] (DOXIA-716) Update and unify XMLReader creation and configuration

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801259#comment-17801259 ] ASF GitHub Bot commented on DOXIA-716: -- michael-o opened a new pull request, #187: URL:

[jira] [Closed] (MRESOLVER-458) Update to Maven 4.0.0-alpha-10

2023-12-29 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-458. - Resolution: Fixed > Update to Maven 4.0.0-alpha-10 > -- >

[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801192#comment-17801192 ] ASF GitHub Bot commented on DOXIA-714: -- kwin opened a new pull request, #185: URL:

[jira] [Commented] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801247#comment-17801247 ] ASF GitHub Bot commented on DOXIA-715: -- kwin merged PR #186: URL:

Re: [PR] [DOXIA-715] Consider attributes for text(...) in AptSink and [maven-doxia]

2023-12-29 Thread via GitHub
kwin merged PR #186: URL: https://github.com/apache/maven-doxia/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DOXIA-699] Add failing test case [maven-doxia]

2023-12-29 Thread via GitHub
kwin closed pull request #152: [DOXIA-699] Add failing test case URL: https://github.com/apache/maven-doxia/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [DOXIA-699] Add failing test case [maven-doxia]

2023-12-29 Thread via GitHub
kwin commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1872305375 Superseded by #162. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_() when using both and

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801251#comment-17801251 ] ASF GitHub Bot commented on DOXIA-699: -- kwin commented on PR #152: URL:

[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_() when using both and

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801250#comment-17801250 ] ASF GitHub Bot commented on DOXIA-699: -- kwin closed pull request #152: [DOXIA-699] Add failing test

[jira] [Updated] (DOXIA-716) Update and unify XMLReader creation and configuration

2023-12-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-716: - Summary: Update and unify XMLReader creation and configuration (was: Update and unify XMLReader

[jira] [Created] (DOXIA-716) Update and unify XMLReader creation/configuration

2023-12-29 Thread Michael Osipov (Jira)
Michael Osipov created DOXIA-716: Summary: Update and unify XMLReader creation/configuration Key: DOXIA-716 URL: https://issues.apache.org/jira/browse/DOXIA-716 Project: Maven Doxia Issue

[jira] [Commented] (MRESOLVER-458) Update to Maven 4.0.0-alpha-10

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801266#comment-17801266 ] ASF GitHub Bot commented on MRESOLVER-458: -- cstamas merged PR #399: URL:

Re: [PR] [MRESOLVER-458] Update to Maven 4.0.0-alpha-10 [maven-resolver]

2023-12-29 Thread via GitHub
cstamas merged PR #399: URL: https://github.com/apache/maven-resolver/pull/399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Extend info about cleanups after retirement [maven-site]

2023-12-29 Thread via GitHub
slawekjaranowski opened a new pull request, #481: URL: https://github.com/apache/maven-site/pull/481 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-29 Thread via GitHub
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1872274339 Doxia is broken: `xmlReader = XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");` Let me fix/evaluate this before we continue... -- This is

[jira] [Commented] (DOXIASITETOOLS-321) Upgrade htmlunit 2.x to 3.9

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801242#comment-17801242 ] ASF GitHub Bot commented on DOXIASITETOOLS-321: --- michael-o commented on PR #124:

[jira] [Resolved] (DOXIA-714) MarkdownSink: Fix table justification and figures

2023-12-29 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved DOXIA-714. --- Fix Version/s: 2.0.0 2.0.0-M9 Resolution: Fixed Fixed in

Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]

2023-12-29 Thread via GitHub
kwin merged PR #185: URL: https://github.com/apache/maven-doxia/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures

2023-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801253#comment-17801253 ] ASF GitHub Bot commented on DOXIA-714: -- kwin merged PR #185: URL: