Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
Not at this moment. Perhaps the weekend.
---
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@Tibor17 It appears this branch is still up to date with master.
Is the removal of the class the problem or the underlying fundamentals? If
it is just the removal I can restore
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> How is Description constructed now by Cucumber?
Executing cucumber while using JUnit creates a tree of Descriptions like so:
```
Cucumber
|- Featur
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> Additionally, can you write a separate documentation file cucumber.apt.vm
for Cucumber with your best practices to setup and use cucumber in terms of
maven-surefire-plugin and ma
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@Tibor17 please let me know if you have more questions.
---
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
I haven't answered yet is why cucumber creates descriptions with a unique
Id and doesn't just use the method names.
The reason for that is that scenarios in cucumber don't need
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> Why you have chosen provider surefire-junit47 and not also the
surefire-junit4?
While it would be possible to change surefire-junit4 to filter by
description there is no n
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
You're welcome!
---
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
Merged in 0a81c48971e3ee4b79b0858be7b8f4b13ece7287.
---
Github user mpkorstanje closed the pull request at:
https://github.com/apache/maven-surefire/pull/150
---
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> Then try to alter the behavior of the integration test with Maven profile
(junit4 and junit47). We are already doing it, see addGoal( "-P junit4" ),
addGoal
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@Tibor17
`MatchDescriptions` uses `Filter.matchMethodDescription` which does not
exist in junit4. It would make the junit 4 version of `MatchDescriptions`
divergent enough
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> Can you write the documentation?
Done.
>Fix the checkstyle in your integration test and the classes
FlakeCucumberTest.
I seem to be unable to get chec
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@Tibor17 that should be doable. Replacing the inner most loop in the
`JUnit4Provider.executeWithRerun` with the code below should do it. This would
require the `FilterFactory
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> The build passed successfully. I will refactor little details, I will
squash our commits and then I will push it to master.
Cheers.
> I could not find a documen
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
Bit hard to say without the full stack trace, components and version
numbers involved.
To fix this bug I also had to fix cucumber to ensure that the it provided
the proper ids
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
In that case yes, you only need to wait for the release of surefire.
https://github.com/cucumber/cucumber-jvm/issues/1120 was fixed by
https://github.com/cucumber/cucumber-jvm/pull/1134
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
The path:
```
F:\jenkins\jenkins-slave\workspace\fire-pipeline_SUREFIRE-1463-5KZ5VLS45OW347227XHB7NPF5FLJFXODCMZF4ZDVYJEJZVION6UQ\build\surefire-integration-tests\target
18 matches
Mail list logo