[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-19 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 Not at this moment. Perhaps the weekend. ---

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-08 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 @Tibor17 It appears this branch is still up to date with master. Is the removal of the class the problem or the underlying fundamentals? If it is just the removal I can restore

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-10 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 > How is Description constructed now by Cucumber? Executing cucumber while using JUnit creates a tree of Descriptions like so: ``` Cucumber |- Featur

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-10 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 > Additionally, can you write a separate documentation file cucumber.apt.vm for Cucumber with your best practices to setup and use cucumber in terms of maven-surefire-plugin and ma

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-10 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 @Tibor17 please let me know if you have more questions. ---

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-10 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 I haven't answered yet is why cucumber creates descriptions with a unique Id and doesn't just use the method names. The reason for that is that scenarios in cucumber don't need

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-10 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 > Why you have chosen provider surefire-junit47 and not also the surefire-junit4? While it would be possible to change surefire-junit4 to filter by description there is no n

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2018-01-04 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 You're welcome! ---

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2018-01-04 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 Merged in 0a81c48971e3ee4b79b0858be7b8f4b13ece7287. ---

[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...

2018-01-04 Thread mpkorstanje
Github user mpkorstanje closed the pull request at: https://github.com/apache/maven-surefire/pull/150 ---

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-23 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 > Then try to alter the behavior of the integration test with Maven profile (junit4 and junit47). We are already doing it, see addGoal( "-P junit4" ), addGoal

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-23 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 @Tibor17 `MatchDescriptions` uses `Filter.matchMethodDescription` which does not exist in junit4. It would make the junit 4 version of `MatchDescriptions` divergent enough

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-23 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 > Can you write the documentation? Done. >Fix the checkstyle in your integration test and the classes FlakeCucumberTest. I seem to be unable to get chec

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-23 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 @Tibor17 that should be doable. Replacing the inner most loop in the `JUnit4Provider.executeWithRerun` with the code below should do it. This would require the `FilterFactory

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2017-12-24 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 > The build passed successfully. I will refactor little details, I will squash our commits and then I will push it to master. Cheers. > I could not find a documen

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2018-02-02 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 Bit hard to say without the full stack trace, components and version numbers involved. To fix this bug I also had to fix cucumber to ensure that the it provided the proper ids

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2018-02-02 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 In that case yes, you only need to wait for the release of surefire. https://github.com/cucumber/cucumber-jvm/issues/1120 was fixed by https://github.com/cucumber/cucumber-jvm/pull/1134

[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...

2018-02-04 Thread mpkorstanje
Github user mpkorstanje commented on the issue: https://github.com/apache/maven-surefire/pull/150 The path: ``` F:\jenkins\jenkins-slave\workspace\fire-pipeline_SUREFIRE-1463-5KZ5VLS45OW347227XHB7NPF5FLJFXODCMZF4ZDVYJEJZVION6UQ\build\surefire-integration-tests\target