[GitHub] [maven-doxia] michael-o commented on a diff in pull request #116: [DOXIA-670] Remove code duplication in XdocSink
michael-o commented on code in PR #116:
URL: https://github.com/apache/maven-doxia/pull/116#discussion_r985129510
##
doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc/XdocSink.java:
##
@@ -505,31 +497,6 @@ public void close()
init();
}
-/**
- * Adds a link with an optional target.
- *
- * @param name the link name.
- * @param target the link target, may be null.
- */
-public void link( String name, String target )
-{
-if ( isHeadFlag() )
-{
-return;
-}
-
-MutableAttributeSet att = new SinkEventAttributeSet();
-
-att.addAttribute( Attribute.HREF, HtmlTools.escapeHTML( name ) );
-
-if ( target != null )
-{
-att.addAttribute( Attribute.TARGET, target );
-}
-
-writeStartTag( A, att );
-}
-
Review Comment:
@hboutemy Done, completely reduced. Attributes are in another ticket. As for
the `source`. HTML5 has now a source element which collides with Xdoc's source.
That is why I decided not to fiddle with at the moment. Forget about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-doxia] michael-o commented on a diff in pull request #116: [DOXIA-670] Remove code duplication in XdocSink
michael-o commented on code in PR #116:
URL: https://github.com/apache/maven-doxia/pull/116#discussion_r939155456
##
doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc/XdocSink.java:
##
@@ -382,119 +377,6 @@ else if ( depth == SECTION_LEVEL_5 )
//
// ---
-/**
- * {@inheritDoc}
- *
- * @see XdocMarkup#SOURCE_TAG
- * @see javax.swing.text.html.HTML.Tag#PRE
- * @param attributes a {@link
org.apache.maven.doxia.sink.SinkEventAttributes} object.
- */
-public void verbatim( SinkEventAttributes attributes )
-{
Review Comment:
I think this statement is nonsense and this method needs to be retained:
* Xdoc uses element of HTML5, but is not HTML5
* When XdocParser writes to a sink that sink will never see ``
anymore.
We have here a mix of custom elements and HTML5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-doxia] michael-o commented on a diff in pull request #116: [DOXIA-670] Remove code duplication in XdocSink
michael-o commented on code in PR #116:
URL: https://github.com/apache/maven-doxia/pull/116#discussion_r939037143
##
doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc/XdocSink.java:
##
@@ -382,119 +377,6 @@ else if ( depth == SECTION_LEVEL_5 )
//
// ---
-/**
- * {@inheritDoc}
- *
- * @see XdocMarkup#SOURCE_TAG
- * @see javax.swing.text.html.HTML.Tag#PRE
- * @param attributes a {@link
org.apache.maven.doxia.sink.SinkEventAttributes} object.
- */
-public void verbatim( SinkEventAttributes attributes )
-{
Review Comment:
I don't have a better idea how to make it proper, but it is definitively
broken with XHML5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
