[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

Tibor17 edited a comment on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-633546412 @rfscholte In my local test the JUnit4 is on modulepath. JUnit 4.13 is an automatic module. I've observed `java.lang.NoClassDefFoundError: org/junit/runner/n

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

Tibor17 edited a comment on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-633546412 @rfscholte In my local test the JUnit4 is on modulepath. JUnit 4.13 is an automatic module. I've observed `java.lang.NoClassDefFoundError: org/junit/runner/n

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

Tibor17 edited a comment on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-633127002 @cowwoc Do you have some spare time to develop a project with JUnit4 and TestNG on the top of this PR? I want to know what CLI arguments should be added for th

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

Tibor17 edited a comment on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-632440376 @rmannibucau I have a backup of your commit. Thx for the work, now this is the MP and CP. The test is successful. ``` --module-path "com.foo.impl/target

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

Tibor17 edited a comment on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-630040366 I have got the prototype working but the real surefire forked jvm failed due to we have same Java packages (e.g. `org.apache.maven.surefire.booter`) in `surefire-api

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

Tibor17 edited a comment on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-630040366 I have got the prototype working but the real surefire forked jvm failed due to we have same Java packages (e.g. org.apache.maven.surefire.booter) in `surefire-api`,

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

Tibor17 edited a comment on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-629624526 @cowwoc @sormuras We need to answer the following question quite fast. Currently this is the Java arg file we generate by the plugin in order the `src/

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

Tibor17 edited a comment on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-628492821 @cowwoc There are two remarks. 1. see my [comments](https://github.com/cowwoc/maven-surefire/commit/7861582df7aa7e18dff32066d01dfa439387f78a) 2. the syst

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

Tibor17 edited a comment on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-628492821 @Tibor17 There are two remarks. 1. see my [comments](https://github.com/cowwoc/maven-surefire/commit/7861582df7aa7e18dff32066d01dfa439387f78a) 2. the sy