[GitHub] [maven-surefire] cowwoc commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-24 Thread GitBox
cowwoc commented on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-633390828 @Tibor17 Do you have an existing integration test for JUnit4 + JPMS or TestNG + JPMS that is currently failing that you want fixed? Or do you want me to add those

[GitHub] [maven-surefire] cowwoc commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-20 Thread GitBox
cowwoc commented on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-631877603 @Tibor17 https://github.com/apache/maven-surefire/pull/299 is now ready for your review. This is an

[GitHub] [maven-surefire] cowwoc commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-20 Thread GitBox
cowwoc commented on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-631622526 @Tibor17 FYI, I am still working on this (albeit slowly). I just wanted to let you know I found an unrelated bug in the project. * In the root project, we have

[GitHub] [maven-surefire] cowwoc commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-13 Thread GitBox
cowwoc commented on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-628312834 @Tibor17 I'm a bit stuck. Can you please check out https://github.com/cowwoc/maven-surefire/tree/surefire-1629 and let me know why `mvn install -P run-its