[GitHub] [maven-surefire] cowwoc commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-24 Thread GitBox 


cowwoc commented on pull request #293:
URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-633390828


   @Tibor17 Do you have an existing integration test for JUnit4 + JPMS or 
TestNG + JPMS that is currently failing that you want fixed? Or do you want me 
to add those integration tests as well?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] cowwoc commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-20 Thread GitBox 


cowwoc commented on pull request #293:
URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-631877603


   @Tibor17 https://github.com/apache/maven-surefire/pull/299 is now ready for 
your review.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] cowwoc commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-20 Thread GitBox 


cowwoc commented on pull request #293:
URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-631622526


   @Tibor17 FYI, I am still working on this (albeit slowly). I just wanted to 
let you know I found an unrelated bug in the project.
   
   * In the root project, we have `jvm.args.tests` which contains `-Xms128m 
-Xmx144m`.
   * In the surefire-its project, we have a `maven-failsafe-plugin` plugin 
declaration with `argLine` containing `-Xmx64m`.
   
   If you run integration tests in IDEA, it runs the JVM using `-Xms128m 
-Xmx144m -Xmx64m`. The JDK then shuts down complaining that the initial heap 
size (128m) is greater than the maximum (64m).
   
   I suggest removing `-Xmx64m` from the surefire-its project. Makes sense?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] cowwoc commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-13 Thread GitBox 


cowwoc commented on pull request #293:
URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-628312834


   @Tibor17 I'm a bit stuck. Can you please check out 
https://github.com/cowwoc/maven-surefire/tree/surefire-1629 and let me know why 
`mvn install -P run-its -Dinvoker.test=Surefire1629* -Dmaven.test.skip verify` 
does not trigger the surefire-1629 test I've added?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org