[GitHub] Tibor17 commented on a change in pull request #138: SUREFIRE-1309: Clarifying use of regular expressions for inclusion/exclusion
Tibor17 commented on a change in pull request #138: SUREFIRE-1309: Clarifying
use of regular expressions for inclusion/exclusion
URL: https://github.com/apache/maven-surefire/pull/138#discussion_r233024399
##
File path:
maven-surefire-plugin/src/site/apt/examples/inclusion-exclusion.apt.vm
##
@@ -164,7 +164,16 @@ Inclusions and Exclusions of Tests
+---+
Note the syntax <<<%regex[expr]>>>, where <<>> is the actual
expression and the rest is just wrapping. Also
- note that regex matches are done over <<<*.class>>> files and not
<<<*.java>>> files.
+ note the following about the use of regular expressions:
+
+ * Regex matches are done over <<<*.class>>> files and not <<<*.java>>> files
+
+ * Regex matches are done over paths using slashes ("<<>>") and not
package names using dots ("<<<.>>>"), so the
+ "<<<.>>>" in <<>> is a regex metacharacter, which
happens to match any character, notably
+ the (forward) slashes ("<<>>") that make up the path. Slashes here
are , even on Windows
Review comment:
@bturner
You can track the progress in
[SUREFIRE-1292](https://issues.apache.org/jira/browse/SUREFIRE-1292) and
[SUREFIRE-526](https://issues.apache.org/jira/browse/SUREFIRE-526).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Tibor17 commented on a change in pull request #138: SUREFIRE-1309: Clarifying use of regular expressions for inclusion/exclusion
Tibor17 commented on a change in pull request #138: SUREFIRE-1309: Clarifying
use of regular expressions for inclusion/exclusion
URL: https://github.com/apache/maven-surefire/pull/138#discussion_r233009914
##
File path:
maven-surefire-plugin/src/site/apt/examples/inclusion-exclusion.apt.vm
##
@@ -164,7 +164,16 @@ Inclusions and Exclusions of Tests
+---+
Note the syntax <<<%regex[expr]>>>, where <<>> is the actual
expression and the rest is just wrapping. Also
- note that regex matches are done over <<<*.class>>> files and not
<<<*.java>>> files.
+ note the following about the use of regular expressions:
+
+ * Regex matches are done over <<<*.class>>> files and not <<<*.java>>> files
+
+ * Regex matches are done over paths using slashes ("<<>>") and not
package names using dots ("<<<.>>>"), so the
+ "<<<.>>>" in <<>> is a regex metacharacter, which
happens to match any character, notably
+ the (forward) slashes ("<<>>") that make up the path. Slashes here
are , even on Windows
Review comment:
@bturner
It will run the same as before except having slashes and `.class` nor
`.java`.
We have a huge number of unit and integration tests. So. We try to pass them
successfully.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Tibor17 commented on a change in pull request #138: SUREFIRE-1309: Clarifying use of regular expressions for inclusion/exclusion
Tibor17 commented on a change in pull request #138: SUREFIRE-1309: Clarifying
use of regular expressions for inclusion/exclusion
URL: https://github.com/apache/maven-surefire/pull/138#discussion_r233009914
##
File path:
maven-surefire-plugin/src/site/apt/examples/inclusion-exclusion.apt.vm
##
@@ -164,7 +164,16 @@ Inclusions and Exclusions of Tests
+---+
Note the syntax <<<%regex[expr]>>>, where <<>> is the actual
expression and the rest is just wrapping. Also
- note that regex matches are done over <<<*.class>>> files and not
<<<*.java>>> files.
+ note the following about the use of regular expressions:
+
+ * Regex matches are done over <<<*.class>>> files and not <<<*.java>>> files
+
+ * Regex matches are done over paths using slashes ("<<>>") and not
package names using dots ("<<<.>>>"), so the
+ "<<<.>>>" in <<>> is a regex metacharacter, which
happens to match any character, notably
+ the (forward) slashes ("<<>>") that make up the path. Slashes here
are , even on Windows
Review comment:
@bturner
It will run the same as before except that there would not be slashes and
`.class` nor `.java`.
We have a huge number of unit and integration tests. So. We try to pass them
successfully.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Tibor17 commented on a change in pull request #138: SUREFIRE-1309: Clarifying use of regular expressions for inclusion/exclusion
Tibor17 commented on a change in pull request #138: SUREFIRE-1309: Clarifying
use of regular expressions for inclusion/exclusion
URL: https://github.com/apache/maven-surefire/pull/138#discussion_r232911709
##
File path:
maven-surefire-plugin/src/site/apt/examples/inclusion-exclusion.apt.vm
##
@@ -164,7 +164,16 @@ Inclusions and Exclusions of Tests
+---+
Note the syntax <<<%regex[expr]>>>, where <<>> is the actual
expression and the rest is just wrapping. Also
- note that regex matches are done over <<<*.class>>> files and not
<<<*.java>>> files.
+ note the following about the use of regular expressions:
+
+ * Regex matches are done over <<<*.class>>> files and not <<<*.java>>> files
+
+ * Regex matches are done over paths using slashes ("<<>>") and not
package names using dots ("<<<.>>>"), so the
+ "<<<.>>>" in <<>> is a regex metacharacter, which
happens to match any character, notably
+ the (forward) slashes ("<<>>") that make up the path. Slashes here
are , even on Windows
Review comment:
We have a plan to discontinue this old format in Version `3.0.0` and use
only `fully qualified class name` w/o regex. It does not make sense to maintain
current feature. It is complicated since we have to use the filter twice, on
file system and then in JUnit/TestNG f/w. In the future all paths will be just
classes (with dot `.`) and then the filter would work on file systems and test
frameworks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
