[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-436784820 @jglick You do not have to investigate on Windows. We were talking about it here because Windows has typically many disks and anyway the `surefirebooter.jar` is stored on Windows TEMP. Therefore you have to specify the system property `-Djdk.net.URLClassPath.disableClassPathURLCheck=true` for Windows. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-436656371 @jglick This decision must be bullet proof. If we want to go this way, we have to run a branch with this prototype on Jenkins using multiple JDKs. Since we do not have Mac somebody has to test it locally. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-436602084 @cstamas @jglick @mirabilos @rockysingh Version `3.0.0-M1` is on Maven Central now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435657984 @cstamas Thx for contributing. Pls close this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435585356 Feedback for everybody. We are on the Slack ASF chat with @cstamas and we are fixing and testing old ITs one by one and the changes are being pushed to the branch "buildfix" on Surefire project, and @cstamas has his own branch, so we cooperate. Pls be patient while we are working on current issues. Thx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435569639 @cstamas I have fixed that problem. My bad, the reportsDir should be passed via method and not constructor to the ForkedCnfig because the dir is parameterized and it can be resolved only via the method. Can I fix it in master now and finish the release? The ITs failed because they expected only one dump file and tried to search a text in all of them but of course the second dump does not have expected text to assert. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435438509 The problem is that `TEST-TestSuite.xml` appears in wrong folder and it should be in `target/surefire-reports-1` and 2. Not sure how this change could influence the reports dir and resolution of it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435436625
@cstamas
I think nobody run the ITs on this PR. The problem is that we broke the
build with this fix.
There are two failing ITs.
The first one `Surefire141PluggableProvidersIT` can be fixed easily if we
comment the dump logger. The test got two dump files and it expects one, which
is the error. Or fix it in the IT would not be a problem.
The second is bad `Surefire1535TestNGParallelSuitesIT`and I do not
understand it. So, please help.
See this dump file
`surefire-its\target\Surefire1535TestNGParallelSuitesIT_forks2Redirected\target\surefire-reports-${surefire.forkNumber}\2018-11-02T17-13-42_917.dump`
# Created at 2018-11-02T17:13:43.787
Boot Manifest-JAR contains absolute paths in classpath
D:\.m2\repository\org\apache\maven\surefire\surefire-api\3.0.0-M2-SNAPSHOT\surefire-api-3.0.0-M2-SNAPSHOT.jar
java.lang.IllegalArgumentException: 'other' has different root
at sun.nio.fs.WindowsPath.relativize(WindowsPath.java:392)
at sun.nio.fs.WindowsPath.relativize(WindowsPath.java:44)
at
org.apache.maven.plugin.surefire.booterclient.JarManifestForkConfiguration.toClasspathElementUri(JarManifestForkConfiguration.java:147)
at
org.apache.maven.plugin.surefire.booterclient.JarManifestForkConfiguration.createJar(JarManifestForkConfiguration.java:117)
at
org.apache.maven.plugin.surefire.booterclient.JarManifestForkConfiguration.resolveClasspath(JarManifestForkConfiguration.java:73)
at
org.apache.maven.plugin.surefire.booterclient.DefaultForkConfiguration.createCommandLine(DefaultForkConfiguration.java:143)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:579)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$600(ForkStarter.java:115)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:444)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:420)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
I am inhurry with other appointments. Feel free to investigate. If you want
to fix it, feel free, but please run the `mvn install -P run-its` and then make
a commit to master or better a branch.
I do not understand this stack trace. I hope you know what is going on.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435419279 @mirabilos I understand, but MRESOURCES-237 is a problem of symbolic links in maven-resources-plugin. Nothing to do with us in my understanding. Do not worry, we are running 1400 tests on multiple platforms, so the likelihood should not be high. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435405583 @mirabilos You can check it out now from our staging repo https://repository.apache.org/content/repositories/maven-1463. See the guide to testing staged releases http://maven.apache.org/guides/development/guide-testing-releases.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435397200 @mirabilos It will take 3 days or longer. Sorry, this is the process of Vote for the release. So you are welcome to join our mailing list and Vote there for this release. I understand how urgent it is for you but this is not my decision that you will wait till next week. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435394570 @cstamas It's in master. The log dump was added too. I will cut the release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435386856 @cstamas I have already done it in my working copy. Is it necessary to log it? I removed the log because of what i wrote. But I can accept any of your decision of course. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435384927 ok, I am just running a local build and I will push it to master in few minutes only and then I will start the release Vote. Hoping this helps. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435381394 Are there any objections if I proceed with pushing the fix to master? Can somebody run a test? @mirabilos We are not waiting for 3.0. It is already in master. It is not a blocker. We are updating all Maven plugins to 3.0 because we have to and there there is no problem to accept it. We did not break your build. It was change of behavior in JDK itself as many other changes since of Java 9 and we only react on these changes one or two years. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435275114 @cstamas Can you please squash the commits in one? Exclude the `pom.xml` because the master is already on Java 1.7. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435226142 We should see the Manifest. Why this issue does not exist on Windows? I think it should because the code base is in TEMP since the `surefire.jar` (surefire booter) is always on `C:\` and not your Local repo on `D:\`. See the first two sentenses in https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jar.html#classpath Are we sure that we identified the bug and it is in Class-Path of the Manifest?? Why the Main-Class is not found according to the bugs related to Debian dist? The users say the `useSystemClassLoader` helps but it is because environment variable `CLASSPATH` is used with absolute paths. It is a bit contradictory with Manifest's Class-Path. I remember that the spec was different and that the file URL (`file:/path/to/jar`) was supported, so I guess absolute. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435190994 A new branch `3.0.0-M1-J7` went out. It contains API 3.0 and Java 1.7 (SUREFIRE-1493 and SUREFIRE-1474). Let's wait for the Jenkins build... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435186507 @cstamas @rockysingh @jglick Why we did not do it with `java.i.File.toURI()`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435146720 Hi @rfscholte . The CLI in shared-utils executes a subprocess and we in surefire rely on a callback that the process finished. It seems we do not receive this notification and therefore the process waits next 10 seconds till timeout has elapsed. This prolonged ITs from 1 hour to 2 hours. Using the older version 3.1.0 all is same as before. I will have time to debug it after Surefire release. Are you fine with that yet? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-434996412 Now the API 3.0 is applied. I will work on Java 1.7 in that branch. Btw somebody broke the behavior of maven:shared-utils:3.2.0+. I have to use older version 3.1.0. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-434780362 @cstamas I will try to do my bets today. Okay? And then I will ask you to rebase this branch. We can start release tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-434777977 @cstamas This will be a mess in project. As I said please wait a bit, I will fork the issues of 3.0.0-M1 to multiple versions and we will make very frequent releases. That's much better for us and one or two day plus minus is not a difference. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-434721855 Hi @cstamas Thx for the fix. We will release version 3.0.0-M1 nd we discontinued versions 2.x. The only issue is that we develop new version in branch `3.0.0-M1` and there are last things to finish support of Maven Plugin API 3.0 as for instance we want to use `scope=provided` on Maven api dependencies. It should be finished these days. Next problem is unstable ASF Jenkins. I hope the INFRA team will fix it soon. Then I plan is to have Java 1.7, see https://issues.apache.org/jira/browse/SUREFIRE-1474, on the top of the branch `3.0.0-M1` which includes your change with JavaVersion property and Java code in I/O. But I would rather wait with this PR few days and rebase it after `SUREFIRE-1474` has been finished too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
