[GitHub] michael-o commented on a change in pull request #81: SCM-486

[GitBox]

michael-o commented on a change in pull request #81: SCM-486
URL: https://github.com/apache/maven-scm/pull/81#discussion_r209435711
 
 

 ##
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/ScmTagParameters.java
 ##
 @@ -36,6 +36,8 @@
 
 private boolean pinExternals = false;
 
+private boolean sign = false;
+
 
 Review comment:
   For consistency, add to the default (empty) constructor with `false`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michael-o commented on a change in pull request #81: SCM-486

[GitBox]

michael-o commented on a change in pull request #81: SCM-486
URL: https://github.com/apache/maven-scm/pull/81#discussion_r209435590
 
 

 ##
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/ScmTagParameters.java
 ##
 @@ -79,6 +81,16 @@ public void setPinExternals( boolean pinExternals )
 this.pinExternals = pinExternals;
 }
 
+public boolean isSign()
+{
+return sign;
+}
+
+public void setSign( boolean sign)
 
 Review comment:
   Missing space


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michael-o commented on a change in pull request #81: SCM-486

[GitBox]

michael-o commented on a change in pull request #81: SCM-486
URL: https://github.com/apache/maven-scm/pull/81#discussion_r209435618
 
 

 ##
 File path: 
maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/TagMojo.java
 ##
 @@ -139,12 +147,14 @@ public void execute()
 ScmRepository repository = getScmRepository();
 ScmProvider provider = getScmManager().getProviderByRepository( 
repository );
 
+getLog().info( "Sign: '" + sign+ "'" );
 
 Review comment:
   Please drop this, we don't log the rest anyway. The plugin framework logs 
everything if in debug mode.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michael-o commented on a change in pull request #81: SCM-486

[GitBox]

michael-o commented on a change in pull request #81: SCM-486
URL: https://github.com/apache/maven-scm/pull/81#discussion_r209435687
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/tag/GitTagCommandTest.java
 ##
 @@ -78,7 +78,7 @@ private void testCommandLine( String scmUrl, String tag, 
String commandLine )
 
 GitScmProviderRepository gitRepository = (GitScmProviderRepository) 
repository.getProviderRepository();
 
-Commandline cl = GitTagCommand.createCommandLine( gitRepository, 
workingDirectory, tag, messageFile );
+Commandline cl = GitTagCommand.createCommandLine( gitRepository, 
workingDirectory, tag, messageFile, false );
 
 Review comment:
   Why don't you add the sign case and validate the command line?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michael-o commented on a change in pull request #81: SCM-486

[GitBox]

michael-o commented on a change in pull request #81: SCM-486
URL: https://github.com/apache/maven-scm/pull/81#discussion_r209435631
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/tag/GitTagCommand.java
 ##
 @@ -92,7 +92,9 @@ public ScmResult executeTagCommand( ScmProviderRepository 
repo, ScmFileSet fileS
 
 int exitCode;
 
-Commandline clTag = createCommandLine( repository, 
fileSet.getBasedir(), tag, messageFile );
+boolean sign = scmTagParameters.isSign();
+
+   Commandline clTag = createCommandLine( repository, 
fileSet.getBasedir(), tag, messageFile, sign);
 
 Review comment:
   Space missing


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michael-o commented on a change in pull request #81: SCM-486

[GitBox]

michael-o commented on a change in pull request #81: SCM-486
URL: https://github.com/apache/maven-scm/pull/81#discussion_r209435638
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/tag/GitTagCommand.java
 ##
 @@ -147,10 +149,14 @@ public ScmResult executeTagCommand( 
ScmProviderRepository repo, ScmFileSet fileS
 // --
 
 public static Commandline createCommandLine( GitScmProviderRepository 
repository, File workingDirectory,
- String tag, File messageFile )
+ String tag, File messageFile, 
boolean sign )
 {
 Commandline cl = GitCommandLineUtils.getBaseGitCommandLine( 
workingDirectory, "tag" );
 
+if (sign) {
 
 Review comment:
   Reformat if clause


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services