[GitHub] rfscholte commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module

rfscholte commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162#issuecomment-379483074 This is an important line in the javadoc: > This is a hand-crafted prototype of the default mode

[GitHub] rfscholte commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module

rfscholte commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162#issuecomment-379483074 This is an important line in the javadoc: > This is a hand-crafted prototype of the default mode

[GitHub] rfscholte commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module

rfscholte commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162#issuecomment-379341185 I have to look closely if all required actions are done. E.g. new modules also means updating `mav

[GitHub] rfscholte commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module

rfscholte commented on issue #162: [MNG-6389] - Move toolchains model generation from maven-core to maven-toolchain module URL: https://github.com/apache/maven/pull/162#issuecomment-378739685 I don't think the MavenToolchainMerger belongs there. If you take a look at https://maven.apache.