Re: [PR] Unfurl CLI [maven]
cstamas merged PR #2465: URL: https://github.com/apache/maven/pull/2465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unfurl CLI [maven]
elharo commented on code in PR #2465:
URL: https://github.com/apache/maven/pull/2465#discussion_r2139923019
##
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/BaseParser.java:
##
@@ -149,24 +150,14 @@ public InvokerRequest parseInvocation(ParserRequest
parserRequest) {
}
// options
-List parsedOptions;
try {
-parsedOptions = parseCliOptions(context);
+context.options = parseCliOptions(context);
} catch (Exception e) {
Review Comment:
not in this PR, but this should be a more specific catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
[PR] Unfurl CLI [maven]
cstamas opened a new pull request, #2465: URL: https://github.com/apache/maven/pull/2465 Remove some heavy redundancies, simplify. [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
